Fix for Random failures in System.Numerics.Tests.modpowTest.ModPowAxiom test#74112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dakersnar merged 2 commits into from
Aug 18, 2022
Merged

Fix for Random failures in System.Numerics.Tests.modpowTest.ModPowAxiom test #74112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e189f53
Fixed #70330
sakno Aug 17, 2022
ce0fb71
Removed pessimistic buffer cleanup
sakno Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/libraries/System.Runtime.Numerics/src/System/Numerics/BigIntegerCalculator.PowMod.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -217,7 +217,11 @@ public static void Pow(ReadOnlySpan<uint> value, uint power,
Span<uint> valueCopy = (size <= StackAllocThreshold ?
stackalloc uint[StackAllocThreshold]
: valueCopyFromPool = ArrayPool<uint>.Shared.Rent(size)).Slice(0, size);
valueCopy.Clear();

// smallish optimization here:
// subsequent operations will copy the elements to the beginning of the buffer,
// no need to clear everything
valueCopy.Slice(value.Length).Clear();

if (value.Length > modulus.Length)
{
Expand DownExpand Up@@ -262,7 +266,11 @@ public static void Pow(ReadOnlySpan<uint> value, ReadOnlySpan<uint> power,
Span<uint> valueCopy = (size <= StackAllocThreshold ?
stackalloc uint[StackAllocThreshold]
: valueCopyFromPool = ArrayPool<uint>.Shared.Rent(size)).Slice(0, size);
valueCopy.Clear();

// smallish optimization here:
// subsequent operations will copy the elements to the beginning of the buffer,
// no need to clear everything
valueCopy.Slice(value.Length).Clear();
Comment thread
dakersnar marked this conversation as resolved.

if (value.Length > modulus.Length)
{
Expand DownExpand Up@@ -464,7 +472,7 @@ private static Span<uint> PowCore(Span<uint> value, int valueLength,
power >>= 1;
}

return result.Slice(0, resultLength);

@dakersnardakersnarAug 18, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this slice basically unnecessary in all cases, and causing problems in this edge case?

@saknosaknoAug 18, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, correct. It doesn't exist for overload of PowCore with exponent of arbitrary length.

@tannergoodingtannergoodingAug 25, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this slice introduced a regression for the case of:

value: 174475926811173371108797680334274448482027679060635889276326576767485928691470272416521788770673419883076040463212449631887959313694345475337324466914914839368969988215395980439434099840700753576299320684517028939674493640310781015739837159625716992654178036326745036841619965661654305787656989089177185300627
exponent: 152266387011071825363527751452194927195391511201743678326712300944812006670853968954038119879530327815990523885596782666640476470053822766345969220504425389995206265094671158964311234812226260664473986637197447367726400093404731405598815953979171704175885394570388678952091206779039984338579147114424357147650
modulus: 15548277136038299103

@tannergoodingtannergoodingAug 25, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this scenario, the length of result is greater than the length of bits and so the result.CopyTo(bits) operation fails as the destination is too short.

I expect the actual issue here is that resultLength isn't being correctly tracked somewhere.

@tannergoodingtannergoodingAug 25, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its not that resultLength is incorrect, its that bits will have been mutated and may contain temporary data

return result;
}

private static Span<uint> PowCore(Span<uint> value, int valueLength,
Expand Down
12 changes: 12 additions & 0 deletions src/libraries/System.Runtime.Numerics/tests/BigInteger/modpow.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -274,6 +274,18 @@ public static void ModPowAxiom()
}
}

[Fact]
public static void RegressionIssue70330()
{
byte[] tempByteArray1 = { 226, 32 };
byte[] tempByteArray2 = { 113 };
byte[] tempByteArray3 = { 15, 8, 201, 158, 96, 200, 233, 243, 184, 0, 33, 203, 210, 80, 174, 198, 244, 177, 223, 221, 168, 243, 233, 133, 103, 252, 219, 195, 187, 227, 215, 54, 66, 248, 37, 186, 232, 45, 227, 147, 100, 14, 121, 244, 56, 89, 181, 120, 205, 4, 59, 48, 65, 239, 221, 28, 30, 68, 55, 99, 237, 38, 56, 213, 40, 234, 136, 218, 42, 244, 222, 198, 205 };
VerifyIdentityString(
Print(tempByteArray3) + Print(tempByteArray2) + Print(tempByteArray1) + "tModPow",
Print(tempByteArray3) + Print(tempByteArray2) + Print(tempByteArray1) + "bPow" + " bRemainder"
);
Comment thread
dakersnar marked this conversation as resolved.
}

[Fact]
public static void ModPowBoundary()
{
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Fix for Random failures in System.Numerics.Tests.modpowTest.ModPowAxiom test#74112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

dakersnar
merged 2 commits into

from

Aug 18, 2022
 Merged


Fix for Random failures in System.Numerics.Tests.modpowTest.ModPowAxiom test
#74112
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
e189f53

Fixed #70330


sakno Aug 17, 2022
ce0fb71

Removed pessimistic buffer cleanup


sakno Aug 17, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


14 changes: 11 additions & 3 deletions
src/libraries/System.Runtime.Numerics/src/System/Numerics/BigIntegerCalculator.PowMod.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -217,7 +217,11 @@ public static void Pow(ReadOnlySpan<uint> value, uint power,
 Span<uint> valueCopy = (size <= StackAllocThreshold ?
 stackalloc uint[StackAllocThreshold]
 : valueCopyFromPool = ArrayPool<uint>.Shared.Rent(size)).Slice(0, size);
 valueCopy.Clear();

 // smallish optimization here:
 // subsequent operations will copy the elements to the beginning of the buffer,
 // no need to clear everything
 valueCopy.Slice(value.Length).Clear();

 if (value.Length > modulus.Length)
 {
Expand DownExpand Up@@ -262,7 +266,11 @@ public static void Pow(ReadOnlySpan<uint> value, ReadOnlySpan<uint> power,
 Span<uint> valueCopy = (size <= StackAllocThreshold ?
 stackalloc uint[StackAllocThreshold]
 : valueCopyFromPool = ArrayPool<uint>.Shared.Rent(size)).Slice(0, size);
 valueCopy.Clear();

 // smallish optimization here:
 // subsequent operations will copy the elements to the beginning of the buffer,
 // no need to clear everything
 valueCopy.Slice(value.Length).Clear();
Comment thread
dakersnar marked this conversation as resolved.


 if (value.Length > modulus.Length)
 {
Expand DownExpand Up@@ -464,7 +472,7 @@ private static Span<uint> PowCore(Span<uint> value, int valueLength,
 power >>= 1;
 }

 return result.Slice(0, resultLength);
@dakersnardakersnarAug 18, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this slice basically unnecessary in all cases, and causing problems in this edge case?
@saknosaknoAug 18, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, correct. It doesn't exist for overload of PowCore with exponent of arbitrary length.
@tannergoodingtannergoodingAug 25, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this slice introduced a regression for the case of:
value: 174475926811173371108797680334274448482027679060635889276326576767485928691470272416521788770673419883076040463212449631887959313694345475337324466914914839368969988215395980439434099840700753576299320684517028939674493640310781015739837159625716992654178036326745036841619965661654305787656989089177185300627
exponent: 152266387011071825363527751452194927195391511201743678326712300944812006670853968954038119879530327815990523885596782666640476470053822766345969220504425389995206265094671158964311234812226260664473986637197447367726400093404731405598815953979171704175885394570388678952091206779039984338579147114424357147650
modulus: 15548277136038299103

@tannergoodingtannergoodingAug 25, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this scenario, the length of result is greater than the length of bits and so the result.CopyTo(bits) operation fails as the destination is too short.
I expect the actual issue here is that resultLength isn't being correctly tracked somewhere.
@tannergoodingtannergoodingAug 25, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its not that resultLength is incorrect, its that bits will have been mutated and may contain temporary data
 return result;
 }

 private static Span<uint> PowCore(Span<uint> value, int valueLength,
Expand Down

12 changes: 12 additions & 0 deletions
src/libraries/System.Runtime.Numerics/tests/BigInteger/modpow.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -274,6 +274,18 @@ public static void ModPowAxiom()
 }
 }

 [Fact]
 public static void RegressionIssue70330()
 {
 byte[] tempByteArray1 = { 226, 32 };
 byte[] tempByteArray2 = { 113 };
 byte[] tempByteArray3 = { 15, 8, 201, 158, 96, 200, 233, 243, 184, 0, 33, 203, 210, 80, 174, 198, 244, 177, 223, 221, 168, 243, 233, 133, 103, 252, 219, 195, 187, 227, 215, 54, 66, 248, 37, 186, 232, 45, 227, 147, 100, 14, 121, 244, 56, 89, 181, 120, 205, 4, 59, 48, 65, 239, 221, 28, 30, 68, 55, 99, 237, 38, 56, 213, 40, 234, 136, 218, 42, 244, 222, 198, 205 };
 VerifyIdentityString(
 Print(tempByteArray3) + Print(tempByteArray2) + Print(tempByteArray1) + "tModPow",
 Print(tempByteArray3) + Print(tempByteArray2) + Print(tempByteArray1) + "bPow" + " bRemainder"
 );
Comment thread
dakersnar marked this conversation as resolved.

 }

 [Fact]
 public static void ModPowBoundary()
 {
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix for Random failures in System.Numerics.Tests.modpowTest.ModPowAxiom test#74112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

dakersnar
merged 2 commits into

from

Aug 18, 2022
 Merged


Fix for Random failures in System.Numerics.Tests.modpowTest.ModPowAxiom test
#74112
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
e189f53

Fixed #70330


sakno Aug 17, 2022
ce0fb71

Removed pessimistic buffer cleanup


sakno Aug 17, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


14 changes: 11 additions & 3 deletions
src/libraries/System.Runtime.Numerics/src/System/Numerics/BigIntegerCalculator.PowMod.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -217,7 +217,11 @@ public static void Pow(ReadOnlySpan<uint> value, uint power,
 Span<uint> valueCopy = (size <= StackAllocThreshold ?
 stackalloc uint[StackAllocThreshold]
 : valueCopyFromPool = ArrayPool<uint>.Shared.Rent(size)).Slice(0, size);
 valueCopy.Clear();

 // smallish optimization here:
 // subsequent operations will copy the elements to the beginning of the buffer,
 // no need to clear everything
 valueCopy.Slice(value.Length).Clear();

 if (value.Length > modulus.Length)
 {
Expand DownExpand Up@@ -262,7 +266,11 @@ public static void Pow(ReadOnlySpan<uint> value, ReadOnlySpan<uint> power,
 Span<uint> valueCopy = (size <= StackAllocThreshold ?
 stackalloc uint[StackAllocThreshold]
 : valueCopyFromPool = ArrayPool<uint>.Shared.Rent(size)).Slice(0, size);
 valueCopy.Clear();

 // smallish optimization here:
 // subsequent operations will copy the elements to the beginning of the buffer,
 // no need to clear everything
 valueCopy.Slice(value.Length).Clear();
Comment thread
dakersnar marked this conversation as resolved.


 if (value.Length > modulus.Length)
 {
Expand DownExpand Up@@ -464,7 +472,7 @@ private static Span<uint> PowCore(Span<uint> value, int valueLength,
 power >>= 1;
 }

 return result.Slice(0, resultLength);
@dakersnardakersnarAug 18, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this slice basically unnecessary in all cases, and causing problems in this edge case?
@saknosaknoAug 18, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, correct. It doesn't exist for overload of PowCore with exponent of arbitrary length.
@tannergoodingtannergoodingAug 25, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this slice introduced a regression for the case of:
value: 174475926811173371108797680334274448482027679060635889276326576767485928691470272416521788770673419883076040463212449631887959313694345475337324466914914839368969988215395980439434099840700753576299320684517028939674493640310781015739837159625716992654178036326745036841619965661654305787656989089177185300627
exponent: 152266387011071825363527751452194927195391511201743678326712300944812006670853968954038119879530327815990523885596782666640476470053822766345969220504425389995206265094671158964311234812226260664473986637197447367726400093404731405598815953979171704175885394570388678952091206779039984338579147114424357147650
modulus: 15548277136038299103

@tannergoodingtannergoodingAug 25, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this scenario, the length of result is greater than the length of bits and so the result.CopyTo(bits) operation fails as the destination is too short.
I expect the actual issue here is that resultLength isn't being correctly tracked somewhere.
@tannergoodingtannergoodingAug 25, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its not that resultLength is incorrect, its that bits will have been mutated and may contain temporary data
 return result;
 }

 private static Span<uint> PowCore(Span<uint> value, int valueLength,
Expand Down

12 changes: 12 additions & 0 deletions
src/libraries/System.Runtime.Numerics/tests/BigInteger/modpow.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -274,6 +274,18 @@ public static void ModPowAxiom()
 }
 }

 [Fact]
 public static void RegressionIssue70330()
 {
 byte[] tempByteArray1 = { 226, 32 };
 byte[] tempByteArray2 = { 113 };
 byte[] tempByteArray3 = { 15, 8, 201, 158, 96, 200, 233, 243, 184, 0, 33, 203, 210, 80, 174, 198, 244, 177, 223, 221, 168, 243, 233, 133, 103, 252, 219, 195, 187, 227, 215, 54, 66, 248, 37, 186, 232, 45, 227, 147, 100, 14, 121, 244, 56, 89, 181, 120, 205, 4, 59, 48, 65, 239, 221, 28, 30, 68, 55, 99, 237, 38, 56, 213, 40, 234, 136, 218, 42, 244, 222, 198, 205 };
 VerifyIdentityString(
 Print(tempByteArray3) + Print(tempByteArray2) + Print(tempByteArray1) + "tModPow",
 Print(tempByteArray3) + Print(tempByteArray2) + Print(tempByteArray1) + "bPow" + " bRemainder"
 );
Comment thread
dakersnar marked this conversation as resolved.

 }

 [Fact]
 public static void ModPowBoundary()
 {
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix for Random failures in System.Numerics.Tests.modpowTest.ModPowAxiom test#74112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

dakersnar
merged 2 commits into

from

Aug 18, 2022
 Merged


Fix for Random failures in System.Numerics.Tests.modpowTest.ModPowAxiom test
#74112
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
e189f53

Fixed #70330


sakno Aug 17, 2022
ce0fb71

Removed pessimistic buffer cleanup


sakno Aug 17, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


14 changes: 11 additions & 3 deletions
src/libraries/System.Runtime.Numerics/src/System/Numerics/BigIntegerCalculator.PowMod.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -217,7 +217,11 @@ public static void Pow(ReadOnlySpan<uint> value, uint power,
 Span<uint> valueCopy = (size <= StackAllocThreshold ?
 stackalloc uint[StackAllocThreshold]
 : valueCopyFromPool = ArrayPool<uint>.Shared.Rent(size)).Slice(0, size);
 valueCopy.Clear();

 // smallish optimization here:
 // subsequent operations will copy the elements to the beginning of the buffer,
 // no need to clear everything
 valueCopy.Slice(value.Length).Clear();

 if (value.Length > modulus.Length)
 {
Expand DownExpand Up@@ -262,7 +266,11 @@ public static void Pow(ReadOnlySpan<uint> value, ReadOnlySpan<uint> power,
 Span<uint> valueCopy = (size <= StackAllocThreshold ?
 stackalloc uint[StackAllocThreshold]
 : valueCopyFromPool = ArrayPool<uint>.Shared.Rent(size)).Slice(0, size);
 valueCopy.Clear();

 // smallish optimization here:
 // subsequent operations will copy the elements to the beginning of the buffer,
 // no need to clear everything
 valueCopy.Slice(value.Length).Clear();
Comment thread
dakersnar marked this conversation as resolved.


 if (value.Length > modulus.Length)
 {
Expand DownExpand Up@@ -464,7 +472,7 @@ private static Span<uint> PowCore(Span<uint> value, int valueLength,
 power >>= 1;
 }

 return result.Slice(0, resultLength);
@dakersnardakersnarAug 18, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this slice basically unnecessary in all cases, and causing problems in this edge case?
@saknosaknoAug 18, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, correct. It doesn't exist for overload of PowCore with exponent of arbitrary length.
@tannergoodingtannergoodingAug 25, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this slice introduced a regression for the case of:
value: 174475926811173371108797680334274448482027679060635889276326576767485928691470272416521788770673419883076040463212449631887959313694345475337324466914914839368969988215395980439434099840700753576299320684517028939674493640310781015739837159625716992654178036326745036841619965661654305787656989089177185300627
exponent: 152266387011071825363527751452194927195391511201743678326712300944812006670853968954038119879530327815990523885596782666640476470053822766345969220504425389995206265094671158964311234812226260664473986637197447367726400093404731405598815953979171704175885394570388678952091206779039984338579147114424357147650
modulus: 15548277136038299103

@tannergoodingtannergoodingAug 25, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this scenario, the length of result is greater than the length of bits and so the result.CopyTo(bits) operation fails as the destination is too short.
I expect the actual issue here is that resultLength isn't being correctly tracked somewhere.
@tannergoodingtannergoodingAug 25, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its not that resultLength is incorrect, its that bits will have been mutated and may contain temporary data
 return result;
 }

 private static Span<uint> PowCore(Span<uint> value, int valueLength,
Expand Down

12 changes: 12 additions & 0 deletions
src/libraries/System.Runtime.Numerics/tests/BigInteger/modpow.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -274,6 +274,18 @@ public static void ModPowAxiom()
 }
 }

 [Fact]
 public static void RegressionIssue70330()
 {
 byte[] tempByteArray1 = { 226, 32 };
 byte[] tempByteArray2 = { 113 };
 byte[] tempByteArray3 = { 15, 8, 201, 158, 96, 200, 233, 243, 184, 0, 33, 203, 210, 80, 174, 198, 244, 177, 223, 221, 168, 243, 233, 133, 103, 252, 219, 195, 187, 227, 215, 54, 66, 248, 37, 186, 232, 45, 227, 147, 100, 14, 121, 244, 56, 89, 181, 120, 205, 4, 59, 48, 65, 239, 221, 28, 30, 68, 55, 99, 237, 38, 56, 213, 40, 234, 136, 218, 42, 244, 222, 198, 205 };
 VerifyIdentityString(
 Print(tempByteArray3) + Print(tempByteArray2) + Print(tempByteArray1) + "tModPow",
 Print(tempByteArray3) + Print(tempByteArray2) + Print(tempByteArray1) + "bPow" + " bRemainder"
 );
Comment thread
dakersnar marked this conversation as resolved.

 }

 [Fact]
 public static void ModPowBoundary()
 {
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Fix for Random failures in System.Numerics.Tests.modpowTest.ModPowAxiom test#74112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

dakersnar
merged 2 commits into

from

Aug 18, 2022
 Merged


Fix for Random failures in System.Numerics.Tests.modpowTest.ModPowAxiom test
#74112
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
e189f53

Fixed #70330


sakno Aug 17, 2022
ce0fb71

Removed pessimistic buffer cleanup


sakno Aug 17, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


14 changes: 11 additions & 3 deletions
src/libraries/System.Runtime.Numerics/src/System/Numerics/BigIntegerCalculator.PowMod.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -217,7 +217,11 @@ public static void Pow(ReadOnlySpan<uint> value, uint power,
 Span<uint> valueCopy = (size <= StackAllocThreshold ?
 stackalloc uint[StackAllocThreshold]
 : valueCopyFromPool = ArrayPool<uint>.Shared.Rent(size)).Slice(0, size);
 valueCopy.Clear();

 // smallish optimization here:
 // subsequent operations will copy the elements to the beginning of the buffer,
 // no need to clear everything
 valueCopy.Slice(value.Length).Clear();

 if (value.Length > modulus.Length)
 {
Expand DownExpand Up@@ -262,7 +266,11 @@ public static void Pow(ReadOnlySpan<uint> value, ReadOnlySpan<uint> power,
 Span<uint> valueCopy = (size <= StackAllocThreshold ?
 stackalloc uint[StackAllocThreshold]
 : valueCopyFromPool = ArrayPool<uint>.Shared.Rent(size)).Slice(0, size);
 valueCopy.Clear();

 // smallish optimization here:
 // subsequent operations will copy the elements to the beginning of the buffer,
 // no need to clear everything
 valueCopy.Slice(value.Length).Clear();
Comment thread
dakersnar marked this conversation as resolved.


 if (value.Length > modulus.Length)
 {
Expand DownExpand Up@@ -464,7 +472,7 @@ private static Span<uint> PowCore(Span<uint> value, int valueLength,
 power >>= 1;
 }

 return result.Slice(0, resultLength);
@dakersnardakersnarAug 18, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this slice basically unnecessary in all cases, and causing problems in this edge case?
@saknosaknoAug 18, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, correct. It doesn't exist for overload of PowCore with exponent of arbitrary length.
@tannergoodingtannergoodingAug 25, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this slice introduced a regression for the case of:
value: 174475926811173371108797680334274448482027679060635889276326576767485928691470272416521788770673419883076040463212449631887959313694345475337324466914914839368969988215395980439434099840700753576299320684517028939674493640310781015739837159625716992654178036326745036841619965661654305787656989089177185300627
exponent: 152266387011071825363527751452194927195391511201743678326712300944812006670853968954038119879530327815990523885596782666640476470053822766345969220504425389995206265094671158964311234812226260664473986637197447367726400093404731405598815953979171704175885394570388678952091206779039984338579147114424357147650
modulus: 15548277136038299103

@tannergoodingtannergoodingAug 25, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this scenario, the length of result is greater than the length of bits and so the result.CopyTo(bits) operation fails as the destination is too short.
I expect the actual issue here is that resultLength isn't being correctly tracked somewhere.
@tannergoodingtannergoodingAug 25, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its not that resultLength is incorrect, its that bits will have been mutated and may contain temporary data
 return result;
 }

 private static Span<uint> PowCore(Span<uint> value, int valueLength,
Expand Down

12 changes: 12 additions & 0 deletions
src/libraries/System.Runtime.Numerics/tests/BigInteger/modpow.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -274,6 +274,18 @@ public static void ModPowAxiom()
 }
 }

 [Fact]
 public static void RegressionIssue70330()
 {
 byte[] tempByteArray1 = { 226, 32 };
 byte[] tempByteArray2 = { 113 };
 byte[] tempByteArray3 = { 15, 8, 201, 158, 96, 200, 233, 243, 184, 0, 33, 203, 210, 80, 174, 198, 244, 177, 223, 221, 168, 243, 233, 133, 103, 252, 219, 195, 187, 227, 215, 54, 66, 248, 37, 186, 232, 45, 227, 147, 100, 14, 121, 244, 56, 89, 181, 120, 205, 4, 59, 48, 65, 239, 221, 28, 30, 68, 55, 99, 237, 38, 56, 213, 40, 234, 136, 218, 42, 244, 222, 198, 205 };
 VerifyIdentityString(
 Print(tempByteArray3) + Print(tempByteArray2) + Print(tempByteArray1) + "tModPow",
 Print(tempByteArray3) + Print(tempByteArray2) + Print(tempByteArray1) + "bPow" + " bRemainder"
 );
Comment thread
dakersnar marked this conversation as resolved.

 }

 [Fact]
 public static void ModPowBoundary()
 {
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix for Random failures in System.Numerics.Tests.modpowTest.ModPowAxiom test#74112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

dakersnar
merged 2 commits into

from

Aug 18, 2022
 Merged


Fix for Random failures in System.Numerics.Tests.modpowTest.ModPowAxiom test
#74112
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
e189f53

Fixed #70330


sakno Aug 17, 2022
ce0fb71

Removed pessimistic buffer cleanup


sakno Aug 17, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


14 changes: 11 additions & 3 deletions
src/libraries/System.Runtime.Numerics/src/System/Numerics/BigIntegerCalculator.PowMod.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -217,7 +217,11 @@ public static void Pow(ReadOnlySpan<uint> value, uint power,
 Span<uint> valueCopy = (size <= StackAllocThreshold ?
 stackalloc uint[StackAllocThreshold]
 : valueCopyFromPool = ArrayPool<uint>.Shared.Rent(size)).Slice(0, size);
 valueCopy.Clear();

 // smallish optimization here:
 // subsequent operations will copy the elements to the beginning of the buffer,
 // no need to clear everything
 valueCopy.Slice(value.Length).Clear();

 if (value.Length > modulus.Length)
 {
Expand DownExpand Up@@ -262,7 +266,11 @@ public static void Pow(ReadOnlySpan<uint> value, ReadOnlySpan<uint> power,
 Span<uint> valueCopy = (size <= StackAllocThreshold ?
 stackalloc uint[StackAllocThreshold]
 : valueCopyFromPool = ArrayPool<uint>.Shared.Rent(size)).Slice(0, size);
 valueCopy.Clear();

 // smallish optimization here:
 // subsequent operations will copy the elements to the beginning of the buffer,
 // no need to clear everything
 valueCopy.Slice(value.Length).Clear();
Comment thread
dakersnar marked this conversation as resolved.


 if (value.Length > modulus.Length)
 {
Expand DownExpand Up@@ -464,7 +472,7 @@ private static Span<uint> PowCore(Span<uint> value, int valueLength,
 power >>= 1;
 }

 return result.Slice(0, resultLength);
@dakersnardakersnarAug 18, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this slice basically unnecessary in all cases, and causing problems in this edge case?
@saknosaknoAug 18, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, correct. It doesn't exist for overload of PowCore with exponent of arbitrary length.
@tannergoodingtannergoodingAug 25, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this slice introduced a regression for the case of:
value: 174475926811173371108797680334274448482027679060635889276326576767485928691470272416521788770673419883076040463212449631887959313694345475337324466914914839368969988215395980439434099840700753576299320684517028939674493640310781015739837159625716992654178036326745036841619965661654305787656989089177185300627
exponent: 152266387011071825363527751452194927195391511201743678326712300944812006670853968954038119879530327815990523885596782666640476470053822766345969220504425389995206265094671158964311234812226260664473986637197447367726400093404731405598815953979171704175885394570388678952091206779039984338579147114424357147650
modulus: 15548277136038299103

@tannergoodingtannergoodingAug 25, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this scenario, the length of result is greater than the length of bits and so the result.CopyTo(bits) operation fails as the destination is too short.
I expect the actual issue here is that resultLength isn't being correctly tracked somewhere.
@tannergoodingtannergoodingAug 25, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its not that resultLength is incorrect, its that bits will have been mutated and may contain temporary data
 return result;
 }

 private static Span<uint> PowCore(Span<uint> value, int valueLength,
Expand Down

12 changes: 12 additions & 0 deletions
src/libraries/System.Runtime.Numerics/tests/BigInteger/modpow.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -274,6 +274,18 @@ public static void ModPowAxiom()
 }
 }

 [Fact]
 public static void RegressionIssue70330()
 {
 byte[] tempByteArray1 = { 226, 32 };
 byte[] tempByteArray2 = { 113 };
 byte[] tempByteArray3 = { 15, 8, 201, 158, 96, 200, 233, 243, 184, 0, 33, 203, 210, 80, 174, 198, 244, 177, 223, 221, 168, 243, 233, 133, 103, 252, 219, 195, 187, 227, 215, 54, 66, 248, 37, 186, 232, 45, 227, 147, 100, 14, 121, 244, 56, 89, 181, 120, 205, 4, 59, 48, 65, 239, 221, 28, 30, 68, 55, 99, 237, 38, 56, 213, 40, 234, 136, 218, 42, 244, 222, 198, 205 };
 VerifyIdentityString(
 Print(tempByteArray3) + Print(tempByteArray2) + Print(tempByteArray1) + "tModPow",
 Print(tempByteArray3) + Print(tempByteArray2) + Print(tempByteArray1) + "bPow" + " bRemainder"
 );
Comment thread
dakersnar marked this conversation as resolved.

 }

 [Fact]
 public static void ModPowBoundary()
 {
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix for Random failures in System.Numerics.Tests.modpowTest.ModPowAxiom test#74112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

dakersnar
merged 2 commits into

from

Aug 18, 2022
 Merged


Fix for Random failures in System.Numerics.Tests.modpowTest.ModPowAxiom test
#74112
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
e189f53

Fixed #70330


sakno Aug 17, 2022
ce0fb71

Removed pessimistic buffer cleanup


sakno Aug 17, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


14 changes: 11 additions & 3 deletions
src/libraries/System.Runtime.Numerics/src/System/Numerics/BigIntegerCalculator.PowMod.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -217,7 +217,11 @@ public static void Pow(ReadOnlySpan<uint> value, uint power,
 Span<uint> valueCopy = (size <= StackAllocThreshold ?
 stackalloc uint[StackAllocThreshold]
 : valueCopyFromPool = ArrayPool<uint>.Shared.Rent(size)).Slice(0, size);
 valueCopy.Clear();

 // smallish optimization here:
 // subsequent operations will copy the elements to the beginning of the buffer,
 // no need to clear everything
 valueCopy.Slice(value.Length).Clear();

 if (value.Length > modulus.Length)
 {
Expand DownExpand Up@@ -262,7 +266,11 @@ public static void Pow(ReadOnlySpan<uint> value, ReadOnlySpan<uint> power,
 Span<uint> valueCopy = (size <= StackAllocThreshold ?
 stackalloc uint[StackAllocThreshold]
 : valueCopyFromPool = ArrayPool<uint>.Shared.Rent(size)).Slice(0, size);
 valueCopy.Clear();

 // smallish optimization here:
 // subsequent operations will copy the elements to the beginning of the buffer,
 // no need to clear everything
 valueCopy.Slice(value.Length).Clear();
Comment thread
dakersnar marked this conversation as resolved.


 if (value.Length > modulus.Length)
 {
Expand DownExpand Up@@ -464,7 +472,7 @@ private static Span<uint> PowCore(Span<uint> value, int valueLength,
 power >>= 1;
 }

 return result.Slice(0, resultLength);
@dakersnardakersnarAug 18, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this slice basically unnecessary in all cases, and causing problems in this edge case?
@saknosaknoAug 18, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, correct. It doesn't exist for overload of PowCore with exponent of arbitrary length.
@tannergoodingtannergoodingAug 25, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this slice introduced a regression for the case of:
value: 174475926811173371108797680334274448482027679060635889276326576767485928691470272416521788770673419883076040463212449631887959313694345475337324466914914839368969988215395980439434099840700753576299320684517028939674493640310781015739837159625716992654178036326745036841619965661654305787656989089177185300627
exponent: 152266387011071825363527751452194927195391511201743678326712300944812006670853968954038119879530327815990523885596782666640476470053822766345969220504425389995206265094671158964311234812226260664473986637197447367726400093404731405598815953979171704175885394570388678952091206779039984338579147114424357147650
modulus: 15548277136038299103

@tannergoodingtannergoodingAug 25, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this scenario, the length of result is greater than the length of bits and so the result.CopyTo(bits) operation fails as the destination is too short.
I expect the actual issue here is that resultLength isn't being correctly tracked somewhere.
@tannergoodingtannergoodingAug 25, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its not that resultLength is incorrect, its that bits will have been mutated and may contain temporary data
 return result;
 }

 private static Span<uint> PowCore(Span<uint> value, int valueLength,
Expand Down

12 changes: 12 additions & 0 deletions
src/libraries/System.Runtime.Numerics/tests/BigInteger/modpow.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -274,6 +274,18 @@ public static void ModPowAxiom()
 }
 }

 [Fact]
 public static void RegressionIssue70330()
 {
 byte[] tempByteArray1 = { 226, 32 };
 byte[] tempByteArray2 = { 113 };
 byte[] tempByteArray3 = { 15, 8, 201, 158, 96, 200, 233, 243, 184, 0, 33, 203, 210, 80, 174, 198, 244, 177, 223, 221, 168, 243, 233, 133, 103, 252, 219, 195, 187, 227, 215, 54, 66, 248, 37, 186, 232, 45, 227, 147, 100, 14, 121, 244, 56, 89, 181, 120, 205, 4, 59, 48, 65, 239, 221, 28, 30, 68, 55, 99, 237, 38, 56, 213, 40, 234, 136, 218, 42, 244, 222, 198, 205 };
 VerifyIdentityString(
 Print(tempByteArray3) + Print(tempByteArray2) + Print(tempByteArray1) + "tModPow",
 Print(tempByteArray3) + Print(tempByteArray2) + Print(tempByteArray1) + "bPow" + " bRemainder"
 );
Comment thread
dakersnar marked this conversation as resolved.

 }

 [Fact]
 public static void ModPowBoundary()
 {
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Fix for Random failures in System.Numerics.Tests.modpowTest.ModPowAxiom test#74112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

dakersnar
merged 2 commits into

from

Aug 18, 2022
 Merged


Fix for Random failures in System.Numerics.Tests.modpowTest.ModPowAxiom test
#74112
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
e189f53

Fixed #70330


sakno Aug 17, 2022
ce0fb71

Removed pessimistic buffer cleanup


sakno Aug 17, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


14 changes: 11 additions & 3 deletions
src/libraries/System.Runtime.Numerics/src/System/Numerics/BigIntegerCalculator.PowMod.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -217,7 +217,11 @@ public static void Pow(ReadOnlySpan<uint> value, uint power,
 Span<uint> valueCopy = (size <= StackAllocThreshold ?
 stackalloc uint[StackAllocThreshold]
 : valueCopyFromPool = ArrayPool<uint>.Shared.Rent(size)).Slice(0, size);
 valueCopy.Clear();

 // smallish optimization here:
 // subsequent operations will copy the elements to the beginning of the buffer,
 // no need to clear everything
 valueCopy.Slice(value.Length).Clear();

 if (value.Length > modulus.Length)
 {
Expand DownExpand Up@@ -262,7 +266,11 @@ public static void Pow(ReadOnlySpan<uint> value, ReadOnlySpan<uint> power,
 Span<uint> valueCopy = (size <= StackAllocThreshold ?
 stackalloc uint[StackAllocThreshold]
 : valueCopyFromPool = ArrayPool<uint>.Shared.Rent(size)).Slice(0, size);
 valueCopy.Clear();

 // smallish optimization here:
 // subsequent operations will copy the elements to the beginning of the buffer,
 // no need to clear everything
 valueCopy.Slice(value.Length).Clear();
Comment thread
dakersnar marked this conversation as resolved.


 if (value.Length > modulus.Length)
 {
Expand DownExpand Up@@ -464,7 +472,7 @@ private static Span<uint> PowCore(Span<uint> value, int valueLength,
 power >>= 1;
 }

 return result.Slice(0, resultLength);
@dakersnardakersnarAug 18, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this slice basically unnecessary in all cases, and causing problems in this edge case?
@saknosaknoAug 18, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, correct. It doesn't exist for overload of PowCore with exponent of arbitrary length.
@tannergoodingtannergoodingAug 25, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this slice introduced a regression for the case of:
value: 174475926811173371108797680334274448482027679060635889276326576767485928691470272416521788770673419883076040463212449631887959313694345475337324466914914839368969988215395980439434099840700753576299320684517028939674493640310781015739837159625716992654178036326745036841619965661654305787656989089177185300627
exponent: 152266387011071825363527751452194927195391511201743678326712300944812006670853968954038119879530327815990523885596782666640476470053822766345969220504425389995206265094671158964311234812226260664473986637197447367726400093404731405598815953979171704175885394570388678952091206779039984338579147114424357147650
modulus: 15548277136038299103

@tannergoodingtannergoodingAug 25, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this scenario, the length of result is greater than the length of bits and so the result.CopyTo(bits) operation fails as the destination is too short.
I expect the actual issue here is that resultLength isn't being correctly tracked somewhere.
@tannergoodingtannergoodingAug 25, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its not that resultLength is incorrect, its that bits will have been mutated and may contain temporary data
 return result;
 }

 private static Span<uint> PowCore(Span<uint> value, int valueLength,
Expand Down

12 changes: 12 additions & 0 deletions
src/libraries/System.Runtime.Numerics/tests/BigInteger/modpow.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -274,6 +274,18 @@ public static void ModPowAxiom()
 }
 }

 [Fact]
 public static void RegressionIssue70330()
 {
 byte[] tempByteArray1 = { 226, 32 };
 byte[] tempByteArray2 = { 113 };
 byte[] tempByteArray3 = { 15, 8, 201, 158, 96, 200, 233, 243, 184, 0, 33, 203, 210, 80, 174, 198, 244, 177, 223, 221, 168, 243, 233, 133, 103, 252, 219, 195, 187, 227, 215, 54, 66, 248, 37, 186, 232, 45, 227, 147, 100, 14, 121, 244, 56, 89, 181, 120, 205, 4, 59, 48, 65, 239, 221, 28, 30, 68, 55, 99, 237, 38, 56, 213, 40, 234, 136, 218, 42, 244, 222, 198, 205 };
 VerifyIdentityString(
 Print(tempByteArray3) + Print(tempByteArray2) + Print(tempByteArray1) + "tModPow",
 Print(tempByteArray3) + Print(tempByteArray2) + Print(tempByteArray1) + "bPow" + " bRemainder"
 );
Comment thread
dakersnar marked this conversation as resolved.

 }

 [Fact]
 public static void ModPowBoundary()
 {
Expand Down