Uh oh!
There was an error while loading. Please reload this page.
[release/7.0-rc1] Disable matching constants for vectors that needs upper half to be save/restore - #74192
Conversation
ghost
commented
Aug 18, 2022
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsBackport of #74110 to release/7.0-rc1 /cc @kunalspathak Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. Please get a code review, and once we have a green ci we can merge.
kunalspathak
commented
Aug 18, 2022
@dotnet/jit-contrib @BruceForstall |
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. once we get a clean ci we can merge.
carlossanlop
commented
Aug 20, 2022
Approved and signed off. |
Backport of #74110 to release/7.0-rc1
/cc @kunalspathak
Customer Impact
There was a silent bad codegen issue that would result in wrong result in some cases where
Vector256are involved.Testing
Existing test.
Risk
Compared to .NET 6, nothing. #70171 did see few improvements that we won't see in certain benchmarks.
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.