') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [mono] Disable failing Globalization and Transactions tests by akoeplinger · Pull Request #74433 · dotnet/runtime · GitHub
Skip to content

[mono] Disable failing Globalization and Transactions tests - #74433

Merged
akoeplinger merged 2 commits into
dotnet:mainfrom
akoeplinger:disable-tests
Aug 24, 2022
Merged

[mono] Disable failing Globalization and Transactions tests#74433
akoeplinger merged 2 commits into
dotnet:mainfrom
akoeplinger:disable-tests

Conversation

@akoeplinger

@akoeplingerakoeplinger commented Aug 23, 2022•
edited by karelz
Loading

Copy link
Copy Markdown
Member

The System.Transactions.Tests.OleTxTests aren't supported by Mono on Windows: #74187
Fixes#74187

The System.Globalization test failure is a real issue that is being investigated: #74179
Disable tests against #74179

@akoeplinger
[mono] Disable failing Globalization and Transactions tests
56b75f2
The System.Transactions.Tests.OleTxTests aren't supported by Mono on Windows: dotnet#74187
The System.Globalization test failure is a real issue that is being investigated: dotnet#74179
@akoeplinger

akoeplinger commented Aug 23, 2022

Copy link
Copy Markdown
MemberAuthor

/backport to release/7.0-rc1

@ghost

ghost commented Aug 23, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

The System.Transactions.Tests.OleTxTests aren't supported by Mono on Windows: #74187

The System.Globalization test failure is a real issue that is being investigated: #74179

Author:akoeplinger
Assignees:akoeplinger
Labels:

area-System.Globalization

Milestone:-

@github-actions

github-actionsBot commented Aug 23, 2022

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0-rc1: https://github.com/dotnet/runtime/actions/runs/2912635270

@github-actions

github-actionsBot commented Aug 23, 2022

Copy link
Copy Markdown
Contributor

@akoeplinger backporting to release/7.0-rc1 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Patch format detection failed.
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@akoeplinger

akoeplinger commented Aug 23, 2022

Copy link
Copy Markdown
MemberAuthor

Looks like there's an issue with GitHub since the .patch URL returns 404.

@lateralusX
lateralusX self-requested a review August 23, 2022 15:22
@akoeplinger

akoeplinger commented Aug 23, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Aug 23, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@lateralusXlateralusX mentioned this pull request Aug 23, 2022
Closed
@akoeplinger

akoeplinger commented Aug 23, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Aug 23, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@tarekghtarekgh added the runtime-mono specific to the Mono runtime label Aug 23, 2022
@akoeplinger

akoeplinger commented Aug 23, 2022

Copy link
Copy Markdown
MemberAuthor

/backport to release/7.0

@github-actions

github-actionsBot commented Aug 23, 2022

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/2914511315

@github-actionsgithub-actionsBot mentioned this pull request Aug 23, 2022
Merged
@akoeplinger
akoeplinger merged commit e846cf8 into dotnet:mainAug 24, 2022
@akoeplinger
akoeplinger deleted the disable-tests branch August 24, 2022 02:21
@AaronRobinsonMSFTAaronRobinsonMSFT mentioned this pull request Aug 24, 2022
Closed
@CarnaViireCarnaViire mentioned this pull request Aug 24, 2022
Closed
lateralusX added a commit to lateralusX/runtime that referenced this pull request Aug 25, 2022
@lateralusX
Re-enable globalization tests disabled indotnet#74433.
eec9819
github-actionsBot pushed a commit that referenced this pull request Aug 29, 2022
@lateralusX
Re-enable globalization tests disabled in#74433.
16332ed
lateralusX added a commit that referenced this pull request Aug 29, 2022
@lateralusX
Use System.Numerics.IEqualityOperators.op_Equality in SpanHelper.T.cs…
edb7d7e
… where possible. (#74567)
* Use System.Numerics.IEqualityOperators.op_Equality in SpanHelper.T.cs.
Workaround crash hit by #74179
making sure we avoid hitting codepath emitting this null pointer checks.
The full fix includes codegen fixes as well, but will be performed
in separate PR. There are still locations in SpanHelper.T.cs that uses
Equal virtual call on value types that could be managed pointers to
value types, but that code has remained the same for the last
4 years to 15 months and have not hit this issue in the past.
* Re-enable globalization tests disabled in #74433.
danmoseley pushed a commit that referenced this pull request Aug 29, 2022
@github-actions@lateralusX
[release/7.0] Use System.Numerics.IEqualityOperators.op_Equality in S…
099304f
…panHelper.T.cs where possible. (#74738)
* Use System.Numerics.IEqualityOperators.op_Equality in SpanHelper.T.cs.
Workaround crash hit by #74179
making sure we avoid hitting codepath emitting this null pointer checks.
The full fix includes codegen fixes as well, but will be performed
in separate PR. There are still locations in SpanHelper.T.cs that uses
Equal virtual call on value types that could be managed pointers to
value types, but that code has remained the same for the last
4 years to 15 months and have not hit this issue in the past.
* Re-enable globalization tests disabled in #74433.
Co-authored-by: lateralusX <lateralusx.github@gmail.com>
@ghostghost locked as resolved and limited conversation to collaborators Sep 23, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tarekghtarekghtarekgh approved these changes
@lateralusXlateralusXlateralusX approved these changes

Assignees

@akoeplingerakoeplinger

Labels

area-System.Globalizationruntime-monospecific to the Mono runtime

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI failure: Marshalling of type object is not implemented - Constructor parameters did not have matching fixture data: OleTxFixture fixture

3 participants

@akoeplinger@tarekgh@lateralusX