Skip to content

Use System.Numerics.IEqualityOperators.op_Equality in SpanHelper.T.cs where possible. - #74567

Merged
lateralusX merged 2 commits into
dotnet:mainfrom
lateralusX:lateralusX/fix-74179-spanhelper
Aug 29, 2022
Merged

Use System.Numerics.IEqualityOperators.op_Equality in SpanHelper.T.cs where possible.#74567
lateralusX merged 2 commits into
dotnet:mainfrom
lateralusX:lateralusX/fix-74179-spanhelper

Conversation

@lateralusX

@lateralusXlateralusX commented Aug 25, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Workaround crash hit by #74179 making sure we avoid hitting codepath emitting this null pointer checks. The full fix includes codegen fixes as well, but will be performed in separate PR. There are still locations in SpanHelper.T.cs that uses Equal virtual call on value types that could be managed pointers to value types, but that code has remained the same for the last 4 years to 15 months and have not hit this issue in the past.

Fixes#74179.

Full fix for underlying codegen issue, #74638.

@lateralusX
Use System.Numerics.IEqualityOperators.op_Equality in SpanHelper.T.cs.
bc8d9bd
Workaround crash hit by dotnet#74179
making sure we avoid hitting codepath emitting this null pointer checks.
The full fix includes codegen fixes as well, but will be performed
in separate PR. There are still locations in SpanHelper.T.cs that uses
Equal virtual call on value types that could be managed pointers to
value types, but that code has remained the same for the last
4 years to 15 months and have not hit this issue in the past.
@lateralusX
Re-enable globalization tests disabled indotnet#74433.
eec9819
@ghostghost assigned lateralusXAug 25, 2022
@ghost

ghost commented Aug 25, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

Workaround crash hit by #74179 making sure we avoid hitting codepath emitting this null pointer checks. The full fix includes codegen fixes as well, but will be performed in separate PR. There are still locations in SpanHelper.T.cs that uses Equal virtual call on value types that could be managed pointers to value types, but that code has remained the same for the last 4 years to 15 months and have not hit this issue in the past.

Fixes #74179.

Author:lateralusX
Assignees:-
Labels:

area-System.Globalization

Milestone:-

@lateralusXlateralusX added the runtime-mono specific to the Mono runtime label Aug 25, 2022
adamsitnik
adamsitnik approved these changes Aug 25, 2022
View reviewed changes

@adamsitnikadamsitnik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much for investigating this complex issue @lateralusX !

@ghost

ghost commented Aug 25, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-memory
See info in area-owners.md if you want to be subscribed.

Issue Details

Workaround crash hit by #74179 making sure we avoid hitting codepath emitting this null pointer checks. The full fix includes codegen fixes as well, but will be performed in separate PR. There are still locations in SpanHelper.T.cs that uses Equal virtual call on value types that could be managed pointers to value types, but that code has remained the same for the last 4 years to 15 months and have not hit this issue in the past.

Fixes #74179.

Author:lateralusX
Assignees:lateralusX
Labels:

area-System.Memory, runtime-mono

Milestone:-

@lateralusX

lateralusX commented Aug 26, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Aug 26, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@lambdageek

lambdageek commented Aug 26, 2022

Copy link
Copy Markdown
Member

Equal virtual call on value types that could be managed pointers to value types

@lateralusX just to make sure I understand: Mono does emit correct code for these calls, right? except that we use a 32-bit read for the null check? So once we change the null check to stay in-bounds there are no other codegen issues?

the workaround here is actually some kind of micro-optimization to avoid boxing that also happens to avoid the null-check?

@lateralusX

lateralusX commented Aug 26, 2022•
edited by akoeplinger
Loading

Copy link
Copy Markdown
MemberAuthor

@lambdageek, since this specific code has a constraint on where TValue : struct, INumber<TValue> its possible to use == that in turn will use System.Numerics.IEqualityOperators`3<!!TValue,!!TValue,bool>::op_Equality for the compare, so it won't trigger a virtual call, meaning it won't hit our code path that injects an OP_CHECK_THIS that in turn would have done a read that could have read pass end of buffer into unallocated memory or a page with no read access.

This will mitigate the issue introduced by changes to SpanHelpers.T.cs, but could of course happen in other areas, so the full codegen fix is needed to fully mitigate the issue, but due to potential risk, it was split into two PR's, meaning we could just backport this to 7.0 and would be back to the state we had before recent optimizations to SpanHelpers.T.cs. or we could backport both and then this fix will mainly just be eliminating the virtual call that gets devirtualized and inlined, so mainly just eliminate the addition OP_CHECK_THIS.

So our virtual calls are fine, just that our lowering of OP_CHECK_THIS reads to much memory, that is fixed by #74638.

@lateralusX

lateralusX commented Aug 29, 2022

Copy link
Copy Markdown
MemberAuthor

Failures in runtime-extra-platforms unrelated.

@lateralusX

lateralusX commented Aug 29, 2022

Copy link
Copy Markdown
MemberAuthor

/backport to release/7.0

@github-actions

github-actionsBot commented Aug 29, 2022

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/2946871738

@github-actionsgithub-actionsBot mentioned this pull request Aug 29, 2022
Merged
@lateralusX
lateralusX merged commit edb7d7e into dotnet:mainAug 29, 2022
@karelzkarelz added this to the 8.0.0 milestone Aug 29, 2022
@lateralusXlateralusX mentioned this pull request Aug 30, 2022
Merged
@ghostghost locked as resolved and limited conversation to collaborators Sep 28, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@akoeplingerakoeplingerakoeplinger approved these changes
@adamsitnikadamsitnikadamsitnik approved these changes

Assignees

@lateralusXlateralusX

Labels

area-System.Memoryruntime-monospecific to the Mono runtime

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

CI failure: System.Globalization.Tests.InvariantModeTests.TestLastIndexOf, object reference not set to an instance of an object

6 participants

@lateralusX@lambdageek@akoeplinger@adamsitnik@karelz@tarekgh
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Use System.Numerics.IEqualityOperators.op_Equality in SpanHelper.T.cs where possible. by lateralusX · Pull Request #74567 · dotnet/runtime · GitHub
Skip to content
Use System.Numerics.IEqualityOperators.op_Equality in SpanHelper.T.cs where possible. - #74567
Merged
lateralusX merged 2 commits into
dotnet:mainfrom 
lateralusX:lateralusX/fix-74179-spanhelper
Aug 29, 2022
Merged
Use System.Numerics.IEqualityOperators.op_Equality in SpanHelper.T.cs where possible.#74567
lateralusX merged 2 commits into
dotnet:mainfrom 
lateralusX:lateralusX/fix-74179-spanhelper
Conversation
@lateralusX
@lateralusXlateralusX
commented
Aug 25, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Workaround crash hit by #74179 making sure we avoid hitting codepath emitting this null pointer checks. The full fix includes codegen fixes as well, but will be performed in separate PR. There are still locations in SpanHelper.T.cs that uses Equal virtual call on value types that could be managed pointers to value types, but that code has remained the same for the last 4 years to 15 months and have not hit this issue in the past.
Fixes#74179.
Full fix for underlying codegen issue, #74638.
@lateralusX
Use System.Numerics.IEqualityOperators.op_Equality in SpanHelper.T.cs.
bc8d9bd
Workaround crash hit by dotnet#74179
making sure we avoid hitting codepath emitting this null pointer checks.
The full fix includes codegen fixes as well, but will be performed
in separate PR. There are still locations in SpanHelper.T.cs that uses
Equal virtual call on value types that could be managed pointers to
value types, but that code has remained the same for the last
4 years to 15 months and have not hit this issue in the past.
@lateralusX
Re-enable globalization tests disabled indotnet#74433.
eec9819
@ghostghost
assigned lateralusXAug 25, 2022
@ghost
ghost
commented
Aug 25, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-globalization

See info in area-owners.md if you want to be subscribed.
Issue Details
Workaround crash hit by #74179 making sure we avoid hitting codepath emitting this null pointer checks. The full fix includes codegen fixes as well, but will be performed in separate PR. There are still locations in SpanHelper.T.cs that uses Equal virtual call on value types that could be managed pointers to value types, but that code has remained the same for the last 4 years to 15 months and have not hit this issue in the past.
Fixes #74179.
Author:lateralusX
Assignees:-
Labels:
area-System.Globalization
Milestone:-
@lateralusXlateralusX
added
the 
runtime-mono
specific to the Mono runtime
label
Aug 25, 2022
adamsitnik
adamsitnik
approved these changes
Aug 25, 2022
View reviewed changes
@adamsitnikadamsitnik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much for investigating this complex issue @lateralusX !
@ghost
ghost
commented
Aug 25, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-memory

See info in area-owners.md if you want to be subscribed.
Issue Details
Workaround crash hit by #74179 making sure we avoid hitting codepath emitting this null pointer checks. The full fix includes codegen fixes as well, but will be performed in separate PR. There are still locations in SpanHelper.T.cs that uses Equal virtual call on value types that could be managed pointers to value types, but that code has remained the same for the last 4 years to 15 months and have not hit this issue in the past.
Fixes #74179.
Author:lateralusX
Assignees:lateralusX
Labels:
area-System.Memory, runtime-mono
Milestone:-
@lateralusX
lateralusX
commented
Aug 26, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Aug 26, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@lambdageek
lambdageek
commented
Aug 26, 2022

Copy link


Copy Markdown

Member
Equal virtual call on value types that could be managed pointers to value types
@lateralusX just to make sure I understand: Mono does emit correct code for these calls, right? except that we use a 32-bit read for the null check? So once we change the null check to stay in-bounds there are no other codegen issues?
the workaround here is actually some kind of micro-optimization to avoid boxing that also happens to avoid the null-check?
@lateralusX
lateralusX
commented
Aug 26, 2022•

edited by akoeplinger

Loading

Copy link


Copy Markdown

MemberAuthor
@lambdageek, since this specific code has a constraint on where TValue : struct, INumber<TValue> its possible to use == that in turn will use System.Numerics.IEqualityOperators`3<!!TValue,!!TValue,bool>::op_Equality for the compare, so it won't trigger a virtual call, meaning it won't hit our code path that injects an OP_CHECK_THIS that in turn would have done a read that could have read pass end of buffer into unallocated memory or a page with no read access.
This will mitigate the issue introduced by changes to SpanHelpers.T.cs, but could of course happen in other areas, so the full codegen fix is needed to fully mitigate the issue, but due to potential risk, it was split into two PR's, meaning we could just backport this to 7.0 and would be back to the state we had before recent optimizations to SpanHelpers.T.cs. or we could backport both and then this fix will mainly just be eliminating the virtual call that gets devirtualized and inlined, so mainly just eliminate the addition OP_CHECK_THIS.
So our virtual calls are fine, just that our lowering of OP_CHECK_THIS reads to much memory, that is fixed by #74638.
@lateralusX
lateralusX
commented
Aug 29, 2022

Copy link


Copy Markdown

MemberAuthor
Failures in runtime-extra-platforms unrelated.
@lateralusX
lateralusX
commented
Aug 29, 2022

Copy link


Copy Markdown

MemberAuthor
/backport to release/7.0
@github-actions
github-actionsBot
commented
Aug 29, 2022

Copy link


Copy Markdown

Contributor
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/2946871738
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 29, 2022
 Merged

@lateralusX
lateralusX
merged commit edb7d7e
into
dotnet:mainAug 29, 2022
@karelzkarelz
added this to the 8.0.0 milestone
Aug 29, 2022
@lateralusXlateralusX
mentioned this pull request
Aug 30, 2022
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 28, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@akoeplingerakoeplingerakoeplinger approved these changes
@adamsitnikadamsitnikadamsitnik approved these changes

Assignees

@lateralusXlateralusX

Labels

area-System.Memoryruntime-monospecific to the Mono runtime

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

CI failure: System.Globalization.Tests.InvariantModeTests.TestLastIndexOf, object reference not set to an instance of an object


6 participants

@lateralusX@lambdageek@akoeplinger@adamsitnik@karelz@tarekgh

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Use System.Numerics.IEqualityOperators.op_Equality in SpanHelper.T.cs where possible. by lateralusX · Pull Request #74567 · dotnet/runtime · GitHub
Skip to content
Use System.Numerics.IEqualityOperators.op_Equality in SpanHelper.T.cs where possible. - #74567
Merged
lateralusX merged 2 commits into
dotnet:mainfrom 
lateralusX:lateralusX/fix-74179-spanhelper
Aug 29, 2022
Merged
Use System.Numerics.IEqualityOperators.op_Equality in SpanHelper.T.cs where possible.#74567
lateralusX merged 2 commits into
dotnet:mainfrom 
lateralusX:lateralusX/fix-74179-spanhelper
Conversation
@lateralusX
@lateralusXlateralusX
commented
Aug 25, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Workaround crash hit by #74179 making sure we avoid hitting codepath emitting this null pointer checks. The full fix includes codegen fixes as well, but will be performed in separate PR. There are still locations in SpanHelper.T.cs that uses Equal virtual call on value types that could be managed pointers to value types, but that code has remained the same for the last 4 years to 15 months and have not hit this issue in the past.
Fixes#74179.
Full fix for underlying codegen issue, #74638.
@lateralusX
Use System.Numerics.IEqualityOperators.op_Equality in SpanHelper.T.cs.
bc8d9bd
Workaround crash hit by dotnet#74179
making sure we avoid hitting codepath emitting this null pointer checks.
The full fix includes codegen fixes as well, but will be performed
in separate PR. There are still locations in SpanHelper.T.cs that uses
Equal virtual call on value types that could be managed pointers to
value types, but that code has remained the same for the last
4 years to 15 months and have not hit this issue in the past.
@lateralusX
Re-enable globalization tests disabled indotnet#74433.
eec9819
@ghostghost
assigned lateralusXAug 25, 2022
@ghost
ghost
commented
Aug 25, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-globalization

See info in area-owners.md if you want to be subscribed.
Issue Details
Workaround crash hit by #74179 making sure we avoid hitting codepath emitting this null pointer checks. The full fix includes codegen fixes as well, but will be performed in separate PR. There are still locations in SpanHelper.T.cs that uses Equal virtual call on value types that could be managed pointers to value types, but that code has remained the same for the last 4 years to 15 months and have not hit this issue in the past.
Fixes #74179.
Author:lateralusX
Assignees:-
Labels:
area-System.Globalization
Milestone:-
@lateralusXlateralusX
added
the 
runtime-mono
specific to the Mono runtime
label
Aug 25, 2022
adamsitnik
adamsitnik
approved these changes
Aug 25, 2022
View reviewed changes
@adamsitnikadamsitnik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much for investigating this complex issue @lateralusX !
@ghost
ghost
commented
Aug 25, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-memory

See info in area-owners.md if you want to be subscribed.
Issue Details
Workaround crash hit by #74179 making sure we avoid hitting codepath emitting this null pointer checks. The full fix includes codegen fixes as well, but will be performed in separate PR. There are still locations in SpanHelper.T.cs that uses Equal virtual call on value types that could be managed pointers to value types, but that code has remained the same for the last 4 years to 15 months and have not hit this issue in the past.
Fixes #74179.
Author:lateralusX
Assignees:lateralusX
Labels:
area-System.Memory, runtime-mono
Milestone:-
@lateralusX
lateralusX
commented
Aug 26, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Aug 26, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@lambdageek
lambdageek
commented
Aug 26, 2022

Copy link


Copy Markdown

Member
Equal virtual call on value types that could be managed pointers to value types
@lateralusX just to make sure I understand: Mono does emit correct code for these calls, right? except that we use a 32-bit read for the null check? So once we change the null check to stay in-bounds there are no other codegen issues?
the workaround here is actually some kind of micro-optimization to avoid boxing that also happens to avoid the null-check?
@lateralusX
lateralusX
commented
Aug 26, 2022•

edited by akoeplinger

Loading

Copy link


Copy Markdown

MemberAuthor
@lambdageek, since this specific code has a constraint on where TValue : struct, INumber<TValue> its possible to use == that in turn will use System.Numerics.IEqualityOperators`3<!!TValue,!!TValue,bool>::op_Equality for the compare, so it won't trigger a virtual call, meaning it won't hit our code path that injects an OP_CHECK_THIS that in turn would have done a read that could have read pass end of buffer into unallocated memory or a page with no read access.
This will mitigate the issue introduced by changes to SpanHelpers.T.cs, but could of course happen in other areas, so the full codegen fix is needed to fully mitigate the issue, but due to potential risk, it was split into two PR's, meaning we could just backport this to 7.0 and would be back to the state we had before recent optimizations to SpanHelpers.T.cs. or we could backport both and then this fix will mainly just be eliminating the virtual call that gets devirtualized and inlined, so mainly just eliminate the addition OP_CHECK_THIS.
So our virtual calls are fine, just that our lowering of OP_CHECK_THIS reads to much memory, that is fixed by #74638.
@lateralusX
lateralusX
commented
Aug 29, 2022

Copy link


Copy Markdown

MemberAuthor
Failures in runtime-extra-platforms unrelated.
@lateralusX
lateralusX
commented
Aug 29, 2022

Copy link


Copy Markdown

MemberAuthor
/backport to release/7.0
@github-actions
github-actionsBot
commented
Aug 29, 2022

Copy link


Copy Markdown

Contributor
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/2946871738
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 29, 2022
 Merged

@lateralusX
lateralusX
merged commit edb7d7e
into
dotnet:mainAug 29, 2022
@karelzkarelz
added this to the 8.0.0 milestone
Aug 29, 2022
@lateralusXlateralusX
mentioned this pull request
Aug 30, 2022
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 28, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@akoeplingerakoeplingerakoeplinger approved these changes
@adamsitnikadamsitnikadamsitnik approved these changes

Assignees

@lateralusXlateralusX

Labels

area-System.Memoryruntime-monospecific to the Mono runtime

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

CI failure: System.Globalization.Tests.InvariantModeTests.TestLastIndexOf, object reference not set to an instance of an object


6 participants

@lateralusX@lambdageek@akoeplinger@adamsitnik@karelz@tarekgh

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Use System.Numerics.IEqualityOperators.op_Equality in SpanHelper.T.cs where possible. by lateralusX · Pull Request #74567 · dotnet/runtime · GitHub
Skip to content
Use System.Numerics.IEqualityOperators.op_Equality in SpanHelper.T.cs where possible. - #74567
Merged
lateralusX merged 2 commits into
dotnet:mainfrom 
lateralusX:lateralusX/fix-74179-spanhelper
Aug 29, 2022
Merged
Use System.Numerics.IEqualityOperators.op_Equality in SpanHelper.T.cs where possible.#74567
lateralusX merged 2 commits into
dotnet:mainfrom 
lateralusX:lateralusX/fix-74179-spanhelper
Conversation
@lateralusX
@lateralusXlateralusX
commented
Aug 25, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Workaround crash hit by #74179 making sure we avoid hitting codepath emitting this null pointer checks. The full fix includes codegen fixes as well, but will be performed in separate PR. There are still locations in SpanHelper.T.cs that uses Equal virtual call on value types that could be managed pointers to value types, but that code has remained the same for the last 4 years to 15 months and have not hit this issue in the past.
Fixes#74179.
Full fix for underlying codegen issue, #74638.
@lateralusX
Use System.Numerics.IEqualityOperators.op_Equality in SpanHelper.T.cs.
bc8d9bd
Workaround crash hit by dotnet#74179
making sure we avoid hitting codepath emitting this null pointer checks.
The full fix includes codegen fixes as well, but will be performed
in separate PR. There are still locations in SpanHelper.T.cs that uses
Equal virtual call on value types that could be managed pointers to
value types, but that code has remained the same for the last
4 years to 15 months and have not hit this issue in the past.
@lateralusX
Re-enable globalization tests disabled indotnet#74433.
eec9819
@ghostghost
assigned lateralusXAug 25, 2022
@ghost
ghost
commented
Aug 25, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-globalization

See info in area-owners.md if you want to be subscribed.
Issue Details
Workaround crash hit by #74179 making sure we avoid hitting codepath emitting this null pointer checks. The full fix includes codegen fixes as well, but will be performed in separate PR. There are still locations in SpanHelper.T.cs that uses Equal virtual call on value types that could be managed pointers to value types, but that code has remained the same for the last 4 years to 15 months and have not hit this issue in the past.
Fixes #74179.
Author:lateralusX
Assignees:-
Labels:
area-System.Globalization
Milestone:-
@lateralusXlateralusX
added
the 
runtime-mono
specific to the Mono runtime
label
Aug 25, 2022
adamsitnik
adamsitnik
approved these changes
Aug 25, 2022
View reviewed changes
@adamsitnikadamsitnik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much for investigating this complex issue @lateralusX !
@ghost
ghost
commented
Aug 25, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-memory

See info in area-owners.md if you want to be subscribed.
Issue Details
Workaround crash hit by #74179 making sure we avoid hitting codepath emitting this null pointer checks. The full fix includes codegen fixes as well, but will be performed in separate PR. There are still locations in SpanHelper.T.cs that uses Equal virtual call on value types that could be managed pointers to value types, but that code has remained the same for the last 4 years to 15 months and have not hit this issue in the past.
Fixes #74179.
Author:lateralusX
Assignees:lateralusX
Labels:
area-System.Memory, runtime-mono
Milestone:-
@lateralusX
lateralusX
commented
Aug 26, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Aug 26, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@lambdageek
lambdageek
commented
Aug 26, 2022

Copy link


Copy Markdown

Member
Equal virtual call on value types that could be managed pointers to value types
@lateralusX just to make sure I understand: Mono does emit correct code for these calls, right? except that we use a 32-bit read for the null check? So once we change the null check to stay in-bounds there are no other codegen issues?
the workaround here is actually some kind of micro-optimization to avoid boxing that also happens to avoid the null-check?
@lateralusX
lateralusX
commented
Aug 26, 2022•

edited by akoeplinger

Loading

Copy link


Copy Markdown

MemberAuthor
@lambdageek, since this specific code has a constraint on where TValue : struct, INumber<TValue> its possible to use == that in turn will use System.Numerics.IEqualityOperators`3<!!TValue,!!TValue,bool>::op_Equality for the compare, so it won't trigger a virtual call, meaning it won't hit our code path that injects an OP_CHECK_THIS that in turn would have done a read that could have read pass end of buffer into unallocated memory or a page with no read access.
This will mitigate the issue introduced by changes to SpanHelpers.T.cs, but could of course happen in other areas, so the full codegen fix is needed to fully mitigate the issue, but due to potential risk, it was split into two PR's, meaning we could just backport this to 7.0 and would be back to the state we had before recent optimizations to SpanHelpers.T.cs. or we could backport both and then this fix will mainly just be eliminating the virtual call that gets devirtualized and inlined, so mainly just eliminate the addition OP_CHECK_THIS.
So our virtual calls are fine, just that our lowering of OP_CHECK_THIS reads to much memory, that is fixed by #74638.
@lateralusX
lateralusX
commented
Aug 29, 2022

Copy link


Copy Markdown

MemberAuthor
Failures in runtime-extra-platforms unrelated.
@lateralusX
lateralusX
commented
Aug 29, 2022

Copy link


Copy Markdown

MemberAuthor
/backport to release/7.0
@github-actions
github-actionsBot
commented
Aug 29, 2022

Copy link


Copy Markdown

Contributor
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/2946871738
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 29, 2022
 Merged

@lateralusX
lateralusX
merged commit edb7d7e
into
dotnet:mainAug 29, 2022
@karelzkarelz
added this to the 8.0.0 milestone
Aug 29, 2022
@lateralusXlateralusX
mentioned this pull request
Aug 30, 2022
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 28, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@akoeplingerakoeplingerakoeplinger approved these changes
@adamsitnikadamsitnikadamsitnik approved these changes

Assignees

@lateralusXlateralusX

Labels

area-System.Memoryruntime-monospecific to the Mono runtime

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

CI failure: System.Globalization.Tests.InvariantModeTests.TestLastIndexOf, object reference not set to an instance of an object


6 participants

@lateralusX@lambdageek@akoeplinger@adamsitnik@karelz@tarekgh

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Use System.Numerics.IEqualityOperators.op_Equality in SpanHelper.T.cs where possible. by lateralusX · Pull Request #74567 · dotnet/runtime · GitHub
Skip to content
Use System.Numerics.IEqualityOperators.op_Equality in SpanHelper.T.cs where possible. - #74567
Merged
lateralusX merged 2 commits into
dotnet:mainfrom 
lateralusX:lateralusX/fix-74179-spanhelper
Aug 29, 2022
Merged
Use System.Numerics.IEqualityOperators.op_Equality in SpanHelper.T.cs where possible.#74567
lateralusX merged 2 commits into
dotnet:mainfrom 
lateralusX:lateralusX/fix-74179-spanhelper
Conversation
@lateralusX
@lateralusXlateralusX
commented
Aug 25, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Workaround crash hit by #74179 making sure we avoid hitting codepath emitting this null pointer checks. The full fix includes codegen fixes as well, but will be performed in separate PR. There are still locations in SpanHelper.T.cs that uses Equal virtual call on value types that could be managed pointers to value types, but that code has remained the same for the last 4 years to 15 months and have not hit this issue in the past.
Fixes#74179.
Full fix for underlying codegen issue, #74638.
@lateralusX
Use System.Numerics.IEqualityOperators.op_Equality in SpanHelper.T.cs.
bc8d9bd
Workaround crash hit by dotnet#74179
making sure we avoid hitting codepath emitting this null pointer checks.
The full fix includes codegen fixes as well, but will be performed
in separate PR. There are still locations in SpanHelper.T.cs that uses
Equal virtual call on value types that could be managed pointers to
value types, but that code has remained the same for the last
4 years to 15 months and have not hit this issue in the past.
@lateralusX
Re-enable globalization tests disabled indotnet#74433.
eec9819
@ghostghost
assigned lateralusXAug 25, 2022
@ghost
ghost
commented
Aug 25, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-globalization

See info in area-owners.md if you want to be subscribed.
Issue Details
Workaround crash hit by #74179 making sure we avoid hitting codepath emitting this null pointer checks. The full fix includes codegen fixes as well, but will be performed in separate PR. There are still locations in SpanHelper.T.cs that uses Equal virtual call on value types that could be managed pointers to value types, but that code has remained the same for the last 4 years to 15 months and have not hit this issue in the past.
Fixes #74179.
Author:lateralusX
Assignees:-
Labels:
area-System.Globalization
Milestone:-
@lateralusXlateralusX
added
the 
runtime-mono
specific to the Mono runtime
label
Aug 25, 2022
adamsitnik
adamsitnik
approved these changes
Aug 25, 2022
View reviewed changes
@adamsitnikadamsitnik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much for investigating this complex issue @lateralusX !
@ghost
ghost
commented
Aug 25, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-memory

See info in area-owners.md if you want to be subscribed.
Issue Details
Workaround crash hit by #74179 making sure we avoid hitting codepath emitting this null pointer checks. The full fix includes codegen fixes as well, but will be performed in separate PR. There are still locations in SpanHelper.T.cs that uses Equal virtual call on value types that could be managed pointers to value types, but that code has remained the same for the last 4 years to 15 months and have not hit this issue in the past.
Fixes #74179.
Author:lateralusX
Assignees:lateralusX
Labels:
area-System.Memory, runtime-mono
Milestone:-
@lateralusX
lateralusX
commented
Aug 26, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Aug 26, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@lambdageek
lambdageek
commented
Aug 26, 2022

Copy link


Copy Markdown

Member
Equal virtual call on value types that could be managed pointers to value types
@lateralusX just to make sure I understand: Mono does emit correct code for these calls, right? except that we use a 32-bit read for the null check? So once we change the null check to stay in-bounds there are no other codegen issues?
the workaround here is actually some kind of micro-optimization to avoid boxing that also happens to avoid the null-check?
@lateralusX
lateralusX
commented
Aug 26, 2022•

edited by akoeplinger

Loading

Copy link


Copy Markdown

MemberAuthor
@lambdageek, since this specific code has a constraint on where TValue : struct, INumber<TValue> its possible to use == that in turn will use System.Numerics.IEqualityOperators`3<!!TValue,!!TValue,bool>::op_Equality for the compare, so it won't trigger a virtual call, meaning it won't hit our code path that injects an OP_CHECK_THIS that in turn would have done a read that could have read pass end of buffer into unallocated memory or a page with no read access.
This will mitigate the issue introduced by changes to SpanHelpers.T.cs, but could of course happen in other areas, so the full codegen fix is needed to fully mitigate the issue, but due to potential risk, it was split into two PR's, meaning we could just backport this to 7.0 and would be back to the state we had before recent optimizations to SpanHelpers.T.cs. or we could backport both and then this fix will mainly just be eliminating the virtual call that gets devirtualized and inlined, so mainly just eliminate the addition OP_CHECK_THIS.
So our virtual calls are fine, just that our lowering of OP_CHECK_THIS reads to much memory, that is fixed by #74638.
@lateralusX
lateralusX
commented
Aug 29, 2022

Copy link


Copy Markdown

MemberAuthor
Failures in runtime-extra-platforms unrelated.
@lateralusX
lateralusX
commented
Aug 29, 2022

Copy link


Copy Markdown

MemberAuthor
/backport to release/7.0
@github-actions
github-actionsBot
commented
Aug 29, 2022

Copy link


Copy Markdown

Contributor
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/2946871738
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 29, 2022
 Merged

@lateralusX
lateralusX
merged commit edb7d7e
into
dotnet:mainAug 29, 2022
@karelzkarelz
added this to the 8.0.0 milestone
Aug 29, 2022
@lateralusXlateralusX
mentioned this pull request
Aug 30, 2022
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 28, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@akoeplingerakoeplingerakoeplinger approved these changes
@adamsitnikadamsitnikadamsitnik approved these changes

Assignees

@lateralusXlateralusX

Labels

area-System.Memoryruntime-monospecific to the Mono runtime

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

CI failure: System.Globalization.Tests.InvariantModeTests.TestLastIndexOf, object reference not set to an instance of an object


6 participants

@lateralusX@lambdageek@akoeplinger@adamsitnik@karelz@tarekgh

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Use System.Numerics.IEqualityOperators.op_Equality in SpanHelper.T.cs where possible. by lateralusX · Pull Request #74567 · dotnet/runtime · GitHub
Skip to content
Use System.Numerics.IEqualityOperators.op_Equality in SpanHelper.T.cs where possible. - #74567
Merged
lateralusX merged 2 commits into
dotnet:mainfrom 
lateralusX:lateralusX/fix-74179-spanhelper
Aug 29, 2022
Merged
Use System.Numerics.IEqualityOperators.op_Equality in SpanHelper.T.cs where possible.#74567
lateralusX merged 2 commits into
dotnet:mainfrom 
lateralusX:lateralusX/fix-74179-spanhelper
Conversation
@lateralusX
@lateralusXlateralusX
commented
Aug 25, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Workaround crash hit by #74179 making sure we avoid hitting codepath emitting this null pointer checks. The full fix includes codegen fixes as well, but will be performed in separate PR. There are still locations in SpanHelper.T.cs that uses Equal virtual call on value types that could be managed pointers to value types, but that code has remained the same for the last 4 years to 15 months and have not hit this issue in the past.
Fixes#74179.
Full fix for underlying codegen issue, #74638.
@lateralusX
Use System.Numerics.IEqualityOperators.op_Equality in SpanHelper.T.cs.
bc8d9bd
Workaround crash hit by dotnet#74179
making sure we avoid hitting codepath emitting this null pointer checks.
The full fix includes codegen fixes as well, but will be performed
in separate PR. There are still locations in SpanHelper.T.cs that uses
Equal virtual call on value types that could be managed pointers to
value types, but that code has remained the same for the last
4 years to 15 months and have not hit this issue in the past.
@lateralusX
Re-enable globalization tests disabled indotnet#74433.
eec9819
@ghostghost
assigned lateralusXAug 25, 2022
@ghost
ghost
commented
Aug 25, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-globalization

See info in area-owners.md if you want to be subscribed.
Issue Details
Workaround crash hit by #74179 making sure we avoid hitting codepath emitting this null pointer checks. The full fix includes codegen fixes as well, but will be performed in separate PR. There are still locations in SpanHelper.T.cs that uses Equal virtual call on value types that could be managed pointers to value types, but that code has remained the same for the last 4 years to 15 months and have not hit this issue in the past.
Fixes #74179.
Author:lateralusX
Assignees:-
Labels:
area-System.Globalization
Milestone:-
@lateralusXlateralusX
added
the 
runtime-mono
specific to the Mono runtime
label
Aug 25, 2022
adamsitnik
adamsitnik
approved these changes
Aug 25, 2022
View reviewed changes
@adamsitnikadamsitnik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much for investigating this complex issue @lateralusX !
@ghost
ghost
commented
Aug 25, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-memory

See info in area-owners.md if you want to be subscribed.
Issue Details
Workaround crash hit by #74179 making sure we avoid hitting codepath emitting this null pointer checks. The full fix includes codegen fixes as well, but will be performed in separate PR. There are still locations in SpanHelper.T.cs that uses Equal virtual call on value types that could be managed pointers to value types, but that code has remained the same for the last 4 years to 15 months and have not hit this issue in the past.
Fixes #74179.
Author:lateralusX
Assignees:lateralusX
Labels:
area-System.Memory, runtime-mono
Milestone:-
@lateralusX
lateralusX
commented
Aug 26, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Aug 26, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@lambdageek
lambdageek
commented
Aug 26, 2022

Copy link


Copy Markdown

Member
Equal virtual call on value types that could be managed pointers to value types
@lateralusX just to make sure I understand: Mono does emit correct code for these calls, right? except that we use a 32-bit read for the null check? So once we change the null check to stay in-bounds there are no other codegen issues?
the workaround here is actually some kind of micro-optimization to avoid boxing that also happens to avoid the null-check?
@lateralusX
lateralusX
commented
Aug 26, 2022•

edited by akoeplinger

Loading

Copy link


Copy Markdown

MemberAuthor
@lambdageek, since this specific code has a constraint on where TValue : struct, INumber<TValue> its possible to use == that in turn will use System.Numerics.IEqualityOperators`3<!!TValue,!!TValue,bool>::op_Equality for the compare, so it won't trigger a virtual call, meaning it won't hit our code path that injects an OP_CHECK_THIS that in turn would have done a read that could have read pass end of buffer into unallocated memory or a page with no read access.
This will mitigate the issue introduced by changes to SpanHelpers.T.cs, but could of course happen in other areas, so the full codegen fix is needed to fully mitigate the issue, but due to potential risk, it was split into two PR's, meaning we could just backport this to 7.0 and would be back to the state we had before recent optimizations to SpanHelpers.T.cs. or we could backport both and then this fix will mainly just be eliminating the virtual call that gets devirtualized and inlined, so mainly just eliminate the addition OP_CHECK_THIS.
So our virtual calls are fine, just that our lowering of OP_CHECK_THIS reads to much memory, that is fixed by #74638.
@lateralusX
lateralusX
commented
Aug 29, 2022

Copy link


Copy Markdown

MemberAuthor
Failures in runtime-extra-platforms unrelated.
@lateralusX
lateralusX
commented
Aug 29, 2022

Copy link


Copy Markdown

MemberAuthor
/backport to release/7.0
@github-actions
github-actionsBot
commented
Aug 29, 2022

Copy link


Copy Markdown

Contributor
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/2946871738
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 29, 2022
 Merged

@lateralusX
lateralusX
merged commit edb7d7e
into
dotnet:mainAug 29, 2022
@karelzkarelz
added this to the 8.0.0 milestone
Aug 29, 2022
@lateralusXlateralusX
mentioned this pull request
Aug 30, 2022
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 28, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@akoeplingerakoeplingerakoeplinger approved these changes
@adamsitnikadamsitnikadamsitnik approved these changes

Assignees

@lateralusXlateralusX

Labels

area-System.Memoryruntime-monospecific to the Mono runtime

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

CI failure: System.Globalization.Tests.InvariantModeTests.TestLastIndexOf, object reference not set to an instance of an object


6 participants

@lateralusX@lambdageek@akoeplinger@adamsitnik@karelz@tarekgh

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Use System.Numerics.IEqualityOperators.op_Equality in SpanHelper.T.cs where possible. by lateralusX · Pull Request #74567 · dotnet/runtime · GitHub
Skip to content
Use System.Numerics.IEqualityOperators.op_Equality in SpanHelper.T.cs where possible. - #74567
Merged
lateralusX merged 2 commits into
dotnet:mainfrom 
lateralusX:lateralusX/fix-74179-spanhelper
Aug 29, 2022
Merged
Use System.Numerics.IEqualityOperators.op_Equality in SpanHelper.T.cs where possible.#74567
lateralusX merged 2 commits into
dotnet:mainfrom 
lateralusX:lateralusX/fix-74179-spanhelper
Conversation
@lateralusX
@lateralusXlateralusX
commented
Aug 25, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Workaround crash hit by #74179 making sure we avoid hitting codepath emitting this null pointer checks. The full fix includes codegen fixes as well, but will be performed in separate PR. There are still locations in SpanHelper.T.cs that uses Equal virtual call on value types that could be managed pointers to value types, but that code has remained the same for the last 4 years to 15 months and have not hit this issue in the past.
Fixes#74179.
Full fix for underlying codegen issue, #74638.
@lateralusX
Use System.Numerics.IEqualityOperators.op_Equality in SpanHelper.T.cs.
bc8d9bd
Workaround crash hit by dotnet#74179
making sure we avoid hitting codepath emitting this null pointer checks.
The full fix includes codegen fixes as well, but will be performed
in separate PR. There are still locations in SpanHelper.T.cs that uses
Equal virtual call on value types that could be managed pointers to
value types, but that code has remained the same for the last
4 years to 15 months and have not hit this issue in the past.
@lateralusX
Re-enable globalization tests disabled indotnet#74433.
eec9819
@ghostghost
assigned lateralusXAug 25, 2022
@ghost
ghost
commented
Aug 25, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-globalization

See info in area-owners.md if you want to be subscribed.
Issue Details
Workaround crash hit by #74179 making sure we avoid hitting codepath emitting this null pointer checks. The full fix includes codegen fixes as well, but will be performed in separate PR. There are still locations in SpanHelper.T.cs that uses Equal virtual call on value types that could be managed pointers to value types, but that code has remained the same for the last 4 years to 15 months and have not hit this issue in the past.
Fixes #74179.
Author:lateralusX
Assignees:-
Labels:
area-System.Globalization
Milestone:-
@lateralusXlateralusX
added
the 
runtime-mono
specific to the Mono runtime
label
Aug 25, 2022
adamsitnik
adamsitnik
approved these changes
Aug 25, 2022
View reviewed changes
@adamsitnikadamsitnik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much for investigating this complex issue @lateralusX !
@ghost
ghost
commented
Aug 25, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-memory

See info in area-owners.md if you want to be subscribed.
Issue Details
Workaround crash hit by #74179 making sure we avoid hitting codepath emitting this null pointer checks. The full fix includes codegen fixes as well, but will be performed in separate PR. There are still locations in SpanHelper.T.cs that uses Equal virtual call on value types that could be managed pointers to value types, but that code has remained the same for the last 4 years to 15 months and have not hit this issue in the past.
Fixes #74179.
Author:lateralusX
Assignees:lateralusX
Labels:
area-System.Memory, runtime-mono
Milestone:-
@lateralusX
lateralusX
commented
Aug 26, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Aug 26, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@lambdageek
lambdageek
commented
Aug 26, 2022

Copy link


Copy Markdown

Member
Equal virtual call on value types that could be managed pointers to value types
@lateralusX just to make sure I understand: Mono does emit correct code for these calls, right? except that we use a 32-bit read for the null check? So once we change the null check to stay in-bounds there are no other codegen issues?
the workaround here is actually some kind of micro-optimization to avoid boxing that also happens to avoid the null-check?
@lateralusX
lateralusX
commented
Aug 26, 2022•

edited by akoeplinger

Loading

Copy link


Copy Markdown

MemberAuthor
@lambdageek, since this specific code has a constraint on where TValue : struct, INumber<TValue> its possible to use == that in turn will use System.Numerics.IEqualityOperators`3<!!TValue,!!TValue,bool>::op_Equality for the compare, so it won't trigger a virtual call, meaning it won't hit our code path that injects an OP_CHECK_THIS that in turn would have done a read that could have read pass end of buffer into unallocated memory or a page with no read access.
This will mitigate the issue introduced by changes to SpanHelpers.T.cs, but could of course happen in other areas, so the full codegen fix is needed to fully mitigate the issue, but due to potential risk, it was split into two PR's, meaning we could just backport this to 7.0 and would be back to the state we had before recent optimizations to SpanHelpers.T.cs. or we could backport both and then this fix will mainly just be eliminating the virtual call that gets devirtualized and inlined, so mainly just eliminate the addition OP_CHECK_THIS.
So our virtual calls are fine, just that our lowering of OP_CHECK_THIS reads to much memory, that is fixed by #74638.
@lateralusX
lateralusX
commented
Aug 29, 2022

Copy link


Copy Markdown

MemberAuthor
Failures in runtime-extra-platforms unrelated.
@lateralusX
lateralusX
commented
Aug 29, 2022

Copy link


Copy Markdown

MemberAuthor
/backport to release/7.0
@github-actions
github-actionsBot
commented
Aug 29, 2022

Copy link


Copy Markdown

Contributor
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/2946871738
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 29, 2022
 Merged

@lateralusX
lateralusX
merged commit edb7d7e
into
dotnet:mainAug 29, 2022
@karelzkarelz
added this to the 8.0.0 milestone
Aug 29, 2022
@lateralusXlateralusX
mentioned this pull request
Aug 30, 2022
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 28, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@akoeplingerakoeplingerakoeplinger approved these changes
@adamsitnikadamsitnikadamsitnik approved these changes

Assignees

@lateralusXlateralusX

Labels

area-System.Memoryruntime-monospecific to the Mono runtime

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

CI failure: System.Globalization.Tests.InvariantModeTests.TestLastIndexOf, object reference not set to an instance of an object


6 participants

@lateralusX@lambdageek@akoeplinger@adamsitnik@karelz@tarekgh

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Use System.Numerics.IEqualityOperators.op_Equality in SpanHelper.T.cs where possible. by lateralusX · Pull Request #74567 · dotnet/runtime · GitHub
Skip to content
Use System.Numerics.IEqualityOperators.op_Equality in SpanHelper.T.cs where possible. - #74567
Merged
lateralusX merged 2 commits into
dotnet:mainfrom 
lateralusX:lateralusX/fix-74179-spanhelper
Aug 29, 2022
Merged
Use System.Numerics.IEqualityOperators.op_Equality in SpanHelper.T.cs where possible.#74567
lateralusX merged 2 commits into
dotnet:mainfrom 
lateralusX:lateralusX/fix-74179-spanhelper
Conversation
@lateralusX
@lateralusXlateralusX
commented
Aug 25, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Workaround crash hit by #74179 making sure we avoid hitting codepath emitting this null pointer checks. The full fix includes codegen fixes as well, but will be performed in separate PR. There are still locations in SpanHelper.T.cs that uses Equal virtual call on value types that could be managed pointers to value types, but that code has remained the same for the last 4 years to 15 months and have not hit this issue in the past.
Fixes#74179.
Full fix for underlying codegen issue, #74638.
@lateralusX
Use System.Numerics.IEqualityOperators.op_Equality in SpanHelper.T.cs.
bc8d9bd
Workaround crash hit by dotnet#74179
making sure we avoid hitting codepath emitting this null pointer checks.
The full fix includes codegen fixes as well, but will be performed
in separate PR. There are still locations in SpanHelper.T.cs that uses
Equal virtual call on value types that could be managed pointers to
value types, but that code has remained the same for the last
4 years to 15 months and have not hit this issue in the past.
@lateralusX
Re-enable globalization tests disabled indotnet#74433.
eec9819
@ghostghost
assigned lateralusXAug 25, 2022
@ghost
ghost
commented
Aug 25, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-globalization

See info in area-owners.md if you want to be subscribed.
Issue Details
Workaround crash hit by #74179 making sure we avoid hitting codepath emitting this null pointer checks. The full fix includes codegen fixes as well, but will be performed in separate PR. There are still locations in SpanHelper.T.cs that uses Equal virtual call on value types that could be managed pointers to value types, but that code has remained the same for the last 4 years to 15 months and have not hit this issue in the past.
Fixes #74179.
Author:lateralusX
Assignees:-
Labels:
area-System.Globalization
Milestone:-
@lateralusXlateralusX
added
the 
runtime-mono
specific to the Mono runtime
label
Aug 25, 2022
adamsitnik
adamsitnik
approved these changes
Aug 25, 2022
View reviewed changes
@adamsitnikadamsitnik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much for investigating this complex issue @lateralusX !
@ghost
ghost
commented
Aug 25, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-memory

See info in area-owners.md if you want to be subscribed.
Issue Details
Workaround crash hit by #74179 making sure we avoid hitting codepath emitting this null pointer checks. The full fix includes codegen fixes as well, but will be performed in separate PR. There are still locations in SpanHelper.T.cs that uses Equal virtual call on value types that could be managed pointers to value types, but that code has remained the same for the last 4 years to 15 months and have not hit this issue in the past.
Fixes #74179.
Author:lateralusX
Assignees:lateralusX
Labels:
area-System.Memory, runtime-mono
Milestone:-
@lateralusX
lateralusX
commented
Aug 26, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Aug 26, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@lambdageek
lambdageek
commented
Aug 26, 2022

Copy link


Copy Markdown

Member
Equal virtual call on value types that could be managed pointers to value types
@lateralusX just to make sure I understand: Mono does emit correct code for these calls, right? except that we use a 32-bit read for the null check? So once we change the null check to stay in-bounds there are no other codegen issues?
the workaround here is actually some kind of micro-optimization to avoid boxing that also happens to avoid the null-check?
@lateralusX
lateralusX
commented
Aug 26, 2022•

edited by akoeplinger

Loading

Copy link


Copy Markdown

MemberAuthor
@lambdageek, since this specific code has a constraint on where TValue : struct, INumber<TValue> its possible to use == that in turn will use System.Numerics.IEqualityOperators`3<!!TValue,!!TValue,bool>::op_Equality for the compare, so it won't trigger a virtual call, meaning it won't hit our code path that injects an OP_CHECK_THIS that in turn would have done a read that could have read pass end of buffer into unallocated memory or a page with no read access.
This will mitigate the issue introduced by changes to SpanHelpers.T.cs, but could of course happen in other areas, so the full codegen fix is needed to fully mitigate the issue, but due to potential risk, it was split into two PR's, meaning we could just backport this to 7.0 and would be back to the state we had before recent optimizations to SpanHelpers.T.cs. or we could backport both and then this fix will mainly just be eliminating the virtual call that gets devirtualized and inlined, so mainly just eliminate the addition OP_CHECK_THIS.
So our virtual calls are fine, just that our lowering of OP_CHECK_THIS reads to much memory, that is fixed by #74638.
@lateralusX
lateralusX
commented
Aug 29, 2022

Copy link


Copy Markdown

MemberAuthor
Failures in runtime-extra-platforms unrelated.
@lateralusX
lateralusX
commented
Aug 29, 2022

Copy link


Copy Markdown

MemberAuthor
/backport to release/7.0
@github-actions
github-actionsBot
commented
Aug 29, 2022

Copy link


Copy Markdown

Contributor
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/2946871738
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 29, 2022
 Merged

@lateralusX
lateralusX
merged commit edb7d7e
into
dotnet:mainAug 29, 2022
@karelzkarelz
added this to the 8.0.0 milestone
Aug 29, 2022
@lateralusXlateralusX
mentioned this pull request
Aug 30, 2022
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 28, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@akoeplingerakoeplingerakoeplinger approved these changes
@adamsitnikadamsitnikadamsitnik approved these changes

Assignees

@lateralusXlateralusX

Labels

area-System.Memoryruntime-monospecific to the Mono runtime

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

CI failure: System.Globalization.Tests.InvariantModeTests.TestLastIndexOf, object reference not set to an instance of an object


6 participants

@lateralusX@lambdageek@akoeplinger@adamsitnik@karelz@tarekgh