Uh oh!
There was an error while loading. Please reload this page.
[Android] Skip VectorSingle and VectorDoubleEqualsNonCanonicalNaNTest on x64 - #74782
Closed
steveisok wants to merge 1 commit into
Closed
[Android] Skip VectorSingle and VectorDoubleEqualsNonCanonicalNaNTest on x64#74782steveisok wants to merge 1 commit into
steveisok wants to merge 1 commit into
Conversation
… on x64 These tests are failing on Android x64 and need to be skipped for now.
ghost
commented
Aug 29, 2022
Tagging subscribers to this area: @dotnet/area-system-numerics Issue DetailsThese tests are failing on Android x64 and need to be skipped for now.
|
mdh1418
reviewed
Aug 29, 2022
| public static bool IsNetBSD => RuntimeInformation.IsOSPlatform(OSPlatform.Create("NETBSD")); | ||
| public static bool IsAndroid => RuntimeInformation.IsOSPlatform(OSPlatform.Create("ANDROID")); | ||
| public static bool IsNotAndroid => !IsAndroid; | ||
| public static bool IsAndroidX64 => IsAndroid && Is64BitProcess; |
Member
There was a problem hiding this comment.
Should this be IsX64Process? If its just Android X64? Is64BitProcess would apply to both X64 and Arm64 right
Member
There was a problem hiding this comment.
Plus it would be more akin to the IsAndroidX86 right below
MemberAuthor
There was a problem hiding this comment.
I think you're right. Good catch!
akoeplinger
commented
Aug 30, 2022
Member
This is actually a more widespread issue than just Android x64, disabled the tests on all Mono configurations in #74788 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests are failing on Android x64 and need to be skipped to avoid blocking clean ci.
#74781