Skip to content

remove explicit LangVersion from a few projects - #75806

Merged
ViktorHofer merged 4 commits into
dotnet:mainfrom
kasperk81:LangVersion
Sep 29, 2022
Merged

remove explicit LangVersion from a few projects#75806
ViktorHofer merged 4 commits into
dotnet:mainfrom
kasperk81:LangVersion

Conversation

@kasperk81

@kasperk81kasperk81 commented Sep 18, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@ghostghost added the community-contribution Indicates that the PR has been added by a community member label Sep 18, 2022
@ghost

ghost commented Sep 18, 2022

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost

ghost commented Sep 18, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:kasperk81
Assignees:-
Labels:

area-Infrastructure-libraries, community-contribution

Milestone:-

@kasperk81kasperk81 reopened this Sep 19, 2022
@ViktorHofer

ViktorHofer commented Sep 19, 2022•
edited
Loading

Copy link
Copy Markdown
Member

This one can be removed as well:

runtime/src/libraries/System.Diagnostics.DiagnosticSource/src/System.Diagnostics.DiagnosticSource.csproj

Line 10 in 16cb35f

<LangVersionCondition="'$(TargetFramework)' == 'net6.0'">10</LangVersion>

@ViktorHofer

ViktorHofer commented Sep 19, 2022

Copy link
Copy Markdown
Member

As explained here it can be removed now.

@kasperk81

kasperk81 commented Sep 20, 2022

Copy link
Copy Markdown
ContributorAuthor

all checks passed

ViktorHofer
ViktorHofer reviewed Sep 20, 2022
View reviewed changes
Comment threadsrc/libraries/Common/tests/StaticTestGenerator/StaticTestGenerator.csproj Outdated
ViktorHofer
ViktorHofer reviewed Sep 20, 2022
View reviewed changes
Comment threadsrc/libraries/System.Text.RegularExpressions/tools/GenerateRegexCasingTable.csproj Outdated
@kasperk81kasperk81 reopened this Sep 20, 2022
@runfoapprunfoappBot mentioned this pull request Sep 20, 2022
Closed
@kasperk81kasperk81 reopened this Sep 21, 2022
@ViktorHofer

ViktorHofer commented Sep 21, 2022

Copy link
Copy Markdown
Member

Thanks a lot. Great work!

@kasperk81

kasperk81 commented Sep 29, 2022

Copy link
Copy Markdown
ContributorAuthor

@ViktorHofer looks good to merge?

@ViktorHofer
ViktorHofer merged commit 08d0bd9 into dotnet:mainSep 29, 2022
@ViktorHofer

ViktorHofer commented Sep 29, 2022

Copy link
Copy Markdown
Member

Thanks a lot

@kasperk81kasperk81 mentioned this pull request Oct 15, 2022
Merged
@ghostghost locked as resolved and limited conversation to collaborators Oct 29, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ViktorHoferViktorHoferViktorHofer approved these changes

Assignees

No one assigned

Labels

area-Infrastructure-librariescommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kasperk81@ViktorHofer@marek-safar