Skip to content

[wasm][debugger] Fix debugging an app that has another .NET Wasm instance in a service worker - #76072

Merged
thaystg merged 1 commit into
dotnet:mainfrom
thaystg:thays_fix_76026
Oct 11, 2022
Merged

[wasm][debugger] Fix debugging an app that has another .NET Wasm instance in a service worker#76072
thaystg merged 1 commit into
dotnet:mainfrom
thaystg:thays_fix_76026

Conversation

@thaystg

Copy link
Copy Markdown
Member

Fixes#76026

@thaystg
thaystg requested a review from lewingSeptember 23, 2022 14:29
@ghostghost assigned thaystgSep 23, 2022
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #76026

Author:thaystg
Assignees:-
Labels:

area-Debugger-mono

Milestone:-

@thaystg

Copy link
Copy Markdown
MemberAuthor

/backport to release/7.0

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3113494949

@lewinglewing left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@thaystg

Copy link
Copy Markdown
MemberAuthor

/backport to release/6.0

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/3113529843

@github-actions

Copy link
Copy Markdown
Contributor

@thaystg backporting to release/6.0 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Fix debug a app that has another .NET Wasm instance in a service worker
Using index info to reconstruct a base tree...
M	src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs
Falling back to patching base and 3-way merge...
Auto-merging src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs
CONFLICT (content): Merge conflict in src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix debug a app that has another .NET Wasm instance in a service worker
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@thaystg
thaystg merged commit 2b07c8c into dotnet:mainOct 11, 2022
@ghostghost locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Blazor Wasm Crashes if another wasm instance is running in the service worker.

3 participants

@thaystg@radical@lewing