Uh oh!
There was an error while loading. Please reload this page.
[release/7.0] [wasm][debugger] Fix debugging an app that has another .NET Wasm instance in a service worker - #76073
Merged
Conversation
ghost
commented
Sep 23, 2022
Tagging subscribers to this area: @thaystg Issue DetailsBackport of #76072 to release/7.0 /cc @thaystg Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
lewing
approved these changes
Sep 23, 2022
lewing
commented
Sep 23, 2022
Member
coreclr failure is unrelated |
carlossanlop
commented
Sep 26, 2022
Contributor
@thaystg don't forget to send the email to Tactics requesting approval, if you haven't done so. |
carlossanlop
commented
Sep 26, 2022
Contributor
This was approved by Tactics via email. CI failure is unrelated and pre-existing: #74328 Signed off. Ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #76072 to release/7.0
/cc @thaystg
Customer Impact
Customer reported issue. It was crashing the debugger when an app has another .NET Wasm instance in a service worker
Testing
Manually tested
Risk
Low Risk, only ignoring a session id that is not known.
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.