Uh oh!
There was an error while loading. Please reload this page.
[release/7.0] Replace GetFile() with GetPEAssembly() call in gdb - #76321
Merged
Conversation
jeffschwMSFT
approved these changes
Sep 28, 2022
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
approved. we can merge when ready
carlossanlop
commented
Sep 28, 2022
Contributor
@jeffschwMSFT I can't find the Tactics approval email. Or was it approved in the meeting? |
jeffschwMSFT
commented
Sep 28, 2022
Member
we are treating this as 'tell mode' as it is not production code |
carlossanlop
commented
Sep 28, 2022
Contributor
Got it. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #76293 to release/7.0
/cc @jkotas@tonybaloney
Customer Impact
Build break in source build configuration used by Tizen.
Testing
N/A. The affected code is not compiled into the official .NET distro.
Risk
Low
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.