Skip to content

Correct error messages for CoreCLR Win32 PAL uses in CoreLib - #76768

Merged
jkotas merged 1 commit into
dotnet:mainfrom
jkotas:pal-error-messages
Oct 10, 2022
Merged

Correct error messages for CoreCLR Win32 PAL uses in CoreLib#76768
jkotas merged 1 commit into
dotnet:mainfrom
jkotas:pal-error-messages

Conversation

@jkotas

@jkotasjkotas commented Oct 7, 2022

Copy link
Copy Markdown
Member

Contributes to #76736

@ghost

ghost commented Oct 7, 2022

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghostghost assigned jkotasOct 7, 2022
@ghost

ghost commented Oct 7, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #76736

Author:jkotas
Assignees:jkotas
Labels:

area-System.Runtime.InteropServices

Milestone:-

@jkotasjkotas mentioned this pull request Oct 7, 2022
Closed
janvorli
janvorli approved these changes Oct 7, 2022
View reviewed changes

@janvorlijanvorli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@danmoseley

danmoseley commented Oct 7, 2022

Copy link
Copy Markdown
Contributor

I guess we should backport?

@AaronRobinsonMSFT

AaronRobinsonMSFT commented Oct 8, 2022

Copy link
Copy Markdown
Member

I guess we should backport?

I think so, but perhaps we could wait to our first servicing window rather than GA?

@danmoseley

danmoseley commented Oct 8, 2022

Copy link
Copy Markdown
Contributor

I'd say it's worth asking - there's been nothing deferred to 7.0.1 yet.

This was referenced Oct 8, 2022
Closed
Closed
@jkotas

jkotas commented Oct 8, 2022

Copy link
Copy Markdown
MemberAuthor

we could wait to our first servicing window rather than GA?

It is for the servicing shiproom to decide. The basic rule is to take fixes sooner because of adoption (and thus blast radius of a potentially bad change) increases with time.

@jkotasjkotas closed this Oct 8, 2022
@jkotasjkotas reopened this Oct 8, 2022
@jkotasjkotas closed this Oct 9, 2022
@jkotasjkotas reopened this Oct 9, 2022
@jkotasjkotas closed this Oct 10, 2022
@jkotasjkotas reopened this Oct 10, 2022
@jkotas

jkotas commented Oct 10, 2022

Copy link
Copy Markdown
MemberAuthor

/backport to release/7.0

@github-actions

github-actionsBot commented Oct 10, 2022

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3219642530

@github-actionsgithub-actionsBot mentioned this pull request Oct 10, 2022
Merged
@jkotasjkotas mentioned this pull request Oct 10, 2022
Closed
@jkotas
jkotas merged commit 6893524 into dotnet:mainOct 10, 2022
@jkotas
jkotas deleted the pal-error-messages branch October 10, 2022 18:52
@build-analysisbuild-analysisBot mentioned this pull request Oct 10, 2022
Closed
@ghostghost locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkoritzinskyjkoritzinskyjkoritzinsky approved these changes
@stephentoubstephentoubstephentoub approved these changes
@janvorlijanvorlijanvorli approved these changes
@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes
@elinor-fungelinor-fungelinor-fung approved these changes

Assignees

@jkotasjkotas

Labels

area-System.Runtime.InteropServices

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jkotas@danmoseley@AaronRobinsonMSFT@jkoritzinsky@stephentoub@janvorli@elinor-fung