Skip to content

[release/7.0] Correct error messages for CoreCLR Win32 PAL uses in CoreLib - #76813

Merged
carlossanlop merged 1 commit into
release/7.0from
backport/pr-76768-to-release/7.0
Oct 10, 2022
Merged

[release/7.0] Correct error messages for CoreCLR Win32 PAL uses in CoreLib#76813
carlossanlop merged 1 commit into
release/7.0from
backport/pr-76768-to-release/7.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Oct 10, 2022

Copy link
Copy Markdown
Contributor

Backport of #76768 to release/7.0

/cc @jkotas

Customer Impact

Exception thrown by synchronization classes on Unix have incorrect error messages. This makes diagnosing problems close to impossible.

Contributes to #76736

Testing

Verified that the correct message is produce by simulated error condition

Risk

Low

@ghost

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@jeffschwMSFTjeffschwMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. please get a code review and we can take for consideration in 7 ga.

@jeffschwMSFTjeffschwMSFT added area-ExceptionHandling-coreclr only use for closed issues Servicing-consider Issue for next servicing release review labels Oct 10, 2022
@jeffschwMSFTjeffschwMSFT added this to the 7.0.0 milestone Oct 10, 2022
@carlossanlopcarlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 10, 2022
@carlossanlop

Copy link
Copy Markdown
Contributor

Approved by Tactics via email.

@carlossanlop

Copy link
Copy Markdown
Contributor

CI failure is a timeout cancellation during test execution of Libraries Test Run release mono Linux arm64 Debug. Otherwise, it's green.
Approved and signed-off. Ready to merge. :shipit:

@carlossanlop
carlossanlop merged commit 9c14efc into release/7.0Oct 10, 2022
@carlossanlop
carlossanlop deleted the backport/pr-76768-to-release/7.0 branch October 10, 2022 18:38
@ghostghost locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-ExceptionHandling-coreclronly use for closed issuesServicing-approvedApproved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@carlossanlop@jeffschwMSFT@AaronRobinsonMSFT@jkotas