Skip to content

[release/7.0] Reintroduce typo in ICorDebug public API names - #76967

Merged
carlossanlop merged 2 commits into
release/7.0from
backport/pr-76966-to-release/7.0
Oct 13, 2022
Merged

[release/7.0] Reintroduce typo in ICorDebug public API names#76967
carlossanlop merged 2 commits into
release/7.0from
backport/pr-76966-to-release/7.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Oct 12, 2022•
edited by jkotas
Loading

Copy link
Copy Markdown
Contributor

Backport of #76966 to release/7.0

/cc @jkotas

Customer Impact

Build break after updating to .NET 7 ICorDebug header files. The build break was introduced by attempt to fix a typo in publicly documented API name. The typo fix is being reverted by this change.

Testing

Standard CI testing, verified that the API name matches the documented name.

Risk

Low

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@ghost

ghost commented Oct 12, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #76966 to release/7.0

/cc @jkotas

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author:github-actions[bot]
Assignees:-
Labels:

area-Diagnostics-coreclr

Milestone:-

@carlossanlop

carlossanlop commented Oct 12, 2022

Copy link
Copy Markdown
Contributor

@mmitche do we still have runway to include this in GA?

@carlossanlopcarlossanlop added the Servicing-approved Approved for servicing release label Oct 12, 2022
@carlossanlop

carlossanlop commented Oct 12, 2022

Copy link
Copy Markdown
Contributor

Approved by Tactics via email.

@carlossanlopcarlossanlop added this to the 7.0.x milestone Oct 12, 2022
jeffschwMSFT
jeffschwMSFT approved these changes Oct 12, 2022
View reviewed changes

@jeffschwMSFTjeffschwMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@mmitche

mmitche commented Oct 12, 2022

Copy link
Copy Markdown
Member

Yes

@carlossanlopcarlossanlop modified the milestones: 7.0.x, 7.0.0Oct 12, 2022
@carlossanlop

carlossanlop commented Oct 12, 2022

Copy link
Copy Markdown
Contributor

Cool, thanks. Will merge after checking the CI.

@carlossanlop

carlossanlop commented Oct 13, 2022

Copy link
Copy Markdown
Contributor

Re-running the failed CI leg. There were network issues.

@carlossanlopcarlossanlop mentioned this pull request Oct 13, 2022
Closed
@carlossanlop

carlossanlop commented Oct 13, 2022

Copy link
Copy Markdown
Contributor

The CI re-run had one failure, but unrelated and I've seen it before: #76906

Approved by Tactics and signed off by lots of folks. Merging now. :shipit:

@carlossanlop
carlossanlop merged commit c7b59fc into release/7.0Oct 13, 2022
@carlossanlop
carlossanlop deleted the backport/pr-76966-to-release/7.0 branch October 13, 2022 18:02
@ghostghost locked as resolved and limited conversation to collaborators Nov 12, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoubstephentoubstephentoub approved these changes
@noahfalknoahfalknoahfalk approved these changes
@jeffschwMSFTjeffschwMSFTjeffschwMSFT approved these changes
@hoyosjshoyosjshoyosjs approved these changes
@tommcdontommcdonAwaiting requested review from tommcdon
@thaystgthaystgAwaiting requested review from thaystgthaystg is a code owner
@lambdageeklambdageekAwaiting requested review from lambdageeklambdageek is a code owner

Assignees

No one assigned

Labels

area-Diagnostics-coreclrServicing-approvedApproved for servicing release

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@carlossanlop@mmitche@stephentoub@noahfalk@jeffschwMSFT@hoyosjs@jkotas