Skip to content

Reintroduce typo in ICorDebug public API names - #76966

Merged
jkotas merged 1 commit into
dotnet:mainfrom
jkotas:reintroduce-typo
Oct 13, 2022
Merged

Reintroduce typo in ICorDebug public API names#76966
jkotas merged 1 commit into
dotnet:mainfrom
jkotas:reintroduce-typo

Conversation

@jkotas

@jkotasjkotas commented Oct 12, 2022

Copy link
Copy Markdown
Member

Fixes#76960

@ghostghost assigned jkotasOct 12, 2022
@ghost

ghost commented Oct 12, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #76960

Author:jkotas
Assignees:-
Labels:

area-Diagnostics-coreclr

Milestone:-

@jkotas

jkotas commented Oct 12, 2022

Copy link
Copy Markdown
MemberAuthor

/backport to release/7.0

@jkotas
jkotas requested a review from tommcdonOctober 12, 2022 20:31
@github-actions

github-actionsBot commented Oct 12, 2022

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3237700119

@jkotas
jkotas requested a review from noahfalkOctober 12, 2022 20:31
@jkotas

jkotas commented Oct 12, 2022

Copy link
Copy Markdown
MemberAuthor

cc @am11

@github-actionsgithub-actionsBot mentioned this pull request Oct 12, 2022
Merged
am11
am11 approved these changes Oct 12, 2022
View reviewed changes

@am11am11 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, didn’t realized that it is public. Thanks! :)

@teo-tsirpanis

teo-tsirpanis commented Oct 12, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Why reintroduce the typo? It is only a source, not a binary breaking change, and has been done before in #60999 (though I can see the argument that maybe this typo has existed for longer).

Answered in #76960 (comment).

@build-analysisbuild-analysisBot mentioned this pull request Oct 13, 2022
Closed
2 tasks
@jkotas
jkotas merged commit e216458 into dotnet:mainOct 13, 2022
@jkotas
jkotas deleted the reintroduce-typo branch October 13, 2022 06:03
@vargaz

vargaz commented Oct 13, 2022

Copy link
Copy Markdown
Contributor

This seems to have broken the mono build, CI didn't run the mono lanes on this PR:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=50983&view=logs&j=d3cc09f4-7598-5083-c32b-3d75aa946de0&t=69808874-331d-5f38-5702-6a7cd5ef963b&l=2334

@akoeplinger

akoeplinger commented Oct 13, 2022•
edited
Loading

Copy link
Copy Markdown
Member

This is another case where the missing mscordbi trigger path is causing mono build breaks (see #76832 (comment)), we need to add these paths to the trigger.

@janvorlijanvorli mentioned this pull request Oct 13, 2022
Merged
@ghostghost locked as resolved and limited conversation to collaborators Nov 12, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoubstephentoubstephentoub approved these changes
@tommcdontommcdontommcdon approved these changes
@hoyosjshoyosjshoyosjs approved these changes
@noahfalknoahfalkAwaiting requested review from noahfalk
+1 more reviewer
@am11am11am11 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jkotasjkotas

Labels

area-Diagnostics-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CoreCLR 7.0 have changed public Debug API. Why?

8 participants

@jkotas@teo-tsirpanis@vargaz@akoeplinger@stephentoub@am11@tommcdon@hoyosjs