Skip to content

Revert "Revert "Reduce CoreCLR PAL"" - #76972

Merged
janvorli merged 2 commits into
mainfrom
revert-76860-revert-76832-reduce-pal-1
Oct 13, 2022
Merged

Revert "Revert "Reduce CoreCLR PAL""#76972
janvorli merged 2 commits into
mainfrom
revert-76860-revert-76832-reduce-pal-1

Conversation

@janvorli

Copy link
Copy Markdown
Member

Reverts #76860

@janvorlijanvorli added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Oct 12, 2022
@janvorlijanvorli self-assigned this Oct 12, 2022
@ghostghost added the area-PAL-coreclr only for closed issues label Oct 12, 2022
@janvorli

Copy link
Copy Markdown
MemberAuthor

@am11 this would not work. The PAL maintains its own copy of the environment, so the CreateProcessW would not see the changes added by the OS putenv.

@janvorlijanvorli removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Oct 13, 2022
@janvorlijanvorli added this to the 8.0.0 milestone Oct 13, 2022
@janvorli
janvorli requested a review from jkotasOctober 13, 2022 00:23
@janvorli

Copy link
Copy Markdown
MemberAuthor

@jkotas the _putenv turned out to be the only issue, so I've put it back. Can you please take a look at this revert of revert?
Please note I've left a dummy change in one of the files in the eng so that this PR verifies the mono build. I'll remove it before merging the change.

@jkotasjkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@janvorli
janvorliforce-pushed the revert-76860-revert-76832-reduce-pal-1 branch from ff18024 to 647cc64CompareOctober 13, 2022 08:07
@janvorli
janvorli merged commit e6f3aa9 into mainOct 13, 2022
@janvorli
janvorli deleted the revert-76860-revert-76832-reduce-pal-1 branch October 13, 2022 11:37
@am11

am11 commented Oct 13, 2022

Copy link
Copy Markdown
Member

@janvorli, Mono's llvmaot leg is failing with:

 [ 88%] Building CXX object dlls/mscordbi/utilcode/CMakeFiles/utilcode_obj.dir/configuration.cpp.o
/__w/1/s/src/mono/dlls/mscordbi/cordb-value.cpp:351:44: error: allocating an object of abstract class type 'CordbArrayValue'
CordbArrayValue* objectValue = new CordbArrayValue(conn, m_pCordbType, m_debuggerId, m_pClass);
^
/__w/1/s/src/coreclr/pal/prebuilt/inc/cordebug.h:15647:43: note: unimplemented pure virtual method 'HasBaseIndicies' in 'CordbArrayValue'
virtual HRESULT STDMETHODCALLTYPE HasBaseIndicies(
^
/__w/1/s/src/coreclr/pal/prebuilt/inc/cordebug.h:15650:43: note: unimplemented pure virtual method 'GetBaseIndicies' in 'CordbArrayValue'
virtual HRESULT STDMETHODCALLTYPE GetBaseIndicies(
^
1 error generated.

https://dev.azure.com/dnceng-public/public/_build/results?buildId=51175&view=logs&jobId=cc858e6b-b6f5-5c08-4b62-8cd383bd096a&j=cc858e6b-b6f5-5c08-4b62-8cd383bd096a&t=74861b75-1f67-5a94-490e-d5eb4723f5a5

Looks like dummy change was needed in src/tests as well.

@janvorli

Copy link
Copy Markdown
MemberAuthor

@am11 this doesn't seem to be related to my changes. I have not removed anything that could result in this error. And yesterday I've built using the same command line that the failing build is using locally and it passed.

@janvorli

Copy link
Copy Markdown
MemberAuthor

@jkotas seems like it was caused by your #76966.

@am11

am11 commented Oct 13, 2022

Copy link
Copy Markdown
Member

You are right, it is caused by #76966.

@jkotas

Copy link
Copy Markdown
Member

Ugh. #77002

@ghostghost locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-PAL-coreclronly for closed issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@janvorli@am11@jkotas