Skip to content

Fix handling generic custom attributes - #78297

Merged
jkotas merged 1 commit into
dotnet:mainfrom
MichalStrehovsky:genericattr
Nov 14, 2022
Merged

Fix handling generic custom attributes#78297
jkotas merged 1 commit into
dotnet:mainfrom
MichalStrehovsky:genericattr

Conversation

@MichalStrehovsky

@MichalStrehovskyMichalStrehovsky commented Nov 14, 2022

Copy link
Copy Markdown
Member

Fixes#78200.

Cc @dotnet/ilc-contrib

@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #78200.

Author:MichalStrehovsky
Assignees:-
Labels:

area-NativeAOT-coreclr

Milestone:-

@jkotas

Copy link
Copy Markdown
Member

Failure is fixed by #78296

@jkotas
jkotas merged commit 1ad1022 into dotnet:mainNov 14, 2022
@MichalStrehovsky
MichalStrehovsky deleted the genericattr branch November 14, 2022 03:37
@MichalStrehovsky

Copy link
Copy Markdown
MemberAuthor

/backport to release/7.0

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3458321722

@agocke

Copy link
Copy Markdown
Member

Are we expecting the linked PR to unblock the unit test? Should we port that change back to 7.0 as well?

@MichalStrehovsky

Copy link
Copy Markdown
MemberAuthor

Are we expecting the linked PR to unblock the unit test? Should we port that change back to 7.0 as well?

TL;DR: the linked pull request could have contributed a useful test for this, but doesn't anymore.

@ghostghost locked as resolved and limited conversation to collaborators Dec 15, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generic custom attributes don't work

3 participants

@MichalStrehovsky@jkotas@agocke