Uh oh!
There was an error while loading. Please reload this page.
Revert "Allocate boxed static structs on Frozen Object Heap and remov… - #78296
Merged
Conversation
…e getFieldAddress (dotnet#77737)" This reverts commit cabb8b0.
ghost
commented
Nov 14, 2022
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue Details…e getFieldAddress (#77737)" Looks like NRE is still there in System.Text.RegularExpression.Tests so I need to revert and catch it 😞 Guid is updated.
|
jkotas
approved these changes
Nov 14, 2022
This was referenced Nov 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e getFieldAddress (#77737)"
Looks like NRE is still there in System.Text.RegularExpression.Tests so I need to revert and catch it 😞 I did a lot of runs after my change in morph.cpp and was not able to reproduce it but apparently it's still there.
Guid is updated.