Uh oh!
There was an error while loading. Please reload this page.
[wasm] Use "node:crypto" to polyfill getRandomValues on older node - #78696
Conversation
ghost
commented
Nov 22, 2022
Tagging subscribers to 'arch-wasm': @lewing Issue Details
Fixes #77927
|
maraf
commented
Nov 22, 2022
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lewing
commented
Nov 22, 2022
removing the insecure polyfill in the test runner breaks v8 |
maraf
commented
Nov 23, 2022
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
maraf
commented
Nov 23, 2022
/backport to release/7.0 |
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3532333494 |
radical
commented
Dec 2, 2022
@maraf you tested this on node v14, v17, and v19. Our tests should be running with v14 (from emsdk). Do we need to make sure that this doesn't break for 17/19/others? IOW, do we need to run a few tests with these different versions of node? |
maraf
commented
Dec 5, 2022
I think this is a first such thing. @pavelsavara do you have an opinion? |
pavelsavara
commented
Dec 5, 2022
I would stick to v14 for bulk of the testing for Net8. Or should we make the |
Yeah, having |
radical
commented
Dec 5, 2022
@maraf Could you please open an issue to track this? |
"node:crypto"whenglobalThis.cryptois undefined or doesn't havegetRandomValues.getRandomValuesfromwebcryptowhen availablegetRandomValuesusingrandomByteson even older nodeFixes#77927