Skip to content

[release/7.0] [wasm] Use "node:crypto" to polyfill getRandomValues on older node - #78766

Merged
carlossanlop merged 2 commits into
release/7.0from
backport/pr-78696-to-release/7.0
Jan 4, 2023
Merged

[release/7.0] [wasm] Use "node:crypto" to polyfill getRandomValues on older node#78766
carlossanlop merged 2 commits into
release/7.0from
backport/pr-78696-to-release/7.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Nov 23, 2022

Copy link
Copy Markdown
Contributor

Backport of #78696 to release/7.0

/cc @maraf

Customer Impact

Customers running node older than v19 are able to generate random bytes needed for example to generate guids.
Without polyfill it fails with exception.

Testing

Unit tests pass on node v14, v17, v19

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@ghost

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #78696 to release/7.0

/cc @maraf

Customer Impact

Customers running node older than v19 are able to generate random bytes needed for example to generate guids.

Testing

Unit tests pass on node v14, v17, v19

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author:github-actions[bot]
Assignees:-
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript

Milestone:-

@marafmaraf added the Servicing-consider Issue for next servicing release review label Nov 23, 2022
@radical

Copy link
Copy Markdown
Member

/azp run runtime-wasm-libtests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@radical

Copy link
Copy Markdown
Member

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@carlossanlop

Copy link
Copy Markdown
Contributor

@maraf can you please address the questions in the Tactics email you sent to unblock the approval?

@carlossanlopcarlossanlop modified the milestones: 7.0.x, 7.0.3Nov 29, 2022
@carlossanlopcarlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Nov 29, 2022
@carlossanlop

Copy link
Copy Markdown
Contributor

Approved via email by Tactics for 7.0.3 (February).

@carlossanlop

carlossanlop commented Jan 4, 2023

Copy link
Copy Markdown
Contributor

Approved by Tactics.
Signed off by area owner.
Milestone applied.
MacCatalyst failure is unrelated (I see it in other PRs). The wasm failures seem like networking issues.
No OOB package changes needed.
Ready to merge. :shipit:

@carlossanlop
carlossanlop merged commit a31811b into release/7.0Jan 4, 2023
@carlossanlop
carlossanlop deleted the backport/pr-78696-to-release/7.0 branch January 4, 2023 20:16
@ghostghost locked as resolved and limited conversation to collaborators Feb 4, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScriptServicing-approvedApproved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@radical@carlossanlop@pavelsavara@maraf