Uh oh!
There was an error while loading. Please reload this page.
[release/7.0] [mono][wasm] Disable AOTing methods which contain catch clauses insid… - #78732
Merged
Merged
Conversation
…e finally/filter clauses. When the ENDFINALLY opcode of the outer clause is encountered while executing the inner catch clause from run_with_il_state (), it will assert since it doesn't know where to continue execution.
github-actionsBot
requested review from
SamMonoRT, lambdageek and vargaz
as code ownersNovember 22, 2022 21:41
vargaz
commented
Nov 22, 2022
Contributor
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vargaz
approved these changes
Nov 23, 2022
vargaz
commented
Nov 23, 2022
Contributor
Failures are unrelated. |
carlossanlop
commented
Nov 23, 2022
Contributor
@vargaz if this is ready, please send the email to Tactics requesting approval. For the January release, we will only have a window of one day to merge backports (Nov. 29-30), so I'm asking all backport submitters to get their PRs ready for me to just hit merge on that day. |
vargaz
commented
Nov 23, 2022
Contributor
Sent |
vargaz
commented
Nov 24, 2022
Contributor
Approved by tactics. |
BrzVlad
approved these changes
Nov 29, 2022
carlossanlop
commented
Nov 29, 2022
Contributor
Branding has been done. Milestone is 7.0.2. Signed-off by area owners. Approved by Tactics. No OOB package authoring changes needed. CI failure is unrelated (#78778). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #78653 to release/7.0
/cc @vargaz
Customer Impact
Fixes#78358 which is a regression
on wasm in AOT mode caused by #77059.
The regression was not detected because not all wasm tests are ran on the backport PRs.
Testing
CI with /azp run runtime-wasm
Risk
Low, only affects wasm in AOT mode, fixes a regression.