Skip to content

[wasm] Add warning code to all warnings produced in WasmAppBuilder - #78755

Merged
radical merged 3 commits into
dotnet:mainfrom
maraf:WasmNativeWarning
Dec 2, 2022
Merged

[wasm] Add warning code to all warnings produced in WasmAppBuilder#78755
radical merged 3 commits into
dotnet:mainfrom
maraf:WasmNativeWarning

Conversation

@maraf

Copy link
Copy Markdown
Member
  • WASM0001 - All PInvoke related warnings
  • WASM0002 - Missing CultureName metadata for satellite assembly
  • WASM0003 - Found identical vfs mappings for target path
  • WASM0004 - Loading assembly reference '..' for '..' failed

Fixes#78690

@marafmaraf added arch-wasm WebAssembly architecture area-Build-mono labels Nov 23, 2022
@marafmaraf added this to the 8.0.0 milestone Nov 23, 2022
@marafmaraf self-assigned this Nov 23, 2022
@maraf
maraf requested a review from radical as a code ownerNovember 23, 2022 09:32
@ghost

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • WASM0001 - All PInvoke related warnings
  • WASM0002 - Missing CultureName metadata for satellite assembly
  • WASM0003 - Found identical vfs mappings for target path
  • WASM0004 - Loading assembly reference '..' for '..' failed

Fixes #78690

Author:maraf
Assignees:maraf
Labels:

arch-wasm, area-Build-mono

Milestone:8.0.0

@maraf

maraf commented Nov 23, 2022

Copy link
Copy Markdown
MemberAuthor

@radical Should I add warning code even for this one?

Log.LogWarning(reason);

@marafmaraf changed the title [wasm] Add warning code to all warning produced in WasmAppBuilder[wasm] Add warning code to all warnings produced in WasmAppBuilderNov 23, 2022
@radical

Copy link
Copy Markdown
Member

@radical Should I add warning code even for this one?

Log.LogWarning(reason);

Good question. Remove the LogWarning. The caller will log the reason as a MessageImportance.Low message.
And change the message to the dependency file {inFile} needed for compiling {srcFile} to {outFile} could not be found., so it works better with the full message that is logged by the caller.

@radical

Copy link
Copy Markdown
Member

@akoeplinger@steveisok do we need to document these new warning codes anywhere?

@akoeplinger

Copy link
Copy Markdown
Member

do we need to document these new warning codes anywhere?

Yes but I think we also need to localize them if they're actually user-facing. I don't know if there's guidance/restrictions around coming up with new codes though.

@radical

Copy link
Copy Markdown
Member

I have opened #79173 for following up on the localization, and documentation.

@radical

Copy link
Copy Markdown
Member

The MacCatalyst failure is unrelated, and was - #78778 .

@radical
radical merged commit bcc818f into dotnet:mainDec 2, 2022
@maraf
maraf deleted the WasmNativeWarning branch December 5, 2022 08:33
@maraf

maraf commented Dec 5, 2022

Copy link
Copy Markdown
MemberAuthor

/backport to release/7.0

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3622382639

@ghostghost locked as resolved and limited conversation to collaborators Jan 4, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WebAssembly.Sdk - Unsuppressable warnings

3 participants

@maraf@radical@akoeplinger