Skip to content

[release/7.0] [wasm] Add warning code to all warnings produced in WasmAppBuilder - #79234

Merged
carlossanlop merged 3 commits into
release/7.0from
backport/pr-78755-to-release/7.0
Jan 5, 2023
Merged

[release/7.0] [wasm] Add warning code to all warnings produced in WasmAppBuilder#79234
carlossanlop merged 3 commits into
release/7.0from
backport/pr-78755-to-release/7.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Dec 5, 2022

Copy link
Copy Markdown
Contributor

Backport of #78755 to release/7.0

/cc @maraf

Customer Impact

Customers can disable individual warnings that can occur while building wasm applications.
Fixes customer reported issue #78690.

Testing

Manual.

Risk

Low. Only warning codes where added to existing warnings.

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@ghostghost added the area-Build-mono label Dec 5, 2022
@marafmaraf added this to the 7.0.x milestone Dec 5, 2022
@marafmaraf added the arch-wasm WebAssembly architecture label Dec 5, 2022
@ghost

ghost commented Dec 5, 2022

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #78755 to release/7.0

/cc @maraf

Customer Impact

Customers are able to disable indivial warnings that can occur while building wasm applications.
Fixes customer reported issue #78690.

Testing

Manual.

Risk

Low. The only change without additional configuration is that warning messages are prefixed with warning code.

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author:github-actions[bot]
Assignees:-
Labels:

arch-wasm, area-Build-mono

Milestone:7.0.x

@marafmaraf self-assigned this Dec 5, 2022
@marek-safarmarek-safar added the Servicing-consider Issue for next servicing release review label Dec 6, 2022
@rbhandarbhanda modified the milestones: 7.0.x, 7.0.3Dec 6, 2022
@rbhandarbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Dec 6, 2022
Comment threadsrc/tasks/WasmAppBuilder/IcallTableGenerator.cs
@carlossanlop

Copy link
Copy Markdown
Contributor

Approved by Tactics.
Signed off by area owner.
No OOB changes needed.
CI failure is known, unrelated, and has already been fixed in the branch: #78778
Waiting for the last question to be answered before merging.

@carlossanlop

Copy link
Copy Markdown
Contributor

Although there's still an additional question to answer in the conversation, it was marked as resolved, so I'll merge.

CI failure is known/unrelated/already fixed: #78778

@carlossanlop
carlossanlop merged commit ff4cab3 into release/7.0Jan 5, 2023
@carlossanlop
carlossanlop deleted the backport/pr-78755-to-release/7.0 branch January 5, 2023 18:44
@ghostghost locked as resolved and limited conversation to collaborators Feb 4, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasmWebAssembly architecturearea-Build-monoServicing-approvedApproved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@carlossanlop@radical@maraf@ilonatommy@marek-safar@rbhanda