Uh oh!
There was an error while loading. Please reload this page.
[Android] Remove repeated calls to beginHandshake - #78849
Conversation
Cleanup Revert some changes
ghost
commented
Nov 25, 2022
Tagging subscribers to this area: @dotnet/ncl, @vcsjones Issue DetailsOn legacy Android APIs (26 and earlier) the There's a related problem: during the handshake process, the SSLSession isn't accessible and it's necessary to call the Closes #78716
|
simonrozsival
commented
Nov 25, 2022
/azp run runtime-android |
|
Azure Pipelines successfully started running 1 pipeline(s). |
simonrozsival
commented
Nov 25, 2022
/azp run runtime-androidemulator |
|
Azure Pipelines successfully started running 1 pipeline(s). |
simonrozsival
commented
Nov 29, 2022
CI failures are unrelated to this PR. |
steveisok
commented
Nov 30, 2022
/backport to release/7.0 |
steveisok
commented
Nov 30, 2022
/backport to release/6.0 |
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3584440281 |
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/3584441419 |
Cleanup Revert some changes
Cleanup Revert some changes
On legacy Android APIs (26 and earlier) the
SSLEngine.beginHandshake()Java method cannot be called when the handshake has already been started. This has been fixed in later Android revisions (which we use in CI).There's a related problem: during the handshake process, the SSLSession isn't accessible and it's necessary to call the
SSLEngine.getHandshakeSession()to get the reference to the session that's being constructed (see https://developer.android.com/reference/javax/net/ssl/SSLSocket#getHandshakeSession() for more info). That prompted several other changes in thepal_sslstream.c.This PR fixes
SslStreamon Android APIs 24-26.Closes#78716
Related to #77386