Skip to content

[Android] Fix SslStream on Android API 21-23 - #78918

Merged
simonrozsival merged 1 commit into
dotnet:mainfrom
simonrozsival:fix-android-ssl-legacy-apis
Dec 6, 2022
Merged

[Android] Fix SslStream on Android API 21-23#78918
simonrozsival merged 1 commit into
dotnet:mainfrom
simonrozsival:fix-android-ssl-legacy-apis

Conversation

@simonrozsival

@simonrozsivalsimonrozsival commented Nov 28, 2022•
edited
Loading

Copy link
Copy Markdown
Member

The SSLEngine in Android APIs 21-23 doesn't give us a way to enable SNI directly but it's possible to achieve by calling a method that isn't in the standard Java API. This workaround isn't very clean but it gets the job done. We can drop it as soon as we drop support for these API levels.

Closes#78715

@ghost

ghost commented Nov 28, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

This is still WIP

Closes #78715
Depends on #78849

Author:simonrozsival
Assignees:-
Labels:

area-System.Net.Security

Milestone:-

@ghost

ghost commented Nov 28, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

This is still WIP

Closes #78715
Depends on #78849

Author:simonrozsival
Assignees:simonrozsival
Labels:

area-System.Net.Security, os-android

Milestone:-

@simonrozsival

simonrozsival commented Nov 28, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-android

@azure-pipelines

azure-pipelinesBot commented Nov 28, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Nov 28, 2022
Closed
Closed
am11
am11 reviewed Nov 28, 2022
View reviewed changes
Comment threadsrc/native/libs/System.Security.Cryptography.Native.Android/pal_sslstream.c Outdated
am11
am11 reviewed Nov 28, 2022
View reviewed changes
Comment threadsrc/native/libs/System.Security.Cryptography.Native.Android/pal_sslstream.c Outdated
@build-analysisbuild-analysisBot mentioned this pull request Nov 29, 2022
Closed
5 tasks
@simonrozsival
simonrozsivalforce-pushed the fix-android-ssl-legacy-apis branch 3 times, most recently from 8a82616 to 2b81a23CompareNovember 30, 2022 08:51
@simonrozsival
Fix ssl on APIs 21-23
ec54d10
Code improvements
@simonrozsival
simonrozsivalforce-pushed the fix-android-ssl-legacy-apis branch from 2b81a23 to ec54d10CompareNovember 30, 2022 09:03
@simonrozsival
simonrozsival marked this pull request as ready for review November 30, 2022 09:06
@simonrozsival

simonrozsival commented Nov 30, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-android

@azure-pipelines

azure-pipelinesBot commented Nov 30, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@simonrozsival

simonrozsival commented Dec 6, 2022

Copy link
Copy Markdown
MemberAuthor

The failing tests are unrelated to this PR.

@simonrozsival
simonrozsival merged commit 2b1d11d into dotnet:mainDec 6, 2022
@simonrozsival
simonrozsival deleted the fix-android-ssl-legacy-apis branch December 6, 2022 14:32
simonrozsival added a commit to simonrozsival/runtime that referenced this pull request Dec 6, 2022
@simonrozsival
[Android] Fix SslStream on APIs 21-23 (dotnet#78918)
e9bcca1
@simonrozsivalsimonrozsival mentioned this pull request Dec 6, 2022
Merged
simonrozsival added a commit to simonrozsival/runtime that referenced this pull request Dec 6, 2022
@simonrozsival
[Android] Fix SslStream on APIs 21-23 (dotnet#78918)
9727b4b
@simonrozsivalsimonrozsival mentioned this pull request Dec 6, 2022
Merged
carlossanlop pushed a commit that referenced this pull request Jan 4, 2023
@simonrozsival
[release/7.0][Android] Fix SslStream on legacy Android API levels (#7…
d5f6805
…9280)
* [Android] Fix SslStream on APIs 21-23 (#78918)
* [Android] Remove repeated calls to beginHandshake (#78849)
Cleanup
Revert some changes
@ghostghost locked as resolved and limited conversation to collaborators Jan 5, 2023
@karelzkarelz added this to the 8.0.0 milestone Mar 22, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@steveisoksteveisoksteveisok approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplinger
+2 more reviewers
@am11am11am11 left review comments
@grendellogrendellogrendello approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@simonrozsivalsimonrozsival

Labels

area-System.Net.Securityos-android

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

[Android] Investigate support for SSLStream below API Level 24

5 participants

@simonrozsival@grendello@steveisok@am11@karelz