Skip to content

Remove getFieldAddress - #79060

Merged
EgorBo merged 5 commits into
dotnet:mainfrom
EgorBo:drop-getfieldaddress
Dec 3, 2022
Merged

Remove getFieldAddress#79060
EgorBo merged 5 commits into
dotnet:mainfrom
EgorBo:drop-getfieldaddress

Conversation

@EgorBo

@EgorBoEgorBo commented Nov 30, 2022

Copy link
Copy Markdown
Member

Reverts part of the #78296 to drop getFieldAddress API

@ghostghost assigned EgorBoNov 30, 2022
@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 30, 2022
@ghost

ghost commented Nov 30, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Reverts part of the #78296 to drop getFieldAddress API

Author:EgorBo
Assignees:EgorBo
Labels:

area-CodeGen-coreclr

Milestone:-

@EgorBo

EgorBo commented Dec 1, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr outerloop, runtime-coreclr jitstress, runtime-coreclr jitstressregs

@azure-pipelines

azure-pipelinesBot commented Dec 1, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@EgorBo
EgorBoforce-pushed the drop-getfieldaddress branch from 33b4f2d to 892cc86CompareDecember 1, 2022 11:33
@EgorBo

EgorBo commented Dec 1, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr outerloop, runtime-coreclr jitstress, runtime-coreclr jitstressregs

@azure-pipelines

azure-pipelinesBot commented Dec 1, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@EgorBo
EgorBo marked this pull request as ready for review December 1, 2022 13:56
@build-analysisbuild-analysisBot mentioned this pull request Dec 1, 2022
Closed
@EgorBo

EgorBo commented Dec 1, 2022•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@jkotas can you please review the VM side? I've extracted only the part where we delete getFieldAddress API that doesn't throw any NRE (I had 4 runs of CI here without it + local runs). I'll investigate the NRE + Frozen statics separately. This PR should also unblock NativeAOT work for static fields.

Current CI failures are known, I'll list related issues here

jkotas
jkotas approved these changes Dec 1, 2022
View reviewed changes

@jkotasjkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EgorBo

EgorBo commented Dec 2, 2022

Copy link
Copy Markdown
MemberAuthor

@jakobbotsch@SingleAccretion can any of you sign off the jit side? it didn't change since #77737

SingleAccretion
SingleAccretion approved these changes Dec 2, 2022
View reviewed changes

@SingleAccretionSingleAccretion left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jit changes still look good.

@EgorBo

EgorBo commented Dec 2, 2022•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Failures are:
Runtime_76194 - #78758
Runtime_31615 - filed #79170
jitstress is pretty broken - #79132 (comment)

Going to have another round of CI just in case.

@EgorBo
EgorBo merged commit 720ae03 into dotnet:mainDec 3, 2022
@EgorBo
EgorBo deleted the drop-getfieldaddress branch December 3, 2022 11:06
This was referenced Dec 6, 2022
Open
Open
This was referenced Dec 6, 2022
Closed
Closed
@ghostghost locked as resolved and limited conversation to collaborators Jan 2, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotasjkotasjkotas approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner
+1 more reviewer
@SingleAccretionSingleAccretionSingleAccretion approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@EgorBoEgorBo

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@EgorBo@jkotas@SingleAccretion