Skip to content

[mono][debugger] Fix Debugger.Break() behavior when running on release mode - #79822

Merged
thaystg merged 1 commit into
dotnet:mainfrom
thaystg:thays_fix_1675269
Dec 20, 2022
Merged

[mono][debugger] Fix Debugger.Break() behavior when running on release mode#79822
thaystg merged 1 commit into
dotnet:mainfrom
thaystg:thays_fix_1675269

Conversation

@thaystg

Copy link
Copy Markdown
Member

If native_debugger_break is disabled do not call G_BREAKPOINT otherwise the app will be interrupted by a signal when running in release mode a code that has a Debugger.Break()

Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1675269

@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

If native_debugger_break is disabled do not call G_BREAKPOINT otherwise the app will be interrupted by a signal when running in release mode a code that has a Debugger.Break()

Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1675269

Author:thaystg
Assignees:-
Labels:

area-Debugger-mono

Milestone:-

@thaystgthaystg changed the title [mono][debugger]Fixing generating a signal when running on release mode[mono][debugger] Fix Debugger.Break() behavior when running on release modeDec 19, 2022
@thaystg

Copy link
Copy Markdown
MemberAuthor

@steveisok should we backport this one?

@thaystg
thaystg merged commit 90c7986 into dotnet:mainDec 20, 2022
@thaystg

Copy link
Copy Markdown
MemberAuthor

@lewing should we backport this one?

@steveisok

Copy link
Copy Markdown
Member

Yes, I think so as long as @lewing is ok w/ it.

@thaystg

Copy link
Copy Markdown
MemberAuthor

/backport to release/7.0

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3893630409

@lambdageek

Copy link
Copy Markdown
Member

@thaystg Should we backport this to 6.0, too?

stub_debugger_user_break (void)
{
G_BREAKPOINT ();
}

@thaystg

Copy link
Copy Markdown
MemberAuthor

@thaystg Should we backport this to 6.0, too?

stub_debugger_user_break (void)
{
G_BREAKPOINT ();
}

I think so. I will open it. :)

@ghostghost locked as resolved and limited conversation to collaborators Feb 12, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@thaystg@steveisok@lambdageek@lewing