Uh oh!
There was an error while loading. Please reload this page.
[release/7.0] [mono][debugger] Fix Debugger.Break() behavior when running on release mode - #80497
Merged
Merged
Conversation
ghost
commented
Jan 11, 2023
Tagging subscribers to this area: @thaystg Issue DetailsBackport of #79822 to release/7.0 /cc @thaystg Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
carlossanlop
commented
Jan 11, 2023
Contributor
@thaystg if this is ready, please send the email to Tactics requesting approval. |
lewing
approved these changes
Jan 12, 2023
carlossanlop
commented
Jan 12, 2023
Contributor
Approved by Tactics (7.0.3). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #79822 to release/7.0
/cc @thaystg
Customer Impact
When the customer application has a Debugger.Break it was crashing the app when running on release mode.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1675269
Testing
Manually tested.
Risk
Low risk, only calling raise(SIGTRAP) when native debugging option is enabled.
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.