Skip to content

[mono][aot] Fixed decompose_flag propagation issues - #79849

Merged
jandupej merged 1 commit into
dotnet:mainfrom
jandupej:issue79710
Dec 20, 2022
Merged

[mono][aot] Fixed decompose_flag propagation issues#79849
jandupej merged 1 commit into
dotnet:mainfrom
jandupej:issue79710

Conversation

@jandupej

@jandupejjandupej commented Dec 20, 2022

Copy link
Copy Markdown
Contributor

Addresses #79710.

@ghost

ghost commented Dec 20, 2022

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghostghost assigned jandupejDec 20, 2022
@jandupej

jandupej commented Dec 20, 2022

Copy link
Copy Markdown
ContributorAuthor

Some build failures due to #79843.

@jandupej
jandupej merged commit 9fe3afe into dotnet:mainDec 20, 2022
@build-analysisbuild-analysisBot mentioned this pull request Dec 20, 2022
Closed
@jandupej

jandupej commented Dec 20, 2022

Copy link
Copy Markdown
ContributorAuthor

/backport to release/7.0

@github-actions

github-actionsBot commented Dec 20, 2022

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3741930000

@github-actions

github-actionsBot commented Dec 20, 2022

Copy link
Copy Markdown
Contributor

@jandupej an error occurred while backporting to release/7.0, please check the run log for details!

Error: @jandupej is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your dotnet team membership visibility is set to Public on https://github.com/orgs/dotnet/people?query=jandupej

@github-actions

github-actionsBot commented Dec 20, 2022

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3741930000

@github-actionsgithub-actionsBot mentioned this pull request Dec 20, 2022
Merged
@build-analysisbuild-analysisBot mentioned this pull request Dec 21, 2022
Closed
@lewing

lewing commented Jan 6, 2023

Copy link
Copy Markdown
Member

should this go back to 6.0 too?

@jandupej

jandupej commented Jan 6, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@lewing#79710 mentions the issue does occur with 6.0.
EDIT: Sorry, the problem is reported only on 7.0. They say 6.0 is fine.

@jandupejjandupej mentioned this pull request Jan 10, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Feb 8, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lambdageeklambdageekAwaiting requested review from lambdageek
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
1 more reviewer
@vargazvargazvargaz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jandupejjandupej

Labels

area-Codegen-AOT-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jandupej@lewing@vargaz