Skip to content

[release/7.0] [mono][aot] Fixed decompose_flag propagation issues - #79855

Merged
carlossanlop merged 1 commit into
release/7.0from
backport/pr-79849-to-release/7.0
Jan 6, 2023
Merged

[release/7.0] [mono][aot] Fixed decompose_flag propagation issues#79855
carlossanlop merged 1 commit into
release/7.0from
backport/pr-79849-to-release/7.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Dec 20, 2022•
edited by jandupej
Loading

Copy link
Copy Markdown
Contributor

Backport of #79849 to release/7.0

It has been reported in 79710 that Mono AOT can fail when compiling an assembly that contains a generic class with a method that returns Type and has a conditional structure.

/cc @jandupej

Customer Impact

This PR fixes the issue and allows successful builds of such assemblies.

Testing

We do not have a CI pipeline for this case. The issue can be replicated by building Mono for Android x64 and trying to compile the example specified in the issue 79710. AOT compilation will fail as described in the issue. AOT compilation will succeed when the fix is applied.

Risk

Low. This PR does not add features, only fixes a basic block flag propagation issue that causes the bug. Very little code is touched.

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@ghostghost added the area-VM-meta-mono label Dec 20, 2022
@lambdageeklambdageek added the Servicing-consider Issue for next servicing release review label Dec 20, 2022
@lambdageeklambdageek added this to the 7.0.x milestone Dec 20, 2022
@lambdageek

lambdageek commented Dec 20, 2022

Copy link
Copy Markdown
Member

@jandupej please fill in the template and email tactics

@build-analysisbuild-analysisBot mentioned this pull request Dec 20, 2022
Closed
@SamMonoRT

SamMonoRT commented Dec 20, 2022

Copy link
Copy Markdown
Member

@jandupej please fill in the template and email tactics

He's validating manually and will update the text, email later. Might not happen till after the holidays, so removing the tags for now

@SamMonoRTSamMonoRT removed the Servicing-consider Issue for next servicing release review label Dec 20, 2022
@SamMonoRTSamMonoRT removed this from the 7.0.x milestone Dec 20, 2022
@carlossanlop

carlossanlop commented Jan 4, 2023

Copy link
Copy Markdown
Contributor

@SamMonoRT@jandupej friendly reminder to fill out the template / add servicing-consider label / send email to Tactics.

@jandupejjandupej added the Servicing-consider Issue for next servicing release review label Jan 5, 2023
@jandupej

jandupej commented Jan 5, 2023

Copy link
Copy Markdown
Contributor

Build failures are unrelated to this PR.

@SamMonoRTSamMonoRT added this to the 7.0.x milestone Jan 5, 2023
@SamMonoRT

SamMonoRT commented Jan 6, 2023

Copy link
Copy Markdown
Member

Approved via email. Marking as servicing-approved cc @carlossanlop

@SamMonoRTSamMonoRT added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jan 6, 2023
@carlossanlopcarlossanlop modified the milestones: 7.0.x, 7.0.3Jan 6, 2023
@carlossanlop

carlossanlop commented Jan 6, 2023

Copy link
Copy Markdown
Contributor

Thanks for the ping, @SamMonoRT

Approved by Tactics (7.0.3).
Signed off by area owners.
No OOB changes required for this change (native code).
CI failures are unrelated: #75018 and #79097, plus some cancellations.
Ready to merge. :shipit:

@carlossanlop
carlossanlop merged commit e516d18 into release/7.0Jan 6, 2023
@carlossanlop
carlossanlop deleted the backport/pr-79849-to-release/7.0 branch January 6, 2023 17:27
@jandupejjandupej mentioned this pull request Jan 10, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Feb 5, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lambdageeklambdageekAwaiting requested review from lambdageeklambdageek is a code owner
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRTSamMonoRT is a code owner
1 more reviewer
@vargazvargazvargaz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-VM-meta-monoServicing-approvedApproved for servicing release

Projects

None yet

Milestone

7.0.3

Development

Successfully merging this pull request may close these issues.

5 participants

@lambdageek@SamMonoRT@carlossanlop@jandupej@vargaz