Skip to content

[release/6.0] Respect SETTINGS_MAX_HEADER_LIST_SIZE on HTTP/2 - #79997

Merged
carlossanlop merged 1 commit into
dotnet:release/6.0from
MihaZupan:http2-header-list-size-limit-net6
Jan 5, 2023
Merged

[release/6.0] Respect SETTINGS_MAX_HEADER_LIST_SIZE on HTTP/2#79997
carlossanlop merged 1 commit into
dotnet:release/6.0from
MihaZupan:http2-header-list-size-limit-net6

Conversation

@MihaZupan

@MihaZupanMihaZupan commented Dec 27, 2022•
edited by karelz
Loading

Copy link
Copy Markdown
Member

Backport of #79281 to release/6.0 (only the HTTP/2 part as HTTP/3 is not supported on .NET 6)

Fixes#78193

/cc @MihaZupan

Customer Impact

Without this change, users of HttpClient may randomly hit exceptions informing them that the server closed the connection. This is difficult to debug as nothing points you at the request headers being the culprit, and impacts reliability as unrelated requests may fail at the same time due to connection multiplexing.

With HTTP/2 the server has the option to advertise the maximum length of headers it is willing to receive.
This change respects that limit and fails offending requests before they make it onto the wire, improving the overall reliability of HttpClient while also providing a useful exception message to the user.

Testing

Added targeted CI tests.
The new behavior was validated with a test app running against Kestrel.

Risk

Low, this change enforces a limit that is specified by the server.
Any request that will fail with the new error was very likely already failing before.

@MihaZupanMihaZupan added this to the 6.0.x milestone Dec 27, 2022
@MihaZupan
MihaZupan requested a review from a teamDecember 27, 2022 15:49
@MihaZupanMihaZupan self-assigned this Dec 27, 2022
@ghost

ghost commented Dec 27, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #79281 to release/6.0 (only the HTTP/2 part as HTTP/3 is not supported on .NET 6)
Contributes to #78193

/cc @MihaZupan

Customer Impact

TODO

Testing

TODO

Risk

TODO

Author:MihaZupan
Assignees:MihaZupan
Labels:

area-System.Net.Http

Milestone:6.0.x

wfurt
wfurt approved these changes Dec 27, 2022
View reviewed changes

@wfurtwfurt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Dec 27, 2022
Closed
Closed
@marek-safarmarek-safar added the Servicing-consider Issue for next servicing release review label Jan 2, 2023
@MihaZupanMihaZupan added the tenet-reliability Reliability/stability related issue (stress, load problems, etc.) label Jan 3, 2023
@TratcherTratcher mentioned this pull request Jan 3, 2023
Closed
@MihaZupan

MihaZupan commented Jan 4, 2023

Copy link
Copy Markdown
MemberAuthor

CI failures are #79858 and #79859

@karelz

karelz commented Jan 5, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Approved by @SteveMCarroll via email on Thu 2023/1/5 2:32 AM - adding Servicing-approved label.

  • email: "[Servicing-Consider] [6.0.X and 7.0.X] Respect SETTINGS_MAX_HEADER_LIST_SIZE in HttpClient"

@karelzkarelz added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jan 5, 2023
@carlossanlop

carlossanlop commented Jan 5, 2023

Copy link
Copy Markdown
Contributor

Approved by Tactics (6.0.14).
Signed off by area owners.
No OOB changes needed - The involved src csproj does not have IsPackable=true set.
CI failures investigated as unrelated.
Ready to merge. :shipit:

@carlossanlop
carlossanlop merged commit cb73f5d into dotnet:release/6.0Jan 5, 2023
@carlossanlopcarlossanlop modified the milestones: 6.0.x, 6.0.14Jan 5, 2023
@karelzkarelz mentioned this pull request Jan 6, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Feb 5, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wfurtwfurtwfurt approved these changes

Assignees

@MihaZupanMihaZupan

Labels

area-System.Net.HttpServicing-approvedApproved for servicing releasetenet-reliabilityReliability/stability related issue (stress, load problems, etc.)

Projects

None yet

Milestone

6.0.14

Development

Successfully merging this pull request may close these issues.

5 participants

@MihaZupan@karelz@carlossanlop@wfurt@marek-safar
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[release/6.0] Respect SETTINGS_MAX_HEADER_LIST_SIZE on HTTP/2 by MihaZupan · Pull Request #79997 · dotnet/runtime · GitHub
Skip to content
[release/6.0] Respect SETTINGS_MAX_HEADER_LIST_SIZE on HTTP/2 - #79997
Merged
carlossanlop merged 1 commit into
dotnet:release/6.0from 
MihaZupan:http2-header-list-size-limit-net6
Jan 5, 2023
Merged
[release/6.0] Respect SETTINGS_MAX_HEADER_LIST_SIZE on HTTP/2#79997
carlossanlop merged 1 commit into
dotnet:release/6.0from 
MihaZupan:http2-header-list-size-limit-net6
Conversation
@MihaZupan
@MihaZupanMihaZupan
commented
Dec 27, 2022•

edited by karelz

Loading

Copy link


Copy Markdown

Member
Backport of #79281 to release/6.0 (only the HTTP/2 part as HTTP/3 is not supported on .NET 6)
Fixes#78193
/cc @MihaZupan
Customer Impact
Without this change, users of HttpClient may randomly hit exceptions informing them that the server closed the connection. This is difficult to debug as nothing points you at the request headers being the culprit, and impacts reliability as unrelated requests may fail at the same time due to connection multiplexing.
With HTTP/2 the server has the option to advertise the maximum length of headers it is willing to receive.

This change respects that limit and fails offending requests before they make it onto the wire, improving the overall reliability of HttpClient while also providing a useful exception message to the user.
Testing
Added targeted CI tests.

The new behavior was validated with a test app running against Kestrel.
Risk
Low, this change enforces a limit that is specified by the server.

Any request that will fail with the new error was very likely already failing before.
@MihaZupanMihaZupan
added this to the 6.0.x milestone
Dec 27, 2022
@MihaZupan
MihaZupan
requested a review
from a teamDecember 27, 2022 15:49
@MihaZupanMihaZupan
self-assigned this
Dec 27, 2022
@ghost
ghost
commented
Dec 27, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #79281 to release/6.0 (only the HTTP/2 part as HTTP/3 is not supported on .NET 6)

Contributes to #78193
/cc @MihaZupan
Customer Impact
TODO
Testing
TODO
Risk
TODO
Author:MihaZupan
Assignees:MihaZupan
Labels:
area-System.Net.Http
Milestone:6.0.x
wfurt
wfurt
approved these changes
Dec 27, 2022
View reviewed changes
@wfurtwfurt
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Dec 27, 2022

Closed


Closed

@marek-safarmarek-safar
added
the 
Servicing-consider
Issue for next servicing release review
label
Jan 2, 2023
@MihaZupanMihaZupan
added
the 
tenet-reliability
Reliability/stability related issue (stress, load problems, etc.)
label
Jan 3, 2023
@TratcherTratcher
mentioned this pull request
Jan 3, 2023

Closed

@MihaZupan
MihaZupan
commented
Jan 4, 2023

Copy link


Copy Markdown

MemberAuthor
CI failures are #79858 and #79859
@karelz
karelz
commented
Jan 5, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Approved by @SteveMCarroll via email on Thu 2023/1/5 2:32 AM - adding Servicing-approved label.
  • email: "[Servicing-Consider] [6.0.X and 7.0.X] Respect SETTINGS_MAX_HEADER_LIST_SIZE in HttpClient"
@karelzkarelz
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Jan 5, 2023
@carlossanlop
carlossanlop
commented
Jan 5, 2023

Copy link


Copy Markdown

Contributor
Approved by Tactics (6.0.14).

Signed off by area owners.

No OOB changes needed - The involved src csproj does not have IsPackable=true set.

CI failures investigated as unrelated.

Ready to merge. :shipit:
@carlossanlop
carlossanlop
merged commit cb73f5d
into
dotnet:release/6.0Jan 5, 2023
@carlossanlopcarlossanlop
modified the milestones:
6.0.x, 6.0.14Jan 5, 2023
@karelzkarelz
mentioned this pull request
Jan 6, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Feb 5, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@wfurtwfurtwfurt approved these changes

Assignees

@MihaZupanMihaZupan

Labels

area-System.Net.HttpServicing-approvedApproved for servicing releasetenet-reliabilityReliability/stability related issue (stress, load problems, etc.)

Projects


None yet


Milestone

6.0.14

Development

Successfully merging this pull request may close these issues.

5 participants

@MihaZupan@karelz@carlossanlop@wfurt@marek-safar

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/6.0] Respect SETTINGS_MAX_HEADER_LIST_SIZE on HTTP/2 by MihaZupan · Pull Request #79997 · dotnet/runtime · GitHub
Skip to content
[release/6.0] Respect SETTINGS_MAX_HEADER_LIST_SIZE on HTTP/2 - #79997
Merged
carlossanlop merged 1 commit into
dotnet:release/6.0from 
MihaZupan:http2-header-list-size-limit-net6
Jan 5, 2023
Merged
[release/6.0] Respect SETTINGS_MAX_HEADER_LIST_SIZE on HTTP/2#79997
carlossanlop merged 1 commit into
dotnet:release/6.0from 
MihaZupan:http2-header-list-size-limit-net6
Conversation
@MihaZupan
@MihaZupanMihaZupan
commented
Dec 27, 2022•

edited by karelz

Loading

Copy link


Copy Markdown

Member
Backport of #79281 to release/6.0 (only the HTTP/2 part as HTTP/3 is not supported on .NET 6)
Fixes#78193
/cc @MihaZupan
Customer Impact
Without this change, users of HttpClient may randomly hit exceptions informing them that the server closed the connection. This is difficult to debug as nothing points you at the request headers being the culprit, and impacts reliability as unrelated requests may fail at the same time due to connection multiplexing.
With HTTP/2 the server has the option to advertise the maximum length of headers it is willing to receive.

This change respects that limit and fails offending requests before they make it onto the wire, improving the overall reliability of HttpClient while also providing a useful exception message to the user.
Testing
Added targeted CI tests.

The new behavior was validated with a test app running against Kestrel.
Risk
Low, this change enforces a limit that is specified by the server.

Any request that will fail with the new error was very likely already failing before.
@MihaZupanMihaZupan
added this to the 6.0.x milestone
Dec 27, 2022
@MihaZupan
MihaZupan
requested a review
from a teamDecember 27, 2022 15:49
@MihaZupanMihaZupan
self-assigned this
Dec 27, 2022
@ghost
ghost
commented
Dec 27, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #79281 to release/6.0 (only the HTTP/2 part as HTTP/3 is not supported on .NET 6)

Contributes to #78193
/cc @MihaZupan
Customer Impact
TODO
Testing
TODO
Risk
TODO
Author:MihaZupan
Assignees:MihaZupan
Labels:
area-System.Net.Http
Milestone:6.0.x
wfurt
wfurt
approved these changes
Dec 27, 2022
View reviewed changes
@wfurtwfurt
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Dec 27, 2022

Closed


Closed

@marek-safarmarek-safar
added
the 
Servicing-consider
Issue for next servicing release review
label
Jan 2, 2023
@MihaZupanMihaZupan
added
the 
tenet-reliability
Reliability/stability related issue (stress, load problems, etc.)
label
Jan 3, 2023
@TratcherTratcher
mentioned this pull request
Jan 3, 2023

Closed

@MihaZupan
MihaZupan
commented
Jan 4, 2023

Copy link


Copy Markdown

MemberAuthor
CI failures are #79858 and #79859
@karelz
karelz
commented
Jan 5, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Approved by @SteveMCarroll via email on Thu 2023/1/5 2:32 AM - adding Servicing-approved label.
  • email: "[Servicing-Consider] [6.0.X and 7.0.X] Respect SETTINGS_MAX_HEADER_LIST_SIZE in HttpClient"
@karelzkarelz
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Jan 5, 2023
@carlossanlop
carlossanlop
commented
Jan 5, 2023

Copy link


Copy Markdown

Contributor
Approved by Tactics (6.0.14).

Signed off by area owners.

No OOB changes needed - The involved src csproj does not have IsPackable=true set.

CI failures investigated as unrelated.

Ready to merge. :shipit:
@carlossanlop
carlossanlop
merged commit cb73f5d
into
dotnet:release/6.0Jan 5, 2023
@carlossanlopcarlossanlop
modified the milestones:
6.0.x, 6.0.14Jan 5, 2023
@karelzkarelz
mentioned this pull request
Jan 6, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Feb 5, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@wfurtwfurtwfurt approved these changes

Assignees

@MihaZupanMihaZupan

Labels

area-System.Net.HttpServicing-approvedApproved for servicing releasetenet-reliabilityReliability/stability related issue (stress, load problems, etc.)

Projects


None yet


Milestone

6.0.14

Development

Successfully merging this pull request may close these issues.

5 participants

@MihaZupan@karelz@carlossanlop@wfurt@marek-safar

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/6.0] Respect SETTINGS_MAX_HEADER_LIST_SIZE on HTTP/2 by MihaZupan · Pull Request #79997 · dotnet/runtime · GitHub
Skip to content
[release/6.0] Respect SETTINGS_MAX_HEADER_LIST_SIZE on HTTP/2 - #79997
Merged
carlossanlop merged 1 commit into
dotnet:release/6.0from 
MihaZupan:http2-header-list-size-limit-net6
Jan 5, 2023
Merged
[release/6.0] Respect SETTINGS_MAX_HEADER_LIST_SIZE on HTTP/2#79997
carlossanlop merged 1 commit into
dotnet:release/6.0from 
MihaZupan:http2-header-list-size-limit-net6
Conversation
@MihaZupan
@MihaZupanMihaZupan
commented
Dec 27, 2022•

edited by karelz

Loading

Copy link


Copy Markdown

Member
Backport of #79281 to release/6.0 (only the HTTP/2 part as HTTP/3 is not supported on .NET 6)
Fixes#78193
/cc @MihaZupan
Customer Impact
Without this change, users of HttpClient may randomly hit exceptions informing them that the server closed the connection. This is difficult to debug as nothing points you at the request headers being the culprit, and impacts reliability as unrelated requests may fail at the same time due to connection multiplexing.
With HTTP/2 the server has the option to advertise the maximum length of headers it is willing to receive.

This change respects that limit and fails offending requests before they make it onto the wire, improving the overall reliability of HttpClient while also providing a useful exception message to the user.
Testing
Added targeted CI tests.

The new behavior was validated with a test app running against Kestrel.
Risk
Low, this change enforces a limit that is specified by the server.

Any request that will fail with the new error was very likely already failing before.
@MihaZupanMihaZupan
added this to the 6.0.x milestone
Dec 27, 2022
@MihaZupan
MihaZupan
requested a review
from a teamDecember 27, 2022 15:49
@MihaZupanMihaZupan
self-assigned this
Dec 27, 2022
@ghost
ghost
commented
Dec 27, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #79281 to release/6.0 (only the HTTP/2 part as HTTP/3 is not supported on .NET 6)

Contributes to #78193
/cc @MihaZupan
Customer Impact
TODO
Testing
TODO
Risk
TODO
Author:MihaZupan
Assignees:MihaZupan
Labels:
area-System.Net.Http
Milestone:6.0.x
wfurt
wfurt
approved these changes
Dec 27, 2022
View reviewed changes
@wfurtwfurt
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Dec 27, 2022

Closed


Closed

@marek-safarmarek-safar
added
the 
Servicing-consider
Issue for next servicing release review
label
Jan 2, 2023
@MihaZupanMihaZupan
added
the 
tenet-reliability
Reliability/stability related issue (stress, load problems, etc.)
label
Jan 3, 2023
@TratcherTratcher
mentioned this pull request
Jan 3, 2023

Closed

@MihaZupan
MihaZupan
commented
Jan 4, 2023

Copy link


Copy Markdown

MemberAuthor
CI failures are #79858 and #79859
@karelz
karelz
commented
Jan 5, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Approved by @SteveMCarroll via email on Thu 2023/1/5 2:32 AM - adding Servicing-approved label.
  • email: "[Servicing-Consider] [6.0.X and 7.0.X] Respect SETTINGS_MAX_HEADER_LIST_SIZE in HttpClient"
@karelzkarelz
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Jan 5, 2023
@carlossanlop
carlossanlop
commented
Jan 5, 2023

Copy link


Copy Markdown

Contributor
Approved by Tactics (6.0.14).

Signed off by area owners.

No OOB changes needed - The involved src csproj does not have IsPackable=true set.

CI failures investigated as unrelated.

Ready to merge. :shipit:
@carlossanlop
carlossanlop
merged commit cb73f5d
into
dotnet:release/6.0Jan 5, 2023
@carlossanlopcarlossanlop
modified the milestones:
6.0.x, 6.0.14Jan 5, 2023
@karelzkarelz
mentioned this pull request
Jan 6, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Feb 5, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@wfurtwfurtwfurt approved these changes

Assignees

@MihaZupanMihaZupan

Labels

area-System.Net.HttpServicing-approvedApproved for servicing releasetenet-reliabilityReliability/stability related issue (stress, load problems, etc.)

Projects


None yet


Milestone

6.0.14

Development

Successfully merging this pull request may close these issues.

5 participants

@MihaZupan@karelz@carlossanlop@wfurt@marek-safar

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[release/6.0] Respect SETTINGS_MAX_HEADER_LIST_SIZE on HTTP/2 by MihaZupan · Pull Request #79997 · dotnet/runtime · GitHub
Skip to content
[release/6.0] Respect SETTINGS_MAX_HEADER_LIST_SIZE on HTTP/2 - #79997
Merged
carlossanlop merged 1 commit into
dotnet:release/6.0from 
MihaZupan:http2-header-list-size-limit-net6
Jan 5, 2023
Merged
[release/6.0] Respect SETTINGS_MAX_HEADER_LIST_SIZE on HTTP/2#79997
carlossanlop merged 1 commit into
dotnet:release/6.0from 
MihaZupan:http2-header-list-size-limit-net6
Conversation
@MihaZupan
@MihaZupanMihaZupan
commented
Dec 27, 2022•

edited by karelz

Loading

Copy link


Copy Markdown

Member
Backport of #79281 to release/6.0 (only the HTTP/2 part as HTTP/3 is not supported on .NET 6)
Fixes#78193
/cc @MihaZupan
Customer Impact
Without this change, users of HttpClient may randomly hit exceptions informing them that the server closed the connection. This is difficult to debug as nothing points you at the request headers being the culprit, and impacts reliability as unrelated requests may fail at the same time due to connection multiplexing.
With HTTP/2 the server has the option to advertise the maximum length of headers it is willing to receive.

This change respects that limit and fails offending requests before they make it onto the wire, improving the overall reliability of HttpClient while also providing a useful exception message to the user.
Testing
Added targeted CI tests.

The new behavior was validated with a test app running against Kestrel.
Risk
Low, this change enforces a limit that is specified by the server.

Any request that will fail with the new error was very likely already failing before.
@MihaZupanMihaZupan
added this to the 6.0.x milestone
Dec 27, 2022
@MihaZupan
MihaZupan
requested a review
from a teamDecember 27, 2022 15:49
@MihaZupanMihaZupan
self-assigned this
Dec 27, 2022
@ghost
ghost
commented
Dec 27, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #79281 to release/6.0 (only the HTTP/2 part as HTTP/3 is not supported on .NET 6)

Contributes to #78193
/cc @MihaZupan
Customer Impact
TODO
Testing
TODO
Risk
TODO
Author:MihaZupan
Assignees:MihaZupan
Labels:
area-System.Net.Http
Milestone:6.0.x
wfurt
wfurt
approved these changes
Dec 27, 2022
View reviewed changes
@wfurtwfurt
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Dec 27, 2022

Closed


Closed

@marek-safarmarek-safar
added
the 
Servicing-consider
Issue for next servicing release review
label
Jan 2, 2023
@MihaZupanMihaZupan
added
the 
tenet-reliability
Reliability/stability related issue (stress, load problems, etc.)
label
Jan 3, 2023
@TratcherTratcher
mentioned this pull request
Jan 3, 2023

Closed

@MihaZupan
MihaZupan
commented
Jan 4, 2023

Copy link


Copy Markdown

MemberAuthor
CI failures are #79858 and #79859
@karelz
karelz
commented
Jan 5, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Approved by @SteveMCarroll via email on Thu 2023/1/5 2:32 AM - adding Servicing-approved label.
  • email: "[Servicing-Consider] [6.0.X and 7.0.X] Respect SETTINGS_MAX_HEADER_LIST_SIZE in HttpClient"
@karelzkarelz
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Jan 5, 2023
@carlossanlop
carlossanlop
commented
Jan 5, 2023

Copy link


Copy Markdown

Contributor
Approved by Tactics (6.0.14).

Signed off by area owners.

No OOB changes needed - The involved src csproj does not have IsPackable=true set.

CI failures investigated as unrelated.

Ready to merge. :shipit:
@carlossanlop
carlossanlop
merged commit cb73f5d
into
dotnet:release/6.0Jan 5, 2023
@carlossanlopcarlossanlop
modified the milestones:
6.0.x, 6.0.14Jan 5, 2023
@karelzkarelz
mentioned this pull request
Jan 6, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Feb 5, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@wfurtwfurtwfurt approved these changes

Assignees

@MihaZupanMihaZupan

Labels

area-System.Net.HttpServicing-approvedApproved for servicing releasetenet-reliabilityReliability/stability related issue (stress, load problems, etc.)

Projects


None yet


Milestone

6.0.14

Development

Successfully merging this pull request may close these issues.

5 participants

@MihaZupan@karelz@carlossanlop@wfurt@marek-safar

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/6.0] Respect SETTINGS_MAX_HEADER_LIST_SIZE on HTTP/2 by MihaZupan · Pull Request #79997 · dotnet/runtime · GitHub
Skip to content
[release/6.0] Respect SETTINGS_MAX_HEADER_LIST_SIZE on HTTP/2 - #79997
Merged
carlossanlop merged 1 commit into
dotnet:release/6.0from 
MihaZupan:http2-header-list-size-limit-net6
Jan 5, 2023
Merged
[release/6.0] Respect SETTINGS_MAX_HEADER_LIST_SIZE on HTTP/2#79997
carlossanlop merged 1 commit into
dotnet:release/6.0from 
MihaZupan:http2-header-list-size-limit-net6
Conversation
@MihaZupan
@MihaZupanMihaZupan
commented
Dec 27, 2022•

edited by karelz

Loading

Copy link


Copy Markdown

Member
Backport of #79281 to release/6.0 (only the HTTP/2 part as HTTP/3 is not supported on .NET 6)
Fixes#78193
/cc @MihaZupan
Customer Impact
Without this change, users of HttpClient may randomly hit exceptions informing them that the server closed the connection. This is difficult to debug as nothing points you at the request headers being the culprit, and impacts reliability as unrelated requests may fail at the same time due to connection multiplexing.
With HTTP/2 the server has the option to advertise the maximum length of headers it is willing to receive.

This change respects that limit and fails offending requests before they make it onto the wire, improving the overall reliability of HttpClient while also providing a useful exception message to the user.
Testing
Added targeted CI tests.

The new behavior was validated with a test app running against Kestrel.
Risk
Low, this change enforces a limit that is specified by the server.

Any request that will fail with the new error was very likely already failing before.
@MihaZupanMihaZupan
added this to the 6.0.x milestone
Dec 27, 2022
@MihaZupan
MihaZupan
requested a review
from a teamDecember 27, 2022 15:49
@MihaZupanMihaZupan
self-assigned this
Dec 27, 2022
@ghost
ghost
commented
Dec 27, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #79281 to release/6.0 (only the HTTP/2 part as HTTP/3 is not supported on .NET 6)

Contributes to #78193
/cc @MihaZupan
Customer Impact
TODO
Testing
TODO
Risk
TODO
Author:MihaZupan
Assignees:MihaZupan
Labels:
area-System.Net.Http
Milestone:6.0.x
wfurt
wfurt
approved these changes
Dec 27, 2022
View reviewed changes
@wfurtwfurt
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Dec 27, 2022

Closed


Closed

@marek-safarmarek-safar
added
the 
Servicing-consider
Issue for next servicing release review
label
Jan 2, 2023
@MihaZupanMihaZupan
added
the 
tenet-reliability
Reliability/stability related issue (stress, load problems, etc.)
label
Jan 3, 2023
@TratcherTratcher
mentioned this pull request
Jan 3, 2023

Closed

@MihaZupan
MihaZupan
commented
Jan 4, 2023

Copy link


Copy Markdown

MemberAuthor
CI failures are #79858 and #79859
@karelz
karelz
commented
Jan 5, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Approved by @SteveMCarroll via email on Thu 2023/1/5 2:32 AM - adding Servicing-approved label.
  • email: "[Servicing-Consider] [6.0.X and 7.0.X] Respect SETTINGS_MAX_HEADER_LIST_SIZE in HttpClient"
@karelzkarelz
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Jan 5, 2023
@carlossanlop
carlossanlop
commented
Jan 5, 2023

Copy link


Copy Markdown

Contributor
Approved by Tactics (6.0.14).

Signed off by area owners.

No OOB changes needed - The involved src csproj does not have IsPackable=true set.

CI failures investigated as unrelated.

Ready to merge. :shipit:
@carlossanlop
carlossanlop
merged commit cb73f5d
into
dotnet:release/6.0Jan 5, 2023
@carlossanlopcarlossanlop
modified the milestones:
6.0.x, 6.0.14Jan 5, 2023
@karelzkarelz
mentioned this pull request
Jan 6, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Feb 5, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@wfurtwfurtwfurt approved these changes

Assignees

@MihaZupanMihaZupan

Labels

area-System.Net.HttpServicing-approvedApproved for servicing releasetenet-reliabilityReliability/stability related issue (stress, load problems, etc.)

Projects


None yet


Milestone

6.0.14

Development

Successfully merging this pull request may close these issues.

5 participants

@MihaZupan@karelz@carlossanlop@wfurt@marek-safar

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/6.0] Respect SETTINGS_MAX_HEADER_LIST_SIZE on HTTP/2 by MihaZupan · Pull Request #79997 · dotnet/runtime · GitHub
Skip to content
[release/6.0] Respect SETTINGS_MAX_HEADER_LIST_SIZE on HTTP/2 - #79997
Merged
carlossanlop merged 1 commit into
dotnet:release/6.0from 
MihaZupan:http2-header-list-size-limit-net6
Jan 5, 2023
Merged
[release/6.0] Respect SETTINGS_MAX_HEADER_LIST_SIZE on HTTP/2#79997
carlossanlop merged 1 commit into
dotnet:release/6.0from 
MihaZupan:http2-header-list-size-limit-net6
Conversation
@MihaZupan
@MihaZupanMihaZupan
commented
Dec 27, 2022•

edited by karelz

Loading

Copy link


Copy Markdown

Member
Backport of #79281 to release/6.0 (only the HTTP/2 part as HTTP/3 is not supported on .NET 6)
Fixes#78193
/cc @MihaZupan
Customer Impact
Without this change, users of HttpClient may randomly hit exceptions informing them that the server closed the connection. This is difficult to debug as nothing points you at the request headers being the culprit, and impacts reliability as unrelated requests may fail at the same time due to connection multiplexing.
With HTTP/2 the server has the option to advertise the maximum length of headers it is willing to receive.

This change respects that limit and fails offending requests before they make it onto the wire, improving the overall reliability of HttpClient while also providing a useful exception message to the user.
Testing
Added targeted CI tests.

The new behavior was validated with a test app running against Kestrel.
Risk
Low, this change enforces a limit that is specified by the server.

Any request that will fail with the new error was very likely already failing before.
@MihaZupanMihaZupan
added this to the 6.0.x milestone
Dec 27, 2022
@MihaZupan
MihaZupan
requested a review
from a teamDecember 27, 2022 15:49
@MihaZupanMihaZupan
self-assigned this
Dec 27, 2022
@ghost
ghost
commented
Dec 27, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #79281 to release/6.0 (only the HTTP/2 part as HTTP/3 is not supported on .NET 6)

Contributes to #78193
/cc @MihaZupan
Customer Impact
TODO
Testing
TODO
Risk
TODO
Author:MihaZupan
Assignees:MihaZupan
Labels:
area-System.Net.Http
Milestone:6.0.x
wfurt
wfurt
approved these changes
Dec 27, 2022
View reviewed changes
@wfurtwfurt
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Dec 27, 2022

Closed


Closed

@marek-safarmarek-safar
added
the 
Servicing-consider
Issue for next servicing release review
label
Jan 2, 2023
@MihaZupanMihaZupan
added
the 
tenet-reliability
Reliability/stability related issue (stress, load problems, etc.)
label
Jan 3, 2023
@TratcherTratcher
mentioned this pull request
Jan 3, 2023

Closed

@MihaZupan
MihaZupan
commented
Jan 4, 2023

Copy link


Copy Markdown

MemberAuthor
CI failures are #79858 and #79859
@karelz
karelz
commented
Jan 5, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Approved by @SteveMCarroll via email on Thu 2023/1/5 2:32 AM - adding Servicing-approved label.
  • email: "[Servicing-Consider] [6.0.X and 7.0.X] Respect SETTINGS_MAX_HEADER_LIST_SIZE in HttpClient"
@karelzkarelz
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Jan 5, 2023
@carlossanlop
carlossanlop
commented
Jan 5, 2023

Copy link


Copy Markdown

Contributor
Approved by Tactics (6.0.14).

Signed off by area owners.

No OOB changes needed - The involved src csproj does not have IsPackable=true set.

CI failures investigated as unrelated.

Ready to merge. :shipit:
@carlossanlop
carlossanlop
merged commit cb73f5d
into
dotnet:release/6.0Jan 5, 2023
@carlossanlopcarlossanlop
modified the milestones:
6.0.x, 6.0.14Jan 5, 2023
@karelzkarelz
mentioned this pull request
Jan 6, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Feb 5, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@wfurtwfurtwfurt approved these changes

Assignees

@MihaZupanMihaZupan

Labels

area-System.Net.HttpServicing-approvedApproved for servicing releasetenet-reliabilityReliability/stability related issue (stress, load problems, etc.)

Projects


None yet


Milestone

6.0.14

Development

Successfully merging this pull request may close these issues.

5 participants

@MihaZupan@karelz@carlossanlop@wfurt@marek-safar

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
[release/6.0] Respect SETTINGS_MAX_HEADER_LIST_SIZE on HTTP/2 by MihaZupan · Pull Request #79997 · dotnet/runtime · GitHub
Skip to content
[release/6.0] Respect SETTINGS_MAX_HEADER_LIST_SIZE on HTTP/2 - #79997
Merged
carlossanlop merged 1 commit into
dotnet:release/6.0from 
MihaZupan:http2-header-list-size-limit-net6
Jan 5, 2023
Merged
[release/6.0] Respect SETTINGS_MAX_HEADER_LIST_SIZE on HTTP/2#79997
carlossanlop merged 1 commit into
dotnet:release/6.0from 
MihaZupan:http2-header-list-size-limit-net6
Conversation
@MihaZupan
@MihaZupanMihaZupan
commented
Dec 27, 2022•

edited by karelz

Loading

Copy link


Copy Markdown

Member
Backport of #79281 to release/6.0 (only the HTTP/2 part as HTTP/3 is not supported on .NET 6)
Fixes#78193
/cc @MihaZupan
Customer Impact
Without this change, users of HttpClient may randomly hit exceptions informing them that the server closed the connection. This is difficult to debug as nothing points you at the request headers being the culprit, and impacts reliability as unrelated requests may fail at the same time due to connection multiplexing.
With HTTP/2 the server has the option to advertise the maximum length of headers it is willing to receive.

This change respects that limit and fails offending requests before they make it onto the wire, improving the overall reliability of HttpClient while also providing a useful exception message to the user.
Testing
Added targeted CI tests.

The new behavior was validated with a test app running against Kestrel.
Risk
Low, this change enforces a limit that is specified by the server.

Any request that will fail with the new error was very likely already failing before.
@MihaZupanMihaZupan
added this to the 6.0.x milestone
Dec 27, 2022
@MihaZupan
MihaZupan
requested a review
from a teamDecember 27, 2022 15:49
@MihaZupanMihaZupan
self-assigned this
Dec 27, 2022
@ghost
ghost
commented
Dec 27, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #79281 to release/6.0 (only the HTTP/2 part as HTTP/3 is not supported on .NET 6)

Contributes to #78193
/cc @MihaZupan
Customer Impact
TODO
Testing
TODO
Risk
TODO
Author:MihaZupan
Assignees:MihaZupan
Labels:
area-System.Net.Http
Milestone:6.0.x
wfurt
wfurt
approved these changes
Dec 27, 2022
View reviewed changes
@wfurtwfurt
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Dec 27, 2022

Closed


Closed

@marek-safarmarek-safar
added
the 
Servicing-consider
Issue for next servicing release review
label
Jan 2, 2023
@MihaZupanMihaZupan
added
the 
tenet-reliability
Reliability/stability related issue (stress, load problems, etc.)
label
Jan 3, 2023
@TratcherTratcher
mentioned this pull request
Jan 3, 2023

Closed

@MihaZupan
MihaZupan
commented
Jan 4, 2023

Copy link


Copy Markdown

MemberAuthor
CI failures are #79858 and #79859
@karelz
karelz
commented
Jan 5, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Approved by @SteveMCarroll via email on Thu 2023/1/5 2:32 AM - adding Servicing-approved label.
  • email: "[Servicing-Consider] [6.0.X and 7.0.X] Respect SETTINGS_MAX_HEADER_LIST_SIZE in HttpClient"
@karelzkarelz
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Jan 5, 2023
@carlossanlop
carlossanlop
commented
Jan 5, 2023

Copy link


Copy Markdown

Contributor
Approved by Tactics (6.0.14).

Signed off by area owners.

No OOB changes needed - The involved src csproj does not have IsPackable=true set.

CI failures investigated as unrelated.

Ready to merge. :shipit:
@carlossanlop
carlossanlop
merged commit cb73f5d
into
dotnet:release/6.0Jan 5, 2023
@carlossanlopcarlossanlop
modified the milestones:
6.0.x, 6.0.14Jan 5, 2023
@karelzkarelz
mentioned this pull request
Jan 6, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Feb 5, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@wfurtwfurtwfurt approved these changes

Assignees

@MihaZupanMihaZupan

Labels

area-System.Net.HttpServicing-approvedApproved for servicing releasetenet-reliabilityReliability/stability related issue (stress, load problems, etc.)

Projects


None yet


Milestone

6.0.14

Development

Successfully merging this pull request may close these issues.

5 participants

@MihaZupan@karelz@carlossanlop@wfurt@marek-safar