Skip to content

Respect SETTINGS_MAX_HEADER_LIST_SIZE on HTTP/2 and HTTP/3 - #79281

Merged
MihaZupan merged 1 commit into
dotnet:mainfrom
MihaZupan:http2-header-list-size-limit
Dec 27, 2022
Merged

Respect SETTINGS_MAX_HEADER_LIST_SIZE on HTTP/2 and HTTP/3#79281
MihaZupan merged 1 commit into
dotnet:mainfrom
MihaZupan:http2-header-list-size-limit

Conversation

@MihaZupan

@MihaZupanMihaZupan commented Dec 6, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Closes#78193

This PR does approximate header list length calculations for HTTP/2 and HTTP/3 in order to enforce the SETTINGS_MAX_HEADER_LIST_SIZE setting. It is a slight overestimation of the actual size (mainly from counting the overhead of HPACK framing), therefore making the client slightly more strict than the spec describes.
ASP.NET Core on the other hand is slightly less strict than the spec describes dotnet/aspnetcore#44668 (this is good, you don't want the client/server to be the other way around).

Do we care about the calculated length being exactly correct? Given this limit is generally really high and should only be hit in exceptional cases, I don't think we do. Doing precise bookkeeping would mainly represent a maintenance burden for us (and a slight performance overhead). The current approach of taking the encoded length from HPACK works well as long as we don't support the dynamic table/compression for request headers.

cc: @Tratcher

@MihaZupanMihaZupan added this to the 8.0.0 milestone Dec 6, 2022
@MihaZupan
MihaZupan requested a review from a teamDecember 6, 2022 16:31
@MihaZupanMihaZupan self-assigned this Dec 6, 2022
@ghost

ghost commented Dec 6, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Closes #78193

This PR does approximate header list length calculations for HTTP/2 and HTTP/3 in order to enforce the SETTINGS_MAX_HEADER_LIST_SIZE setting. It is a slight overestimation of the actual size (mainly from counting the overhead of HPACK framing), therefore making the client slightly more strict than the spec describes.
ASP.NET Core on the other hand is slightly less strict than the spec describes (dotnet/aspnetcore#44668).

Do we care about the calculated length being exactly correct? Given this limit is generally really high and should only be hit in exceptional cases, I don't think we do. Doing precise bookkeeping would mainly represent a maintenance burden for us (and a slight performance overhead). The current approach of taking the encoded length from HPACK works well as long as we don't support the dynamic table/compression for request headers.

cc: @Tratcher

Author:MihaZupan
Assignees:MihaZupan
Labels:

area-System.Net.Http

Milestone:8.0.0

MihaZupan
MihaZupan commented Dec 6, 2022
View reviewed changes
Comment threadsrc/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs Outdated
@build-analysisbuild-analysisBot mentioned this pull request Dec 6, 2022
Closed
CarnaViire
CarnaViire reviewed Dec 12, 2022
View reviewed changes
Comment threadsrc/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http3RequestStream.cs Outdated
Comment threadsrc/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http2Connection.cs Outdated
Comment threadsrc/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http3RequestStream.cs Outdated
Comment threadsrc/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http2Connection.cs Outdated
CarnaViire
CarnaViire approved these changes Dec 13, 2022
View reviewed changes

@CarnaViireCarnaViire left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MihaZupan

MihaZupan commented Dec 13, 2022

Copy link
Copy Markdown
MemberAuthor

@Tratcher can you please take a look at this one if this reduced change still makes sense to you?

Tratcher
Tratcher approved these changes Dec 19, 2022
View reviewed changes
Comment threadsrc/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionPool.cs Outdated
@MihaZupan
MihaZupanforce-pushed the http2-header-list-size-limit branch from 7efb4f5 to d8d975aCompareDecember 26, 2022 10:10
@build-analysisbuild-analysisBot mentioned this pull request Dec 26, 2022
Closed
@MihaZupan
MihaZupan merged commit c84d95d into dotnet:mainDec 27, 2022
@MihaZupan

MihaZupan commented Dec 27, 2022

Copy link
Copy Markdown
MemberAuthor

/backport to release/7.0

@github-actions

github-actionsBot commented Dec 27, 2022

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3787989385

@github-actionsgithub-actionsBot mentioned this pull request Dec 27, 2022
Merged
@MihaZupanMihaZupan mentioned this pull request Dec 27, 2022
Merged
@MihaZupanMihaZupan added the tenet-reliability Reliability/stability related issue (stress, load problems, etc.) label Jan 3, 2023
@karelzkarelz mentioned this pull request Jan 6, 2023
Closed
@wtgodbewtgodbe mentioned this pull request Jan 24, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Feb 2, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@TratcherTratcherTratcher approved these changes
@CarnaViireCarnaViireCarnaViire approved these changes

Assignees

@MihaZupanMihaZupan

Labels

area-System.Net.Httptenet-reliabilityReliability/stability related issue (stress, load problems, etc.)

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

Support SETTINGS_MAX_HEADER_LIST_SIZE on HTTP/2 and HTTP/3

3 participants

@MihaZupan@Tratcher@CarnaViire