Uh oh!
There was an error while loading. Please reload this page.
Fix nested non-byref like VC with no pointer fields - #80642
Conversation
11cea99 to
21bf6f5CompareAaronRobinsonMSFT
commented
Jan 14, 2023
@BrzVlad@vargaz@lambdageek Any thoughts on the llvmfullaot legs? |
vargaz
commented
Jan 15, 2023
The failure is in the newly added tests, so it definitely looks like a mono problem. I'd suggest disabling it for now for mono. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
AaronRobinsonMSFT
commented
Jan 18, 2023
@mangod9 Can you suggest someone who could help review this change? @davidwrighton is away. |
mangod9
commented
Jan 18, 2023
@trylek, who can take a look. |
AaronRobinsonMSFT
commented
Jan 19, 2023
/backport to release/7.0 |
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3961567258 |
@AaronRobinsonMSFT backporting to release/7.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Fix nested non-byref like VC with no pointer fields
Applying: Add tests
Applying: Fix test typo
Applying: Disable new test on llvmaot
Using index info to reconstruct a base tree...
M src/tests/issues.targets
Falling back to patching base and 3-way merge...
Auto-merging src/tests/issues.targets
CONFLICT (content): Merge conflict in src/tests/issues.targets
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0004 Disable new test on llvmaot
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
@AaronRobinsonMSFT an error occurred while backporting to release/7.0, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
* Fix nested non-byref like VC with no pointer fields
* Fix nested non-byref like VC with no pointer fields
Tests need to be added. This is just for checking existing tests on all platforms first.
Fixes#80624