Uh oh!
There was an error while loading. Please reload this page.
[release/7.0] Fix nested non-byref like VC with no pointer fields - #80873
Merged
Conversation
* Fix nested non-byref like VC with no pointer fields
trylek
approved these changes
Jan 19, 2023
trylek
left a comment
Member
There was a problem hiding this comment.
Looks just as good as the original version, thank you!
jeffschwMSFT
approved these changes
Jan 19, 2023
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
approved. we will take for consideration in 7.0.x
carlossanlop
commented
Feb 8, 2023
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #80642 that fixes#80624
Customer Impact
Customer reported issue with nested ref structs. A
TypeLoadExceptioncan occur when a non-ByRefLike struct contains other structs marked with explicit layout. This was a regression introduced when adding ref field support in #65246.Testing
New tests have been added for this failure case and others in the same area.
Risk
Low. The fix here is a permitting behavior that existed in .NET 6 but folding in the ref field logic. The changes to make that support are simple enough and should avoid the failing behavior that was acknowledged by an assert in debug builds. This implements the needed path.