Skip to content

Disable System.Reflection.Tests.TypeDelegatorTests.FunctionPointers - #82321

Merged
BruceForstall merged 1 commit into
dotnet:mainfrom
BruceForstall:DisableFunctionPointersTest
Feb 18, 2023
Merged

Disable System.Reflection.Tests.TypeDelegatorTests.FunctionPointers#82321
BruceForstall merged 1 commit into
dotnet:mainfrom
BruceForstall:DisableFunctionPointersTest

Conversation

@BruceForstall

@BruceForstallBruceForstall commented Feb 17, 2023

Copy link
Copy Markdown
Contributor

Disable this failing test on CoreCLR.

Tracking: #82252

@BruceForstall

BruceForstall commented Feb 17, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-coreclr libraries-jitstress

@ghost

ghost commented Feb 17, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

Disable this failing test on CoreCLR.

Tracking: #82252

Author:BruceForstall
Assignees:BruceForstall
Labels:

area-System.Reflection

Milestone:-

@azure-pipelines

azure-pipelinesBot commented Feb 17, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@BruceForstall

BruceForstall commented Feb 17, 2023

Copy link
Copy Markdown
ContributorAuthor

@dotnet/jit-contrib PTAL -- want to get a clean libraries stress pipeline

@steveharter

steveharter commented Feb 17, 2023

Copy link
Copy Markdown
Contributor

It looks like the "jitstress" tests are successful but there's still other failures -- so was disabling that test successful here?

@jkotas

jkotas commented Feb 17, 2023

Copy link
Copy Markdown
Member

#82325 has the actual fix for the problem.

If this is the only failing test, I am ok with disabling the test before the actual fix is merged.

Note that the failure only repros with tiered compilation disabled, or when the affected code is promoted to Tier 1.

@BruceForstall

BruceForstall commented Feb 17, 2023

Copy link
Copy Markdown
ContributorAuthor

If this is the only failing test, I am ok with disabling the test before the actual fix is merged.

I'd prefer to disable the test when this testing completes, then you can re-enable either with your fix or afterwards, after also running a clean libraries-jitstress pipeline.

fwiw, we should probably add a TieredCompilation=0 run to all libraries changes.

steveharter
steveharter approved these changes Feb 17, 2023
View reviewed changes

@stevehartersteveharter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the real fix goes in, I'll revert this. Thanks

@jkotas

jkotas commented Feb 17, 2023

Copy link
Copy Markdown
Member

fwiw, we should probably add a TieredCompilation=0 run to all libraries changes.

I agree that it would be nice, but it is not where we are going with PR CI. We do not have enough budget to test all variants in PR CI. We are on a path to do less testing in PR CI and allow more issues to slip through that are only going to be found later in rolling runs.

@BruceForstall

BruceForstall commented Feb 18, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

I've wondered whether the libraries tests PR testing should be TieredCompilation=0 and the outerloop rolling should be the default TieredCompilation=1. I wonder how many of the functions executed during libraries tests are compiled in Tier-0 versus Tier-1. It probably doesn't matter to the libraries team, but for the JIT team it does matter.

@BruceForstall
BruceForstall merged commit 473e278 into dotnet:mainFeb 18, 2023
@BruceForstall
BruceForstall deleted the DisableFunctionPointersTest branch February 18, 2023 00:17
jkotas added a commit to jkotas/runtime that referenced this pull request Feb 18, 2023
@jkotas
Revert "Disable System.Reflection.Tests.TypeDelegatorTests.FunctionPo…
8a1ff58
…inters (dotnet#82321)"
This reverts commit 473e278.
This was referenced Feb 18, 2023
Open
Closed
jkotas added a commit that referenced this pull request Feb 18, 2023
@jkotas
Fix FnPtrTypeDesc::GetManagedClassObject (#82325)
2bd2ed9
* Fix FnPtrTypeDesc::GetManagedClassObject
The code was missing support for allocating RuntimeType objects on frozen heap
Fixes#82252
* Revert "Disable System.Reflection.Tests.TypeDelegatorTests.FunctionPointers (#82321)"
This reverts commit 473e278.
@ghostghost locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes
@jkotasjkotasAwaiting requested review from jkotas
+1 more reviewer
@steveharterstevehartersteveharter approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@BruceForstallBruceForstall

Labels

area-System.Reflection

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BruceForstall@steveharter@jkotas@jakobbotsch
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Disable System.Reflection.Tests.TypeDelegatorTests.FunctionPointers by BruceForstall · Pull Request #82321 · dotnet/runtime · GitHub
Skip to content
Disable System.Reflection.Tests.TypeDelegatorTests.FunctionPointers - #82321
Merged
BruceForstall merged 1 commit into
dotnet:mainfrom 
BruceForstall:DisableFunctionPointersTest
Feb 18, 2023
Merged
Disable System.Reflection.Tests.TypeDelegatorTests.FunctionPointers#82321
BruceForstall merged 1 commit into
dotnet:mainfrom 
BruceForstall:DisableFunctionPointersTest
Conversation
@BruceForstall
@BruceForstallBruceForstall
commented
Feb 17, 2023

Copy link


Copy Markdown

Contributor
Disable this failing test on CoreCLR.
Tracking: #82252
@BruceForstall
BruceForstall
commented
Feb 17, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr libraries-jitstress
@ghost
ghost
commented
Feb 17, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-reflection

See info in area-owners.md if you want to be subscribed.
Issue Details
Disable this failing test on CoreCLR.
Tracking: #82252
Author:BruceForstall
Assignees:BruceForstall
Labels:
area-System.Reflection
Milestone:-
@azure-pipelines
azure-pipelinesBot
commented
Feb 17, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@BruceForstall
BruceForstall
commented
Feb 17, 2023

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib PTAL -- want to get a clean libraries stress pipeline
@steveharter
steveharter
commented
Feb 17, 2023

Copy link


Copy Markdown

Contributor
It looks like the "jitstress" tests are successful but there's still other failures -- so was disabling that test successful here?
@jkotas
jkotas
commented
Feb 17, 2023

Copy link


Copy Markdown

Member
#82325 has the actual fix for the problem.
If this is the only failing test, I am ok with disabling the test before the actual fix is merged.
Note that the failure only repros with tiered compilation disabled, or when the affected code is promoted to Tier 1.
@BruceForstall
BruceForstall
commented
Feb 17, 2023

Copy link


Copy Markdown

ContributorAuthor
If this is the only failing test, I am ok with disabling the test before the actual fix is merged.
I'd prefer to disable the test when this testing completes, then you can re-enable either with your fix or afterwards, after also running a clean libraries-jitstress pipeline.
fwiw, we should probably add a TieredCompilation=0 run to all libraries changes.
steveharter
steveharter
approved these changes
Feb 17, 2023
View reviewed changes
@stevehartersteveharter
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the real fix goes in, I'll revert this. Thanks
@jkotas
jkotas
commented
Feb 17, 2023

Copy link


Copy Markdown

Member
fwiw, we should probably add a TieredCompilation=0 run to all libraries changes.
I agree that it would be nice, but it is not where we are going with PR CI. We do not have enough budget to test all variants in PR CI. We are on a path to do less testing in PR CI and allow more issues to slip through that are only going to be found later in rolling runs.
@BruceForstall
BruceForstall
commented
Feb 18, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I've wondered whether the libraries tests PR testing should be TieredCompilation=0 and the outerloop rolling should be the default TieredCompilation=1. I wonder how many of the functions executed during libraries tests are compiled in Tier-0 versus Tier-1. It probably doesn't matter to the libraries team, but for the JIT team it does matter.
@BruceForstall
BruceForstall
merged commit 473e278
into
dotnet:mainFeb 18, 2023
@BruceForstall
BruceForstall
deleted the

DisableFunctionPointersTest

branch
February 18, 2023 00:17
jkotas added a commit
to jkotas/runtime
that referenced
this pull request
Feb 18, 2023
@jkotas
Revert "Disable System.Reflection.Tests.TypeDelegatorTests.FunctionPo…
8a1ff58
…inters (dotnet#82321)"
This reverts commit 473e278.

This was referenced Feb 18, 2023

Open


Closed

jkotas added a commit
that referenced
this pull request
Feb 18, 2023
@jkotas
Fix FnPtrTypeDesc::GetManagedClassObject (#82325)
2bd2ed9
* Fix FnPtrTypeDesc::GetManagedClassObject
The code was missing support for allocating RuntimeType objects on frozen heap
Fixes#82252
* Revert "Disable System.Reflection.Tests.TypeDelegatorTests.FunctionPointers (#82321)"
This reverts commit 473e278.
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 20, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes
@jkotasjkotasAwaiting requested review from jkotas

+1 more reviewer

@steveharterstevehartersteveharter approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@BruceForstallBruceForstall

Labels

area-System.Reflection

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@BruceForstall@steveharter@jkotas@jakobbotsch

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Disable System.Reflection.Tests.TypeDelegatorTests.FunctionPointers by BruceForstall · Pull Request #82321 · dotnet/runtime · GitHub
Skip to content
Disable System.Reflection.Tests.TypeDelegatorTests.FunctionPointers - #82321
Merged
BruceForstall merged 1 commit into
dotnet:mainfrom 
BruceForstall:DisableFunctionPointersTest
Feb 18, 2023
Merged
Disable System.Reflection.Tests.TypeDelegatorTests.FunctionPointers#82321
BruceForstall merged 1 commit into
dotnet:mainfrom 
BruceForstall:DisableFunctionPointersTest
Conversation
@BruceForstall
@BruceForstallBruceForstall
commented
Feb 17, 2023

Copy link


Copy Markdown

Contributor
Disable this failing test on CoreCLR.
Tracking: #82252
@BruceForstall
BruceForstall
commented
Feb 17, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr libraries-jitstress
@ghost
ghost
commented
Feb 17, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-reflection

See info in area-owners.md if you want to be subscribed.
Issue Details
Disable this failing test on CoreCLR.
Tracking: #82252
Author:BruceForstall
Assignees:BruceForstall
Labels:
area-System.Reflection
Milestone:-
@azure-pipelines
azure-pipelinesBot
commented
Feb 17, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@BruceForstall
BruceForstall
commented
Feb 17, 2023

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib PTAL -- want to get a clean libraries stress pipeline
@steveharter
steveharter
commented
Feb 17, 2023

Copy link


Copy Markdown

Contributor
It looks like the "jitstress" tests are successful but there's still other failures -- so was disabling that test successful here?
@jkotas
jkotas
commented
Feb 17, 2023

Copy link


Copy Markdown

Member
#82325 has the actual fix for the problem.
If this is the only failing test, I am ok with disabling the test before the actual fix is merged.
Note that the failure only repros with tiered compilation disabled, or when the affected code is promoted to Tier 1.
@BruceForstall
BruceForstall
commented
Feb 17, 2023

Copy link


Copy Markdown

ContributorAuthor
If this is the only failing test, I am ok with disabling the test before the actual fix is merged.
I'd prefer to disable the test when this testing completes, then you can re-enable either with your fix or afterwards, after also running a clean libraries-jitstress pipeline.
fwiw, we should probably add a TieredCompilation=0 run to all libraries changes.
steveharter
steveharter
approved these changes
Feb 17, 2023
View reviewed changes
@stevehartersteveharter
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the real fix goes in, I'll revert this. Thanks
@jkotas
jkotas
commented
Feb 17, 2023

Copy link


Copy Markdown

Member
fwiw, we should probably add a TieredCompilation=0 run to all libraries changes.
I agree that it would be nice, but it is not where we are going with PR CI. We do not have enough budget to test all variants in PR CI. We are on a path to do less testing in PR CI and allow more issues to slip through that are only going to be found later in rolling runs.
@BruceForstall
BruceForstall
commented
Feb 18, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I've wondered whether the libraries tests PR testing should be TieredCompilation=0 and the outerloop rolling should be the default TieredCompilation=1. I wonder how many of the functions executed during libraries tests are compiled in Tier-0 versus Tier-1. It probably doesn't matter to the libraries team, but for the JIT team it does matter.
@BruceForstall
BruceForstall
merged commit 473e278
into
dotnet:mainFeb 18, 2023
@BruceForstall
BruceForstall
deleted the

DisableFunctionPointersTest

branch
February 18, 2023 00:17
jkotas added a commit
to jkotas/runtime
that referenced
this pull request
Feb 18, 2023
@jkotas
Revert "Disable System.Reflection.Tests.TypeDelegatorTests.FunctionPo…
8a1ff58
…inters (dotnet#82321)"
This reverts commit 473e278.

This was referenced Feb 18, 2023

Open


Closed

jkotas added a commit
that referenced
this pull request
Feb 18, 2023
@jkotas
Fix FnPtrTypeDesc::GetManagedClassObject (#82325)
2bd2ed9
* Fix FnPtrTypeDesc::GetManagedClassObject
The code was missing support for allocating RuntimeType objects on frozen heap
Fixes#82252
* Revert "Disable System.Reflection.Tests.TypeDelegatorTests.FunctionPointers (#82321)"
This reverts commit 473e278.
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 20, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes
@jkotasjkotasAwaiting requested review from jkotas

+1 more reviewer

@steveharterstevehartersteveharter approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@BruceForstallBruceForstall

Labels

area-System.Reflection

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@BruceForstall@steveharter@jkotas@jakobbotsch

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Disable System.Reflection.Tests.TypeDelegatorTests.FunctionPointers by BruceForstall · Pull Request #82321 · dotnet/runtime · GitHub
Skip to content
Disable System.Reflection.Tests.TypeDelegatorTests.FunctionPointers - #82321
Merged
BruceForstall merged 1 commit into
dotnet:mainfrom 
BruceForstall:DisableFunctionPointersTest
Feb 18, 2023
Merged
Disable System.Reflection.Tests.TypeDelegatorTests.FunctionPointers#82321
BruceForstall merged 1 commit into
dotnet:mainfrom 
BruceForstall:DisableFunctionPointersTest
Conversation
@BruceForstall
@BruceForstallBruceForstall
commented
Feb 17, 2023

Copy link


Copy Markdown

Contributor
Disable this failing test on CoreCLR.
Tracking: #82252
@BruceForstall
BruceForstall
commented
Feb 17, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr libraries-jitstress
@ghost
ghost
commented
Feb 17, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-reflection

See info in area-owners.md if you want to be subscribed.
Issue Details
Disable this failing test on CoreCLR.
Tracking: #82252
Author:BruceForstall
Assignees:BruceForstall
Labels:
area-System.Reflection
Milestone:-
@azure-pipelines
azure-pipelinesBot
commented
Feb 17, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@BruceForstall
BruceForstall
commented
Feb 17, 2023

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib PTAL -- want to get a clean libraries stress pipeline
@steveharter
steveharter
commented
Feb 17, 2023

Copy link


Copy Markdown

Contributor
It looks like the "jitstress" tests are successful but there's still other failures -- so was disabling that test successful here?
@jkotas
jkotas
commented
Feb 17, 2023

Copy link


Copy Markdown

Member
#82325 has the actual fix for the problem.
If this is the only failing test, I am ok with disabling the test before the actual fix is merged.
Note that the failure only repros with tiered compilation disabled, or when the affected code is promoted to Tier 1.
@BruceForstall
BruceForstall
commented
Feb 17, 2023

Copy link


Copy Markdown

ContributorAuthor
If this is the only failing test, I am ok with disabling the test before the actual fix is merged.
I'd prefer to disable the test when this testing completes, then you can re-enable either with your fix or afterwards, after also running a clean libraries-jitstress pipeline.
fwiw, we should probably add a TieredCompilation=0 run to all libraries changes.
steveharter
steveharter
approved these changes
Feb 17, 2023
View reviewed changes
@stevehartersteveharter
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the real fix goes in, I'll revert this. Thanks
@jkotas
jkotas
commented
Feb 17, 2023

Copy link


Copy Markdown

Member
fwiw, we should probably add a TieredCompilation=0 run to all libraries changes.
I agree that it would be nice, but it is not where we are going with PR CI. We do not have enough budget to test all variants in PR CI. We are on a path to do less testing in PR CI and allow more issues to slip through that are only going to be found later in rolling runs.
@BruceForstall
BruceForstall
commented
Feb 18, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I've wondered whether the libraries tests PR testing should be TieredCompilation=0 and the outerloop rolling should be the default TieredCompilation=1. I wonder how many of the functions executed during libraries tests are compiled in Tier-0 versus Tier-1. It probably doesn't matter to the libraries team, but for the JIT team it does matter.
@BruceForstall
BruceForstall
merged commit 473e278
into
dotnet:mainFeb 18, 2023
@BruceForstall
BruceForstall
deleted the

DisableFunctionPointersTest

branch
February 18, 2023 00:17
jkotas added a commit
to jkotas/runtime
that referenced
this pull request
Feb 18, 2023
@jkotas
Revert "Disable System.Reflection.Tests.TypeDelegatorTests.FunctionPo…
8a1ff58
…inters (dotnet#82321)"
This reverts commit 473e278.

This was referenced Feb 18, 2023

Open


Closed

jkotas added a commit
that referenced
this pull request
Feb 18, 2023
@jkotas
Fix FnPtrTypeDesc::GetManagedClassObject (#82325)
2bd2ed9
* Fix FnPtrTypeDesc::GetManagedClassObject
The code was missing support for allocating RuntimeType objects on frozen heap
Fixes#82252
* Revert "Disable System.Reflection.Tests.TypeDelegatorTests.FunctionPointers (#82321)"
This reverts commit 473e278.
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 20, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes
@jkotasjkotasAwaiting requested review from jkotas

+1 more reviewer

@steveharterstevehartersteveharter approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@BruceForstallBruceForstall

Labels

area-System.Reflection

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@BruceForstall@steveharter@jkotas@jakobbotsch

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Disable System.Reflection.Tests.TypeDelegatorTests.FunctionPointers by BruceForstall · Pull Request #82321 · dotnet/runtime · GitHub
Skip to content
Disable System.Reflection.Tests.TypeDelegatorTests.FunctionPointers - #82321
Merged
BruceForstall merged 1 commit into
dotnet:mainfrom 
BruceForstall:DisableFunctionPointersTest
Feb 18, 2023
Merged
Disable System.Reflection.Tests.TypeDelegatorTests.FunctionPointers#82321
BruceForstall merged 1 commit into
dotnet:mainfrom 
BruceForstall:DisableFunctionPointersTest
Conversation
@BruceForstall
@BruceForstallBruceForstall
commented
Feb 17, 2023

Copy link


Copy Markdown

Contributor
Disable this failing test on CoreCLR.
Tracking: #82252
@BruceForstall
BruceForstall
commented
Feb 17, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr libraries-jitstress
@ghost
ghost
commented
Feb 17, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-reflection

See info in area-owners.md if you want to be subscribed.
Issue Details
Disable this failing test on CoreCLR.
Tracking: #82252
Author:BruceForstall
Assignees:BruceForstall
Labels:
area-System.Reflection
Milestone:-
@azure-pipelines
azure-pipelinesBot
commented
Feb 17, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@BruceForstall
BruceForstall
commented
Feb 17, 2023

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib PTAL -- want to get a clean libraries stress pipeline
@steveharter
steveharter
commented
Feb 17, 2023

Copy link


Copy Markdown

Contributor
It looks like the "jitstress" tests are successful but there's still other failures -- so was disabling that test successful here?
@jkotas
jkotas
commented
Feb 17, 2023

Copy link


Copy Markdown

Member
#82325 has the actual fix for the problem.
If this is the only failing test, I am ok with disabling the test before the actual fix is merged.
Note that the failure only repros with tiered compilation disabled, or when the affected code is promoted to Tier 1.
@BruceForstall
BruceForstall
commented
Feb 17, 2023

Copy link


Copy Markdown

ContributorAuthor
If this is the only failing test, I am ok with disabling the test before the actual fix is merged.
I'd prefer to disable the test when this testing completes, then you can re-enable either with your fix or afterwards, after also running a clean libraries-jitstress pipeline.
fwiw, we should probably add a TieredCompilation=0 run to all libraries changes.
steveharter
steveharter
approved these changes
Feb 17, 2023
View reviewed changes
@stevehartersteveharter
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the real fix goes in, I'll revert this. Thanks
@jkotas
jkotas
commented
Feb 17, 2023

Copy link


Copy Markdown

Member
fwiw, we should probably add a TieredCompilation=0 run to all libraries changes.
I agree that it would be nice, but it is not where we are going with PR CI. We do not have enough budget to test all variants in PR CI. We are on a path to do less testing in PR CI and allow more issues to slip through that are only going to be found later in rolling runs.
@BruceForstall
BruceForstall
commented
Feb 18, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I've wondered whether the libraries tests PR testing should be TieredCompilation=0 and the outerloop rolling should be the default TieredCompilation=1. I wonder how many of the functions executed during libraries tests are compiled in Tier-0 versus Tier-1. It probably doesn't matter to the libraries team, but for the JIT team it does matter.
@BruceForstall
BruceForstall
merged commit 473e278
into
dotnet:mainFeb 18, 2023
@BruceForstall
BruceForstall
deleted the

DisableFunctionPointersTest

branch
February 18, 2023 00:17
jkotas added a commit
to jkotas/runtime
that referenced
this pull request
Feb 18, 2023
@jkotas
Revert "Disable System.Reflection.Tests.TypeDelegatorTests.FunctionPo…
8a1ff58
…inters (dotnet#82321)"
This reverts commit 473e278.

This was referenced Feb 18, 2023

Open


Closed

jkotas added a commit
that referenced
this pull request
Feb 18, 2023
@jkotas
Fix FnPtrTypeDesc::GetManagedClassObject (#82325)
2bd2ed9
* Fix FnPtrTypeDesc::GetManagedClassObject
The code was missing support for allocating RuntimeType objects on frozen heap
Fixes#82252
* Revert "Disable System.Reflection.Tests.TypeDelegatorTests.FunctionPointers (#82321)"
This reverts commit 473e278.
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 20, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes
@jkotasjkotasAwaiting requested review from jkotas

+1 more reviewer

@steveharterstevehartersteveharter approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@BruceForstallBruceForstall

Labels

area-System.Reflection

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@BruceForstall@steveharter@jkotas@jakobbotsch

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Disable System.Reflection.Tests.TypeDelegatorTests.FunctionPointers by BruceForstall · Pull Request #82321 · dotnet/runtime · GitHub
Skip to content
Disable System.Reflection.Tests.TypeDelegatorTests.FunctionPointers - #82321
Merged
BruceForstall merged 1 commit into
dotnet:mainfrom 
BruceForstall:DisableFunctionPointersTest
Feb 18, 2023
Merged
Disable System.Reflection.Tests.TypeDelegatorTests.FunctionPointers#82321
BruceForstall merged 1 commit into
dotnet:mainfrom 
BruceForstall:DisableFunctionPointersTest
Conversation
@BruceForstall
@BruceForstallBruceForstall
commented
Feb 17, 2023

Copy link


Copy Markdown

Contributor
Disable this failing test on CoreCLR.
Tracking: #82252
@BruceForstall
BruceForstall
commented
Feb 17, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr libraries-jitstress
@ghost
ghost
commented
Feb 17, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-reflection

See info in area-owners.md if you want to be subscribed.
Issue Details
Disable this failing test on CoreCLR.
Tracking: #82252
Author:BruceForstall
Assignees:BruceForstall
Labels:
area-System.Reflection
Milestone:-
@azure-pipelines
azure-pipelinesBot
commented
Feb 17, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@BruceForstall
BruceForstall
commented
Feb 17, 2023

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib PTAL -- want to get a clean libraries stress pipeline
@steveharter
steveharter
commented
Feb 17, 2023

Copy link


Copy Markdown

Contributor
It looks like the "jitstress" tests are successful but there's still other failures -- so was disabling that test successful here?
@jkotas
jkotas
commented
Feb 17, 2023

Copy link


Copy Markdown

Member
#82325 has the actual fix for the problem.
If this is the only failing test, I am ok with disabling the test before the actual fix is merged.
Note that the failure only repros with tiered compilation disabled, or when the affected code is promoted to Tier 1.
@BruceForstall
BruceForstall
commented
Feb 17, 2023

Copy link


Copy Markdown

ContributorAuthor
If this is the only failing test, I am ok with disabling the test before the actual fix is merged.
I'd prefer to disable the test when this testing completes, then you can re-enable either with your fix or afterwards, after also running a clean libraries-jitstress pipeline.
fwiw, we should probably add a TieredCompilation=0 run to all libraries changes.
steveharter
steveharter
approved these changes
Feb 17, 2023
View reviewed changes
@stevehartersteveharter
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the real fix goes in, I'll revert this. Thanks
@jkotas
jkotas
commented
Feb 17, 2023

Copy link


Copy Markdown

Member
fwiw, we should probably add a TieredCompilation=0 run to all libraries changes.
I agree that it would be nice, but it is not where we are going with PR CI. We do not have enough budget to test all variants in PR CI. We are on a path to do less testing in PR CI and allow more issues to slip through that are only going to be found later in rolling runs.
@BruceForstall
BruceForstall
commented
Feb 18, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I've wondered whether the libraries tests PR testing should be TieredCompilation=0 and the outerloop rolling should be the default TieredCompilation=1. I wonder how many of the functions executed during libraries tests are compiled in Tier-0 versus Tier-1. It probably doesn't matter to the libraries team, but for the JIT team it does matter.
@BruceForstall
BruceForstall
merged commit 473e278
into
dotnet:mainFeb 18, 2023
@BruceForstall
BruceForstall
deleted the

DisableFunctionPointersTest

branch
February 18, 2023 00:17
jkotas added a commit
to jkotas/runtime
that referenced
this pull request
Feb 18, 2023
@jkotas
Revert "Disable System.Reflection.Tests.TypeDelegatorTests.FunctionPo…
8a1ff58
…inters (dotnet#82321)"
This reverts commit 473e278.

This was referenced Feb 18, 2023

Open


Closed

jkotas added a commit
that referenced
this pull request
Feb 18, 2023
@jkotas
Fix FnPtrTypeDesc::GetManagedClassObject (#82325)
2bd2ed9
* Fix FnPtrTypeDesc::GetManagedClassObject
The code was missing support for allocating RuntimeType objects on frozen heap
Fixes#82252
* Revert "Disable System.Reflection.Tests.TypeDelegatorTests.FunctionPointers (#82321)"
This reverts commit 473e278.
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 20, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes
@jkotasjkotasAwaiting requested review from jkotas

+1 more reviewer

@steveharterstevehartersteveharter approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@BruceForstallBruceForstall

Labels

area-System.Reflection

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@BruceForstall@steveharter@jkotas@jakobbotsch

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Disable System.Reflection.Tests.TypeDelegatorTests.FunctionPointers by BruceForstall · Pull Request #82321 · dotnet/runtime · GitHub
Skip to content
Disable System.Reflection.Tests.TypeDelegatorTests.FunctionPointers - #82321
Merged
BruceForstall merged 1 commit into
dotnet:mainfrom 
BruceForstall:DisableFunctionPointersTest
Feb 18, 2023
Merged
Disable System.Reflection.Tests.TypeDelegatorTests.FunctionPointers#82321
BruceForstall merged 1 commit into
dotnet:mainfrom 
BruceForstall:DisableFunctionPointersTest
Conversation
@BruceForstall
@BruceForstallBruceForstall
commented
Feb 17, 2023

Copy link


Copy Markdown

Contributor
Disable this failing test on CoreCLR.
Tracking: #82252
@BruceForstall
BruceForstall
commented
Feb 17, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr libraries-jitstress
@ghost
ghost
commented
Feb 17, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-reflection

See info in area-owners.md if you want to be subscribed.
Issue Details
Disable this failing test on CoreCLR.
Tracking: #82252
Author:BruceForstall
Assignees:BruceForstall
Labels:
area-System.Reflection
Milestone:-
@azure-pipelines
azure-pipelinesBot
commented
Feb 17, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@BruceForstall
BruceForstall
commented
Feb 17, 2023

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib PTAL -- want to get a clean libraries stress pipeline
@steveharter
steveharter
commented
Feb 17, 2023

Copy link


Copy Markdown

Contributor
It looks like the "jitstress" tests are successful but there's still other failures -- so was disabling that test successful here?
@jkotas
jkotas
commented
Feb 17, 2023

Copy link


Copy Markdown

Member
#82325 has the actual fix for the problem.
If this is the only failing test, I am ok with disabling the test before the actual fix is merged.
Note that the failure only repros with tiered compilation disabled, or when the affected code is promoted to Tier 1.
@BruceForstall
BruceForstall
commented
Feb 17, 2023

Copy link


Copy Markdown

ContributorAuthor
If this is the only failing test, I am ok with disabling the test before the actual fix is merged.
I'd prefer to disable the test when this testing completes, then you can re-enable either with your fix or afterwards, after also running a clean libraries-jitstress pipeline.
fwiw, we should probably add a TieredCompilation=0 run to all libraries changes.
steveharter
steveharter
approved these changes
Feb 17, 2023
View reviewed changes
@stevehartersteveharter
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the real fix goes in, I'll revert this. Thanks
@jkotas
jkotas
commented
Feb 17, 2023

Copy link


Copy Markdown

Member
fwiw, we should probably add a TieredCompilation=0 run to all libraries changes.
I agree that it would be nice, but it is not where we are going with PR CI. We do not have enough budget to test all variants in PR CI. We are on a path to do less testing in PR CI and allow more issues to slip through that are only going to be found later in rolling runs.
@BruceForstall
BruceForstall
commented
Feb 18, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I've wondered whether the libraries tests PR testing should be TieredCompilation=0 and the outerloop rolling should be the default TieredCompilation=1. I wonder how many of the functions executed during libraries tests are compiled in Tier-0 versus Tier-1. It probably doesn't matter to the libraries team, but for the JIT team it does matter.
@BruceForstall
BruceForstall
merged commit 473e278
into
dotnet:mainFeb 18, 2023
@BruceForstall
BruceForstall
deleted the

DisableFunctionPointersTest

branch
February 18, 2023 00:17
jkotas added a commit
to jkotas/runtime
that referenced
this pull request
Feb 18, 2023
@jkotas
Revert "Disable System.Reflection.Tests.TypeDelegatorTests.FunctionPo…
8a1ff58
…inters (dotnet#82321)"
This reverts commit 473e278.

This was referenced Feb 18, 2023

Open


Closed

jkotas added a commit
that referenced
this pull request
Feb 18, 2023
@jkotas
Fix FnPtrTypeDesc::GetManagedClassObject (#82325)
2bd2ed9
* Fix FnPtrTypeDesc::GetManagedClassObject
The code was missing support for allocating RuntimeType objects on frozen heap
Fixes#82252
* Revert "Disable System.Reflection.Tests.TypeDelegatorTests.FunctionPointers (#82321)"
This reverts commit 473e278.
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 20, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes
@jkotasjkotasAwaiting requested review from jkotas

+1 more reviewer

@steveharterstevehartersteveharter approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@BruceForstallBruceForstall

Labels

area-System.Reflection

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@BruceForstall@steveharter@jkotas@jakobbotsch