') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Fix FnPtrTypeDesc::GetManagedClassObject by jkotas · Pull Request #82325 · dotnet/runtime · GitHub
Skip to content

Fix FnPtrTypeDesc::GetManagedClassObject - #82325

Merged
jkotas merged 2 commits into
dotnet:mainfrom
jkotas:issue-82252
Feb 18, 2023
Merged

Fix FnPtrTypeDesc::GetManagedClassObject#82325
jkotas merged 2 commits into
dotnet:mainfrom
jkotas:issue-82252

Conversation

@jkotas

@jkotasjkotas commented Feb 17, 2023

Copy link
Copy Markdown
Member

The code was missing support for allocating RuntimeType objects on frozen heap

Fixes#82252

@jkotas
jkotas requested a review from EgorBoFebruary 17, 2023 23:14
@jkotasjkotas mentioned this pull request Feb 17, 2023
Merged
steveharter
steveharter reviewed Feb 17, 2023
View reviewed changes
Comment threadsrc/coreclr/vm/typehandle.cpp Outdated

@stevehartersteveharterFeb 17, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed this -- prevents FPs from being moved during GC \ causing GC holes perhaps?

@jkotasjkotasFeb 17, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic in this method has to be in sync with what GetManagedClassObject returns. If it is not in sync, it will lead to all sorts of problems.

@ghostghost assigned jkotasFeb 17, 2023
@ghost

ghost commented Feb 17, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

The code was missing support for allocating RuntimeType objects on frozen heap

Fixes #82252

Author:jkotas
Assignees:-
Labels:

area-System.Reflection

Milestone:-

steveharter
steveharter reviewed Feb 17, 2023
View reviewed changes
Comment threadsrc/coreclr/vm/typedesc.cpp Outdated

@stevehartersteveharterFeb 17, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that this pattern was recently changed to support frozen heaps, so this copy-paste above was stale.

@jkotasjkotasFeb 17, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right

steveharter
steveharter approved these changes Feb 17, 2023
View reviewed changes

@stevehartersteveharter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkotas
Fix FnPtrTypeDesc::GetManagedClassObject
13f4e0e
The code was missing support for allocating RuntimeType objects on frozen heap
Fixesdotnet#82252
@jkotas
Revert "Disable System.Reflection.Tests.TypeDelegatorTests.FunctionPo…
8a1ff58
…inters (dotnet#82321)"
This reverts commit 473e278.
@BruceForstall

BruceForstall commented Feb 18, 2023

Copy link
Copy Markdown
Contributor

/azp run runtime-coreclr libraries-jitstress

@azure-pipelines

azure-pipelinesBot commented Feb 18, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Feb 18, 2023
Open
Closed
@jkotas
jkotas merged commit 2bd2ed9 into dotnet:mainFeb 18, 2023
@jkotas
jkotas deleted the issue-82252 branch February 18, 2023 03:17
@EgorBo

EgorBo commented Feb 18, 2023

Copy link
Copy Markdown
Member

Ouch, thanks! It turns out to be a FOH-related issue indeed 😞

@BruceForstallBruceForstall mentioned this pull request Feb 21, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@EgorBoEgorBoAwaiting requested review from EgorBo
1 more reviewer
@steveharterstevehartersteveharter approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jkotasjkotas

Labels

area-System.Reflection

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Assertion failed: GCHeapUtilities::GetGCHeap()->IsInFrozenSegment(obj)

4 participants

@jkotas@BruceForstall@EgorBo@steveharter