[browser] legacy JS interop optional via WasmEnableLegacyJsInterop - managed by pavelsavara · Pull Request #82826 · dotnet/runtime

pavelsavara · 2023-03-01T11:51:14Z

Allow opt-in trimming of legacy interop from managed libraries

added WasmEnableLegacyJsInterop MSBuild property. Default true for now.
added ILLink.Descriptors.LegacyJsInterop.xml and use is when WasmEnableLegacyJsInterop==true
Descriptors are the only thing which protects System.Runtime.InteropServices.JavaScript.LegacyExports from trimming
There is related change for native and JS parts [browser] legacy JS interop optional via WasmEnableLegacyJsInterop - native #82834
Fixed mono_wasm_pthread_on_pthread_attached linking issue by reverting small part of [browser] legacy JS interop optional via WasmEnableLegacyJsInterop - native #82834

This change doesn't disable the legacy interop for any scenario. There would be follow-up PR.

After Blazor change is merged, we could make the feature opt-out also for them.

See also discussion with @marek-safar

ghost · 2023-03-01T11:51:29Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Allow opt-in trimming of legacy interop from managed libraries by FeatureWasmLegacyJsInterop MSBuild property.

Based on discussion with @marek-safar here #79622 (comment)

Author:	pavelsavara
Assignees:	pavelsavara
Labels:	`arch-wasm`, `area-System.Runtime.InteropServices.JavaScript`
Milestone:	8.0.0

pavelsavara · 2023-03-03T14:43:52Z

/azp run runtime-wasm

azure-pipelines · 2023-03-03T14:44:01Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2023-03-03T15:56:23Z

/azp run runtime-wasm

azure-pipelines · 2023-03-03T15:56:34Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2023-03-03T19:44:06Z

/azp run runtime-wasm

azure-pipelines · 2023-03-03T19:44:16Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2023-03-03T23:25:45Z

/azp run runtime-wasm

azure-pipelines · 2023-03-03T23:25:58Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2023-03-06T18:00:01Z

CI failure NuGet-Migrations is is #80619
CI failure Parse Error: Invalid header value char is is #82880

~~undefined symbol: mono_wasm_pthread_on_pthread_attached needs to be solved here~~

pavelsavara · 2023-03-06T19:29:51Z

/azp run runtime-wasm

azure-pipelines · 2023-03-06T19:30:01Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2023-03-07T13:00:52Z

/azp run runtime-wasm

azure-pipelines · 2023-03-07T13:01:11Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2023-03-07T16:28:40Z

@radical please review, I think it's ready

radical

LGTM 👍

pavelsavara · 2023-03-08T06:30:33Z

/azp run runtime-wasm

azure-pipelines · 2023-03-08T06:30:44Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript labels Mar 1, 2023

pavelsavara added this to the 8.0.0 milestone Mar 1, 2023

pavelsavara requested review from maraf, radekdoulik and radical March 1, 2023 11:51

pavelsavara self-assigned this Mar 1, 2023

This was referenced Mar 1, 2023
Test failure: System.Security.Cryptography.X509Certificates.Tests.CertificateCreation.CertificateRequestChainTests/CreateChain_Hybrid #25979
Closed
System.Security.Cryptography.X509Certificates.Tests.ChainTests.BuildInvalidSignatureTwice failure #65448
Closed

steveisok mentioned this pull request Mar 1, 2023
System.Security.Cryptography.X509Certificates.Tests.ChainTests.BuildInvalidSignatureTwice failure #82837
Open

build-analysisBot mentioned this pull request Mar 1, 2023
Tracking issue for CI build timeouts #76454
Closed

pavelsavara force-pushed the browser_managed_legacy_interop branch from 5f07d4b to 9d86facCompare March 1, 2023 20:54

build-analysisBot mentioned this pull request Mar 1, 2023
NuGet failing with Response status code does not indicate success: 503 (Service Unavailable) dotnet/arcade#11723
Open
5 tasks

marek-safar reviewed Mar 2, 2023
View reviewed changes

Comment thread...eropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSObject.References.cs Outdated
Comment threadsrc/mono/wasm/build/WasmApp.targets Outdated

pavelsavara changed the title ~~[browser] managed legacy JS interop optional via FeatureWasmLegacyJsInterop~~[browser] legacy JS interop optional via WasmEnableLegacyJsInterop - managedMar 2, 2023

pavelsavara force-pushed the browser_managed_legacy_interop branch from 83c6417 to 82f8b47Compare March 3, 2023 14:43

runfoappBot mentioned this pull request Mar 3, 2023
Infra improvements for Helix #68176
Closed

build-analysisBot mentioned this pull request Mar 3, 2023
Alpine System.Net.Security.Tests failing because of "Cannot load library libgssapi_krb5.so.2" #82945
Closed

WasmEnableLegacyJsInterop
3afdb87

pavelsavara force-pushed the browser_managed_legacy_interop branch from 209942f to 3afdb87Compare March 3, 2023 19:35

pavelsavara marked this pull request as ready for review March 3, 2023 19:44

pavelsavara requested review from kg and lewing as code owners March 3, 2023 19:44

radical reviewed Mar 3, 2023
View reviewed changes

Comment threadsrc/mono/wasm/wasm.proj

wip
8f727ac

This was referenced Mar 3, 2023
IOException running NuGet-Migrations during tests in dotnet CLI first run #80619
Closed
Roslyn source generator crash on mono/linux/arm64 #81123
Closed

pavelsavara added 2 commits March 4, 2023 00:20

Merge branch 'main' into browser_managed_legacy_interop
5dc33ac

feedback
2ec51f3

pavelsavara requested a review from radical March 3, 2023 23:25

Merge branch 'main' into browser_managed_legacy_interop
1600368

revert back to USE_PTHREADS symbol
bce0f38

build-analysisBot mentioned this pull request Mar 7, 2023
AV during System.Net.Http.Functional.Tests on windows x86 #83098
Closed

radical approved these changes Mar 7, 2023
View reviewed changes

Comment thread...stem.Runtime.InteropServices.JavaScript/src/System.Runtime.InteropServices.JavaScript.csproj

feedback
0a9fbb0

pavelsavara mentioned this pull request Mar 8, 2023
[browser] cleanup before memory snapshot #83082
Merged

pavelsavara merged commit 6c836e8 into dotnet:mainMar 8, 2023

Tratcher mentioned this pull request Mar 17, 2023
[main] Update dependencies from dotnet/efcore dotnet/runtime dotnet/aspnetcore#47110
Merged

This was referenced Mar 18, 2023
[browser] partial reversal of PR #82826 #83637
Merged
[browser] fix trimming of LegacyExports with WasmEnableLegacyJsInterop#83664
Merged

maraf pushed a commit that referenced this pull request Mar 21, 2023
[browser] partial reversal of PR#82826(#83637)
6047cdc

ghost locked as resolved and limited conversation to collaborators Apr 7, 2023

pavelsavara deleted the browser_managed_legacy_interop branch September 2, 2024 15:30

Uh oh!

Conversation

pavelsavara commented Mar 1, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Mar 1, 2023

Uh oh!

Uh oh!

Uh oh!

pavelsavara commented Mar 3, 2023

Uh oh!

azure-pipelinesBot commented Mar 3, 2023

Uh oh!

pavelsavara commented Mar 3, 2023

Uh oh!

azure-pipelinesBot commented Mar 3, 2023

Uh oh!

pavelsavara commented Mar 3, 2023

Uh oh!

azure-pipelinesBot commented Mar 3, 2023

Uh oh!

Uh oh!

pavelsavara commented Mar 3, 2023

Uh oh!

azure-pipelinesBot commented Mar 3, 2023

Uh oh!

pavelsavara commented Mar 6, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pavelsavara commented Mar 6, 2023

Uh oh!

azure-pipelinesBot commented Mar 6, 2023

Uh oh!

pavelsavara commented Mar 7, 2023

Uh oh!

azure-pipelinesBot commented Mar 7, 2023

Uh oh!

pavelsavara commented Mar 7, 2023

Uh oh!

radical left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pavelsavara commented Mar 8, 2023

Uh oh!

azure-pipelinesBot commented Mar 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pavelsavara commented Mar 1, 2023•
edited
Loading

pavelsavara commented Mar 6, 2023•
edited
Loading