Skip to content

[browser] cleanup before memory snapshot - #83082

Merged
pavelsavara merged 3 commits into
dotnet:mainfrom
pavelsavara:browser_cleanup1
Mar 8, 2023
Merged

[browser] cleanup before memory snapshot#83082
pavelsavara merged 3 commits into
dotnet:mainfrom
pavelsavara:browser_cleanup1

Conversation

@pavelsavara

@pavelsavarapavelsavara commented Mar 7, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Split from #82049

  • moved get_preferred_icu_asset
  • moved TZ detection
  • moved runtimeHelpers.waitForDebugger
  • replaced anyModule with EmscriptenModuleInternal type
  • added runtimeHelpers.updateGlobalBufferAndViews
  • removed obsolete comments about blazor startup sequence
  • removed duplicate calls mono_wasm_init_diagnostics (also previously blazor startup path)

@pavelsavara
- moved get_preferred_icu_asset
64eb318
- moved TZ detection
- moved runtimeHelpers.waitForDebugger
- anyModule refactoring
- added runtimeHelpers.updateGlobalBufferAndViews
- removed obsolete comments about blazor startup sequence
- removed diplicate calls mono_wasm_init_diagnostics (also previously blazor startup path)
@pavelsavarapavelsavara added this to the 8.0.0 milestone Mar 7, 2023
@pavelsavarapavelsavara self-assigned this Mar 7, 2023
@ghost

ghost commented Mar 7, 2023

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Split from #82049

  • moved get_preferred_icu_asset
  • moved TZ detection
  • moved runtimeHelpers.waitForDebugger
  • anyModule refactoring
  • added runtimeHelpers.updateGlobalBufferAndViews
  • removed obsolete comments about blazor startup sequence
  • removed diplicate calls mono_wasm_init_diagnostics (also previously blazor startup path)
Author:pavelsavara
Assignees:pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript

Milestone:8.0.0

@pavelsavara

pavelsavara commented Mar 7, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Mar 7, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavarapavelsavara mentioned this pull request Mar 7, 2023
Merged
@pavelsavara
pavelsavara marked this pull request as ready for review March 7, 2023 12:08
kg
kg reviewed Mar 7, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/imports.ts Outdated
@build-analysisbuild-analysisBot mentioned this pull request Mar 7, 2023
Closed
@pavelsavara

pavelsavara commented Mar 7, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Mar 7, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

lambdageek
lambdageek approved these changes Mar 7, 2023
View reviewed changes

@lambdageeklambdageek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

threads and diagnostics looks ok

@pavelsavara

pavelsavara commented Mar 7, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Mar 7, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara

pavelsavara commented Mar 8, 2023

Copy link
Copy Markdown
MemberAuthor

CI failure undefined symbol: mono_wasm_pthread_on_pthread_attached is fixed here #82826
CI failure System.IO.IOException: 'NuGet-Migrations' is #80619

@pavelsavara
pavelsavara merged commit faa1d09 into dotnet:mainMar 8, 2023
@ghostghost locked as resolved and limited conversation to collaborators Apr 7, 2023
@pavelsavara
pavelsavara deleted the browser_cleanup1 branch September 2, 2024 15:30
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lambdageeklambdageeklambdageek approved these changes
@marafmarafmaraf approved these changes
@ilonatommyilonatommyilonatommy approved these changes
@lewinglewingAwaiting requested review from lewinglewing is a code owner
+1 more reviewer
@kgkgkg left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@pavelsavarapavelsavara

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScript

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@pavelsavara@kg@lambdageek@maraf@ilonatommy