Skip to content

JIT: Fix EQ/NE(relop/SETCC, 0) optimization - #83144

Merged
jakobbotsch merged 5 commits into
dotnet:mainfrom
jakobbotsch:fix-83140
Mar 9, 2023
Merged

JIT: Fix EQ/NE(relop/SETCC, 0) optimization#83144
jakobbotsch merged 5 commits into
dotnet:mainfrom
jakobbotsch:fix-83140

Conversation

@jakobbotsch

@jakobbotschjakobbotsch commented Mar 8, 2023

Copy link
Copy Markdown
Member
  • Actually check that the relop is EQ or NE
  • Retype the child relop/SETCC node if necessary

Fix#83140

@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 8, 2023
@ghostghost assigned jakobbotschMar 8, 2023
@ghost

ghost commented Mar 8, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #83140

Author:jakobbotsch
Assignees:-
Labels:

area-CodeGen-coreclr

Milestone:-

@jakobbotsch

Copy link
Copy Markdown
MemberAuthor

cc @dotnet/jit-contrib PTAL @TIHan

@jakobbotsch
jakobbotsch requested a review from TIHanMarch 9, 2023 09:59
@jakobbotsch
jakobbotsch merged commit a8c0d32 into dotnet:mainMar 9, 2023
@jakobbotsch
jakobbotsch deleted the fix-83140 branch March 9, 2023 21:02
@ghostghost locked as resolved and limited conversation to collaborators Apr 9, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fuzzlyn] x86 test failure involving field and division

2 participants

@jakobbotsch@BruceForstall