Skip to content

[release/7.0][mono] Use unsigned char when computing UTF8 string hashes - #83302

Merged
lambdageek merged 2 commits into
dotnet:release/7.0-stagingfrom
lambdageek:fix-gh-82187-net7
Mar 30, 2023
Merged

[release/7.0][mono] Use unsigned char when computing UTF8 string hashes#83302
lambdageek merged 2 commits into
dotnet:release/7.0-stagingfrom
lambdageek:fix-gh-82187-net7

Conversation

@lambdageek

@lambdageeklambdageek commented Mar 11, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Backport of #83273 to release/7.0

Resolves#82187
Resolves#78638

The corresponding 6.0 PR is #83303

Customer Impact

Resolves crashes in Release builds of Android apps that include classes with non-ASCII names that use AOT compilation.

Testing

Manual testing. New regression test.

Risk

Low. For code that uses ASCII names the hash code computation is unchanged.

@ghostghost added the area-VM-meta-mono label Mar 11, 2023
@ghostghost assigned lambdageekMar 11, 2023
@lambdageeklambdageek added the Servicing-consider Issue for next servicing release review label Mar 11, 2023
@lambdageeklambdageek added this to the 7.0.x milestone Mar 11, 2023
@lambdageek

lambdageek commented Mar 11, 2023

Copy link
Copy Markdown
MemberAuthor

/backport to release/6.0

@github-actions

github-actionsBot commented Mar 11, 2023

Copy link
Copy Markdown
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/4392646513

@github-actionsgithub-actionsBot mentioned this pull request Mar 11, 2023
Merged
@lambdageek

This comment was marked as outdated.

Sign in to view
@azure-pipelines

This comment was marked as resolved.

Sign in to view
@build-analysisbuild-analysisBot mentioned this pull request Mar 11, 2023
Closed
@lambdageek

lambdageek commented Mar 13, 2023

Copy link
Copy Markdown
MemberAuthor

/backport to release/6.0

@github-actions

github-actionsBot commented Mar 13, 2023

Copy link
Copy Markdown
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/4406095701

@build-analysisbuild-analysisBot mentioned this pull request Mar 13, 2023
Closed
@lambdageek

lambdageek commented Mar 13, 2023

Copy link
Copy Markdown
MemberAuthor

/backport to release/6.0

@github-actions

github-actionsBot commented Mar 13, 2023

Copy link
Copy Markdown
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/4407943691

@build-analysisbuild-analysisBot mentioned this pull request Mar 13, 2023
Closed
@carlossanlop

carlossanlop commented Mar 13, 2023

Copy link
Copy Markdown
Contributor

Hey @lambdageek - Are you intending to get this approved for the April servicing release? Code-complete is today.

@lambdageek

lambdageek commented Mar 13, 2023

Copy link
Copy Markdown
MemberAuthor

@carlossanlop I don't think we'll make it. Let's try for the next one

@lambdageek
[mono] Use unsigned char when computing UTF8 string hashes
3544937
The C standard does not specify whether `char` is signed or unsigned,
it is implementation defined.
Apparently Android aarch64 makes a different choice than other
platforms (at least macOS arm64 and Windows x64 give different
results).
Mono uses `mono_metadata_str_hash` in the AOT compiler and AOT runtime
to optimize class name lookup. As a result, classes whose names
include UTF-8 continuation bytes (with the high bit = 1) will hash
differently in the AOT compiler and on the device.
Fixesdotnet#82187Fixesdotnet#78638
@lambdageek
Add regression test
064e69d
@leecowleecow removed the Servicing-consider Issue for next servicing release review label Mar 14, 2023
@leecowleecow added the Servicing-approved Approved for servicing release label Mar 14, 2023
@leecowleecow modified the milestones: 7.0.x, 7.0.5Mar 14, 2023
@lambdageek

lambdageek commented Mar 14, 2023

Copy link
Copy Markdown
MemberAuthor

@vargaz review plz. And also #83303

@lambdageek
lambdageek changed the base branch from release/7.0 to release/7.0-stagingMarch 28, 2023 18:23
@lambdageek

lambdageek commented Mar 28, 2023

Copy link
Copy Markdown
MemberAuthor

@vargaz@thaystg could I get a review for this PR and for #83303

@carlossanlop

carlossanlop commented Mar 28, 2023

Copy link
Copy Markdown
Contributor

I'm retargeting this PR to the new release/7.0-staging branch, which is the one that we will use from now on for servicing fixes.

Repo maintainers will now be allowed to merge their own servicing PR as long as it meets the requirements:

  • It is appoved by Tactics (signaled by adding the Servicing-approved label).
  • It's signed-off by an area owner.
  • The CI is green, or the failures are investigated as unrelated.
  • And if the PR touches an OOB package, the necessary OOB authoring changes are added.

The new process is described here: runtime/docs/project/library-servicing.md.

The infra team will be actively monitoring servicing PRs to ensure all requirements are met and to help with any issues.

Let me know if you have any questions.

@carlossanlop

carlossanlop commented Mar 28, 2023

Copy link
Copy Markdown
Contributor

I see you already retargeted it, @lambdageek. You're awesome.

@build-analysisbuild-analysisBot mentioned this pull request Mar 29, 2023
Closed
@lambdageeklambdageek added Servicing-approved Approved for servicing release and removed Servicing-approved Approved for servicing release labels Mar 30, 2023
@lambdageek
lambdageek merged commit 05038f9 into dotnet:release/7.0-stagingMar 30, 2023
@ghostghost locked as resolved and limited conversation to collaborators Apr 29, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thaystgthaystgthaystg approved these changes
+1 more reviewer
@vargazvargazvargaz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lambdageeklambdageek

Labels

area-VM-meta-monoServicing-approvedApproved for servicing release

Projects

None yet

Milestone

7.0.5

Development

Successfully merging this pull request may close these issues.

6 participants

@lambdageek@carlossanlop@vargaz@thaystg@leecow@teo-tsirpanis