Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] [mono] Use unsigned char when computing UTF8 string hashes - #83303
Merged
lambdageek merged 2 commits intoMar 30, 2023
Merged
Conversation
github-actionsBot
requested review from
lambdageek, thaystg and vargaz
as code ownersMarch 11, 2023 14:06
github-actionsBotforce-pushed
the
backport/pr-83302-to-release/6.0
branch
from
March 13, 2023 14:35
94292ee to
7b786c2CompareContributor
Hello - Today is code-complete day for merging changes that should go into the April servicing release. Todos:
If it's not critical to get it merged in the April release, we can wait until next month. |
github-actionsBotforce-pushed
the
backport/pr-83302-to-release/6.0
branch
from
March 13, 2023 17:48
7b786c2 to
0e4ca74CompareThe C standard does not specify whether `char` is signed or unsigned, it is implementation defined. Apparently Android aarch64 makes a different choice than other platforms (at least macOS arm64 and Windows x64 give different results). Mono uses `mono_metadata_str_hash` in the AOT compiler and AOT runtime to optimize class name lookup. As a result, classes whose names include UTF-8 continuation bytes (with the high bit = 1) will hash differently in the AOT compiler and on the device. Fixes#82187Fixes#78638
lambdageekforce-pushed
the
backport/pr-83302-to-release/6.0
branch
from
March 14, 2023 14:24
0e4ca74 to
e6dd087Comparethaystg
approved these changes
Mar 28, 2023
vargaz
approved these changes
Mar 28, 2023
This was referenced Mar 28, 2023
carlossanlop
commented
Mar 30, 2023
Contributor
@lambdageek not sure if you saw but the new check-service-labels CI leg was stuck because there were some weird problems with GitHub Actions yesterday. The fix is to remove and readd the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #83273 to release/6.0
Resolves#82187
Resolves#78638
The corresponding 7.0 PR is #83302
Customer Impact
Resolves crashes in Release builds of Android apps that include classes with non-ASCII names that use AOT compilation.
Testing
Manual testing. New regression test.
Risk
Low. For code that uses ASCII names the hash code computation is unchanged.