Simplify target to enable config binding src generator from NuGet package, ensure it runs for all TFMs, and rename enabling property

[layomia]

• Renders Consolidate packaging targets to handle multi-targeting & off-by-default source generators #83532 obsolete.
• Renames enabling property from EnableMicrosoftExtensionsConfigurationBinderGenerator to EnableConfigurationBindingGenerator (fyi @eerhardt).

[ghost]

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

---

• Renders Consolidate packaging targets to handle multi-targeting & off-by-default source generators #83532 obsolete.
• Renames enabling property from EnableMicrosoftExtensionsConfigurationBinderGenerator to EnableConfigurationBindingGenerator (fyi @eerhardt).

Author:	layomia
Assignees:	layomia
Labels:	area-Extensions-Configuration
Milestone:	8.0.0

[ericstj]

LGTM - just a non-blocking nit.

[ericstj]

Suggested change

	<ContentInclude="buildTransitive\$(MSBuildProjectName).*"
	<ContentInclude="buildTransitive\$(PackageId).targets"

nit: I tend to avoid a wildcard unless it's needed since it hurts evaluation perf. nit: $(PackageId) should be used rather than $(MSBuildProjectName) since they can differ, but the PackageID is the one that needs to match.

[eerhardt]

Maybe we could update the docs (and the other places that do this as well) to be consistent across the repo?

runtime/docs/coding-guidelines/libraries-packaging.md

Lines 130 to 137 in 4f4dd93

	```xml
	<ItemGroup>
	<ContentInclude="buildTransitive\$(MSBuildProjectName).*"
	PackagePath="buildTransitive\netstandard2.0\;
	buildTransitive\$(NetFrameworkMinimum)\;
	buildTransitive\$(NetCoreAppMinimum)\" />
	</ItemGroup>
	```

I believe the * is there to support both .props and .targets. But @ViktorHofer would know for sure.

[layomia]

The AddNETStandardCompatErrorFileForPackaging target infra to emit a warning for unsupported package-consuming TFMs causes the analyzer removal target to get dropped for unsupported TFMs (e.g. net461 and netcoreapp3.1)

runtime/eng/packaging.targets

Line 232 in 15c7022

<TargetName="AddNETStandardCompatErrorFileForPackaging"

This is undesirable and can lead to undefined behavior. The latest commit 9eab1ce fixes this issue, enforcing that the removal target runs for all TFMs & also emitting the compat warning for unsupported TFMs. This fix is hardcoded for now. We need to also fix it for the other source-generator targets for multi-targeting and disabling, and come up with the right templating across all the targets & packages. cc @ViktorHofer

[ViktorHofer]

Please change this to '$(SuppressTfmSupportBuildWarnings)' != 'true'. While at it, can you please also change that here:

runtime/eng/packaging.targets

Line 207 in c8ec3fd

Condition="'%24(SuppressTfmSupportBuildWarnings)' == ''">

[ViktorHofer]

Please file a tracking issue to discuss how to support both the NETStandardCompatError infrastructure and target framework agnostic msbuild infrastructure.

[layomia]

Here you go: #84570.

[ViktorHofer]

LGTM aside from two comments.