Skip to content

Add config binder generator to ASP.NET Core transport pack - #84436

Merged
layomia merged 1 commit into
dotnet:mainfrom
layomia:binder-gen-transport-pack
Apr 18, 2023
Merged

Add config binder generator to ASP.NET Core transport pack#84436
layomia merged 1 commit into
dotnet:mainfrom
layomia:binder-gen-transport-pack

Conversation

@layomia

@layomialayomia commented Apr 6, 2023

Copy link
Copy Markdown
Contributor

@layomialayomia added this to the 8.0.0 milestone Apr 6, 2023
@layomialayomia self-assigned this Apr 6, 2023
@ghost

ghost commented Apr 6, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

Related #84379, dotnet/sdk#31654.
FYI @eerhardt@captainsafia

Author:layomia
Assignees:layomia
Labels:

area-Extensions-Configuration

Milestone:8.0.0

ericstj
ericstj approved these changes Apr 6, 2023
View reviewed changes

@ericstjericstj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - babysit this one when it hits ASP.NET by letting @wtgodbe know to ping you if it needs help when it hits ASP.NET Core. You might need to manually replicate the exclusion in ASP.NET.

@layomialayomia added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Apr 7, 2023
@layomia

layomia commented Apr 7, 2023

Copy link
Copy Markdown
ContributorAuthor

Blocked on dotnet/sdk#31654.

@layomialayomia mentioned this pull request Apr 18, 2023
Merged
@layomia

layomia commented Apr 18, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

The enabling mechanism has been added to the SDK in dotnet/sdk#31654.

cc @dotnet/aspnet-build @eerhardt I'll be following to see if there are any issues with ingesting the generator via this transport pack. If needed we could remove the analyzer manually in your build.

@layomialayomia removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Apr 18, 2023
@layomia
layomia merged commit 2a0f56c into dotnet:mainApr 18, 2023
@wtgodbewtgodbe mentioned this pull request Apr 19, 2023
Merged
@layomialayomia added the source-generator Indicates an issue with a source generator feature label May 17, 2023
@ghostghost locked as resolved and limited conversation to collaborators Jun 17, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ViktorHoferViktorHoferViktorHofer approved these changes
@ericstjericstjericstj approved these changes
@tarekghtarekghtarekgh approved these changes

Assignees

@layomialayomia

Labels

area-Extensions-Configurationsource-generatorIndicates an issue with a source generator feature

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@layomia@ViktorHofer@ericstj@tarekgh