Skip to content

Fix enterprise linux build - #84795

Merged
rzikm merged 4 commits into
dotnet:mainfrom
sbomer:fixEnterpriseLinuxBuild
Apr 21, 2023
Merged

Fix enterprise linux build#84795
rzikm merged 4 commits into
dotnet:mainfrom
sbomer:fixEnterpriseLinuxBuild

Conversation

@sbomer

@sbomersbomer commented Apr 13, 2023

Copy link
Copy Markdown
Member

Ensure a recent lld is available on the build host. See dotnet/dotnet-buildtools-prereqs-docker#843.

Attempting to fix the issue mentioned in #84148 (comment).

Fixes#85035

Ensure a recent lld is available on the build host
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Ensure a recent lld is available on the build host.

Attempting to fix the issue mentioned in #84148 (comment).

Author:sbomer
Assignees:sbomer
Labels:

area-System.Net.Security

Milestone:-

@sbomer

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-libraries enterprise-linux

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

As it is now installed in the ubuntu-22.04 image
@rzikm

Copy link
Copy Markdown
Member
 System.Net.Security.Enterprise.Tests.NegotiateStreamLoopbackTest.StreamToStream_InvalidAuthentication_Failure(creds: NetworkCredential { Domain = "", Password = "PLACEHOLDERwong", SecurePassword = SecureString { Length = 15 }, UserName = "user1" }, target: "HOST/localhost") [FAIL]
System.Security.Authentication.AuthenticationException : Authentication failed, see inner exception.
---- System.ComponentModel.Win32Exception : GSSAPI operation failed with error - Unspecified GSS failure. Minor code may provide more information (Crypto routine failure).

does perhaps Ubuntu 22 come with a different libgss version than Ubuntu 18?

@sbomer

Copy link
Copy Markdown
MemberAuthor

I believe this is the same issue hit in #67353. Ubuntu 22.04 comes with openssl 3, which doesn't include md4 (except as a legacy provider) that gss-ntlmssp depends on. gss-ntlmssp was updated with a fix that lets it use the legacy provider, but the fix was released in version 1.1.0, while ubuntu 22.04 only has 0.7.0 available. Even the latest Ubuntu (22.10) only has 1.0.0.

Would it be acceptable to enable the legacy provider in the openssl config for this test (this workaround: #67353 (comment))? @wfurt

@rzikm

Copy link
Copy Markdown
Member

Sounds reasonable to me

@sbomer
sbomer marked this pull request as ready for review April 20, 2023 18:36
@sbomer
sbomer requested review from rzikm and wfurtApril 20, 2023 18:36

@rzikmrzikm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTLM

@rzikm
rzikm merged commit ab2b80d into dotnet:mainApr 21, 2023
@wfurt

Copy link
Copy Markdown
Member

I guess it is too late but I'm wondering if we could just jump to 20.04 to avoid all the OpenSSL 3 mess.

@ghostghost locked as resolved and limited conversation to collaborators May 21, 2023
@karelzkarelz added this to the 8.0.0 milestone May 27, 2023
@sbomer
sbomer deleted the fixEnterpriseLinuxBuild branch November 3, 2023 18:37
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

System.Net.Http.Enterprise.Tests build failing in CI

4 participants

@sbomer@rzikm@wfurt@karelz