') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Attempt to fix stress builds by antonfirsov · Pull Request #85342 · dotnet/runtime · GitHub
Skip to content

Attempt to fix stress builds - #85342

Merged
antonfirsov merged 3 commits into
dotnet:mainfrom
antonfirsov:fix-libraries-sdk.linux.Dockerfile
Apr 26, 2023
Merged

Attempt to fix stress builds#85342
antonfirsov merged 3 commits into
dotnet:mainfrom
antonfirsov:fix-libraries-sdk.linux.Dockerfile

Conversation

@antonfirsov

@antonfirsovantonfirsov commented Apr 25, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Fix#85338, by switching to centos-stream8 as recommended in #85342 (comment).

This also addresses the concerns from https://github.com/dotnet/runtime/pull/84793/files#r1174173867.

@ghost

ghost commented Apr 25, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

An attempt to fix #85338, based on #84795 and also try to switch the distro as discussed in https://github.com/dotnet/runtime/pull/84793/files#r1174173867.

Author:antonfirsov
Assignees:-
Labels:

area-System.Net.Http

Milestone:-

@azure-pipelines

This comment was marked as resolved.

Sign in to view
2 similar comments
@azure-pipelines

This comment was marked as resolved.

Sign in to view
@azure-pipelines

This comment was marked as resolved.

Sign in to view
@antonfirsov
antonfirsov marked this pull request as draft April 25, 2023 18:29
@build-analysisbuild-analysisBot mentioned this pull request Apr 25, 2023
Closed
@azure-pipelines

azure-pipelinesBot commented Apr 25, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines

This comment was marked as resolved.

Sign in to view
sbomer
sbomer reviewed Apr 26, 2023
View reviewed changes
Comment threadeng/docker/libraries-sdk.linux.Dockerfile Outdated
Comment threadeng/docker/libraries-sdk.linux.Dockerfile Outdated
This was referenced Apr 26, 2023
Closed
Closed
@rzikm

rzikm commented Apr 26, 2023•
edited
Loading

Copy link
Copy Markdown
Member

As sbomer commented, the issue is missing lld linker, either we need to update the docker image to include lld or switch to one which has it. The OpenSSL config changes are not necessary here. They were needed in the other PR because Ubuntu 22.04 has OpenSSL 3 which disabled some legacy functionality required by libgssl (needed for Kerberos stuff)

@antonfirsov

antonfirsov commented Apr 26, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-libraries stress-http

@azure-pipelines

azure-pipelinesBot commented Apr 26, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@antonfirsov

antonfirsov commented Apr 26, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-libraries stress-ssl

@azure-pipelines

azure-pipelinesBot commented Apr 26, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@build-analysisbuild-analysisBot mentioned this pull request Apr 26, 2023
Closed
@antonfirsov
antonfirsov marked this pull request as ready for review April 26, 2023 13:59
@antonfirsov

antonfirsov commented Apr 26, 2023

Copy link
Copy Markdown
ContributorAuthor

@sbomer@rzikm thanks for the clarification! I missed the fact the OpenSSL hack has nothing to do with the core issue (lack of lld).

Switching to centos-stream8 fixed these pipelines, so this is ready for review now.

@antonfirsovantonfirsov mentioned this pull request Apr 26, 2023
Merged
@antonfirsov
antonfirsov requested a review from a teamApril 26, 2023 14:05
@antonfirsov
antonfirsov merged commit 678b4c8 into dotnet:mainApr 26, 2023
@ghostghost locked as resolved and limited conversation to collaborators May 27, 2023
@karelzkarelz added this to the 8.0.0 milestone May 27, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sbomersbomersbomer approved these changes
@wfurtwfurtwfurt approved these changes
@MihaZupanMihaZupanMihaZupan approved these changes

Assignees

@antonfirsovantonfirsov

Labels

area-System.Net.Http

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

[HttpStress] [SslStress] Linux stress test builds are broken

6 participants

@antonfirsov@rzikm@sbomer@wfurt@MihaZupan@karelz