Skip to content

Set BuildAsStandalone for gcstress test builds - #85284

Closed
markples wants to merge 10 commits into
dotnet:mainfrom
markples:gcstress-standalone
Closed

Set BuildAsStandalone for gcstress test builds#85284
markples wants to merge 10 commits into
dotnet:mainfrom
markples:gcstress-standalone

Conversation

@markples

@markplesmarkples commented Apr 25, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@ghostghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 25, 2023
@ghostghost assigned markplesApr 25, 2023
@markplesmarkples added test-enhancement Improvements of test source code and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Apr 25, 2023
@markples

This comment was marked as duplicate.

Sign in to view
@azure-pipelines

This comment was marked as duplicate.

Sign in to view
@markples
markplesforce-pushed the gcstress-standalone branch from f479401 to 7de7262CompareApril 25, 2023 00:14
@markples

markples commented Apr 25, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-coreclr gcstress0x3-gcstress0xc

@azure-pipelines

azure-pipelinesBot commented Apr 25, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@markplesmarkples mentioned this pull request Apr 25, 2023
Merged
This was referenced Apr 25, 2023
Open
Closed
Closed
@markples

markples commented Apr 26, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-coreclr gcstress0x3-gcstress0xc

@azure-pipelines

azure-pipelinesBot commented Apr 26, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@markples

markples commented Apr 26, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-coreclr gcstress0x3-gcstress0xc

@azure-pipelines

azure-pipelinesBot commented Apr 26, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Apr 26, 2023
Closed
Closed
Closed
@markples

markples commented Apr 27, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-coreclr gcstress0x3-gcstress0xc

@azure-pipelines

azure-pipelinesBot commented Apr 27, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@markples

markples commented May 2, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-coreclr gcstress0x3-gcstress0xc

@azure-pipelines

azure-pipelinesBot commented May 2, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This was referenced May 2, 2023
Closed
Closed
Closed
@markples

markples commented May 2, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-coreclr gcstress0x3-gcstress0xc

@azure-pipelines

azure-pipelinesBot commented May 2, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@markples

markples commented May 3, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-coreclr gcstress0x3-gcstress0xc

@azure-pipelines

azure-pipelinesBot commented May 3, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@markples

markples commented May 5, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

I'm going back to trying to get merging to work better (e.g., #85040). This has been painful and isn't there yet. There are a few fundamental points:

  • A test needs to change between OutputType Exe vs Library for a merged test vs one with RequireProcessIsolation (or in BuildAsStandalone mode). While theoretically this shouldn't be different between RPI and BAS, I've hit a lot of issues messing around with it. This is how we've ended up in a situation where RPI works (only) when marked on tests and BAS works (only) as a global setting. This is relevant to the idea below of trying to run a few merged groups in a BAS build.
  • We have some huge projects (such as JIT\HardwareIntrinsics\Arm\AdvSimd.Arm64\AdvSimd.Arm64_r.csproj). In merged test groups, the individual tests within this project can be striped to multiple helix jobs. In the old style, this test has a single entry point that runs everything, and it times out under gcstress.

I don't think investing in striping in BAS is the right direction as the main reason for BAS is to be simpler than merged groups, and I don't think investing in special cases in the msbuild BAS support is the right thing to do (or then maintain). Maybe after efforts fail again with merged groups I'll change my mind again.

@markplesmarkples closed this May 5, 2023
@ghostghost locked as resolved and limited conversation to collaborators Jun 5, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@markplesmarkples

Labels

test-enhancementImprovements of test source code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@markples
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Set BuildAsStandalone for gcstress test builds by markples · Pull Request #85284 · dotnet/runtime · GitHub
Skip to content
Set BuildAsStandalone for gcstress test builds - #85284
Closed
markples wants to merge 10 commits into
dotnet:mainfrom 
markples:gcstress-standalone
Closed
Set BuildAsStandalone for gcstress test builds#85284
markples wants to merge 10 commits into
dotnet:mainfrom 
markples:gcstress-standalone
Conversation
@markples
@markplesmarkples
commented
Apr 25, 2023

Copy link


Copy Markdown

Contributor
 No description provided. 
@ghostghost
added
the 
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
label
Apr 25, 2023
@ghostghost
assigned markplesApr 25, 2023
@markplesmarkples
added

test-enhancement
Improvements of test source code
and removed

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
Apr 25, 2023
@markples

This comment was marked as duplicate.

Sign in to view
@azure-pipelines

This comment was marked as duplicate.

Sign in to view
@markples
markplesforce-pushed
the
gcstress-standalone
branch
from
f479401 to
7de7262CompareApril 25, 2023 00:14
@markples
markples
commented
Apr 25, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
Apr 25, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@markplesmarkples
mentioned this pull request
Apr 25, 2023
 Merged


This was referenced Apr 25, 2023

Open


Closed


Closed

@markples
markples
commented
Apr 26, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
Apr 26, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@markples
markples
commented
Apr 26, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
Apr 26, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Apr 26, 2023

Closed


Closed


Closed

@markples
markples
commented
Apr 27, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
Apr 27, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@markples
markples
commented
May 2, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
May 2, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced May 2, 2023

Closed


Closed


Closed

@markples
markples
commented
May 2, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
May 2, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@markples
markples
commented
May 3, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
May 3, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@markples
markples
commented
May 5, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I'm going back to trying to get merging to work better (e.g., #85040). This has been painful and isn't there yet. There are a few fundamental points:
  • A test needs to change between OutputType Exe vs Library for a merged test vs one with RequireProcessIsolation (or in BuildAsStandalone mode). While theoretically this shouldn't be different between RPI and BAS, I've hit a lot of issues messing around with it. This is how we've ended up in a situation where RPI works (only) when marked on tests and BAS works (only) as a global setting. This is relevant to the idea below of trying to run a few merged groups in a BAS build.
  • We have some huge projects (such as JIT\HardwareIntrinsics\Arm\AdvSimd.Arm64\AdvSimd.Arm64_r.csproj). In merged test groups, the individual tests within this project can be striped to multiple helix jobs. In the old style, this test has a single entry point that runs everything, and it times out under gcstress.
I don't think investing in striping in BAS is the right direction as the main reason for BAS is to be simpler than merged groups, and I don't think investing in special cases in the msbuild BAS support is the right thing to do (or then maintain). Maybe after efforts fail again with merged groups I'll change my mind again.
@markplesmarkples
closed this
May 5, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Jun 5, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


No reviews


Assignees

@markplesmarkples

Labels

test-enhancementImprovements of test source code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@markples

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Set BuildAsStandalone for gcstress test builds by markples · Pull Request #85284 · dotnet/runtime · GitHub
Skip to content
Set BuildAsStandalone for gcstress test builds - #85284
Closed
markples wants to merge 10 commits into
dotnet:mainfrom 
markples:gcstress-standalone
Closed
Set BuildAsStandalone for gcstress test builds#85284
markples wants to merge 10 commits into
dotnet:mainfrom 
markples:gcstress-standalone
Conversation
@markples
@markplesmarkples
commented
Apr 25, 2023

Copy link


Copy Markdown

Contributor
 No description provided. 
@ghostghost
added
the 
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
label
Apr 25, 2023
@ghostghost
assigned markplesApr 25, 2023
@markplesmarkples
added

test-enhancement
Improvements of test source code
and removed

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
Apr 25, 2023
@markples

This comment was marked as duplicate.

Sign in to view
@azure-pipelines

This comment was marked as duplicate.

Sign in to view
@markples
markplesforce-pushed
the
gcstress-standalone
branch
from
f479401 to
7de7262CompareApril 25, 2023 00:14
@markples
markples
commented
Apr 25, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
Apr 25, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@markplesmarkples
mentioned this pull request
Apr 25, 2023
 Merged


This was referenced Apr 25, 2023

Open


Closed


Closed

@markples
markples
commented
Apr 26, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
Apr 26, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@markples
markples
commented
Apr 26, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
Apr 26, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Apr 26, 2023

Closed


Closed


Closed

@markples
markples
commented
Apr 27, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
Apr 27, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@markples
markples
commented
May 2, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
May 2, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced May 2, 2023

Closed


Closed


Closed

@markples
markples
commented
May 2, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
May 2, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@markples
markples
commented
May 3, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
May 3, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@markples
markples
commented
May 5, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I'm going back to trying to get merging to work better (e.g., #85040). This has been painful and isn't there yet. There are a few fundamental points:
  • A test needs to change between OutputType Exe vs Library for a merged test vs one with RequireProcessIsolation (or in BuildAsStandalone mode). While theoretically this shouldn't be different between RPI and BAS, I've hit a lot of issues messing around with it. This is how we've ended up in a situation where RPI works (only) when marked on tests and BAS works (only) as a global setting. This is relevant to the idea below of trying to run a few merged groups in a BAS build.
  • We have some huge projects (such as JIT\HardwareIntrinsics\Arm\AdvSimd.Arm64\AdvSimd.Arm64_r.csproj). In merged test groups, the individual tests within this project can be striped to multiple helix jobs. In the old style, this test has a single entry point that runs everything, and it times out under gcstress.
I don't think investing in striping in BAS is the right direction as the main reason for BAS is to be simpler than merged groups, and I don't think investing in special cases in the msbuild BAS support is the right thing to do (or then maintain). Maybe after efforts fail again with merged groups I'll change my mind again.
@markplesmarkples
closed this
May 5, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Jun 5, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


No reviews


Assignees

@markplesmarkples

Labels

test-enhancementImprovements of test source code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@markples

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Set BuildAsStandalone for gcstress test builds by markples · Pull Request #85284 · dotnet/runtime · GitHub
Skip to content
Set BuildAsStandalone for gcstress test builds - #85284
Closed
markples wants to merge 10 commits into
dotnet:mainfrom 
markples:gcstress-standalone
Closed
Set BuildAsStandalone for gcstress test builds#85284
markples wants to merge 10 commits into
dotnet:mainfrom 
markples:gcstress-standalone
Conversation
@markples
@markplesmarkples
commented
Apr 25, 2023

Copy link


Copy Markdown

Contributor
 No description provided. 
@ghostghost
added
the 
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
label
Apr 25, 2023
@ghostghost
assigned markplesApr 25, 2023
@markplesmarkples
added

test-enhancement
Improvements of test source code
and removed

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
Apr 25, 2023
@markples

This comment was marked as duplicate.

Sign in to view
@azure-pipelines

This comment was marked as duplicate.

Sign in to view
@markples
markplesforce-pushed
the
gcstress-standalone
branch
from
f479401 to
7de7262CompareApril 25, 2023 00:14
@markples
markples
commented
Apr 25, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
Apr 25, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@markplesmarkples
mentioned this pull request
Apr 25, 2023
 Merged


This was referenced Apr 25, 2023

Open


Closed


Closed

@markples
markples
commented
Apr 26, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
Apr 26, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@markples
markples
commented
Apr 26, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
Apr 26, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Apr 26, 2023

Closed


Closed


Closed

@markples
markples
commented
Apr 27, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
Apr 27, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@markples
markples
commented
May 2, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
May 2, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced May 2, 2023

Closed


Closed


Closed

@markples
markples
commented
May 2, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
May 2, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@markples
markples
commented
May 3, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
May 3, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@markples
markples
commented
May 5, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I'm going back to trying to get merging to work better (e.g., #85040). This has been painful and isn't there yet. There are a few fundamental points:
  • A test needs to change between OutputType Exe vs Library for a merged test vs one with RequireProcessIsolation (or in BuildAsStandalone mode). While theoretically this shouldn't be different between RPI and BAS, I've hit a lot of issues messing around with it. This is how we've ended up in a situation where RPI works (only) when marked on tests and BAS works (only) as a global setting. This is relevant to the idea below of trying to run a few merged groups in a BAS build.
  • We have some huge projects (such as JIT\HardwareIntrinsics\Arm\AdvSimd.Arm64\AdvSimd.Arm64_r.csproj). In merged test groups, the individual tests within this project can be striped to multiple helix jobs. In the old style, this test has a single entry point that runs everything, and it times out under gcstress.
I don't think investing in striping in BAS is the right direction as the main reason for BAS is to be simpler than merged groups, and I don't think investing in special cases in the msbuild BAS support is the right thing to do (or then maintain). Maybe after efforts fail again with merged groups I'll change my mind again.
@markplesmarkples
closed this
May 5, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Jun 5, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


No reviews


Assignees

@markplesmarkples

Labels

test-enhancementImprovements of test source code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@markples

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Set BuildAsStandalone for gcstress test builds by markples · Pull Request #85284 · dotnet/runtime · GitHub
Skip to content
Set BuildAsStandalone for gcstress test builds - #85284
Closed
markples wants to merge 10 commits into
dotnet:mainfrom 
markples:gcstress-standalone
Closed
Set BuildAsStandalone for gcstress test builds#85284
markples wants to merge 10 commits into
dotnet:mainfrom 
markples:gcstress-standalone
Conversation
@markples
@markplesmarkples
commented
Apr 25, 2023

Copy link


Copy Markdown

Contributor
 No description provided. 
@ghostghost
added
the 
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
label
Apr 25, 2023
@ghostghost
assigned markplesApr 25, 2023
@markplesmarkples
added

test-enhancement
Improvements of test source code
and removed

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
Apr 25, 2023
@markples

This comment was marked as duplicate.

Sign in to view
@azure-pipelines

This comment was marked as duplicate.

Sign in to view
@markples
markplesforce-pushed
the
gcstress-standalone
branch
from
f479401 to
7de7262CompareApril 25, 2023 00:14
@markples
markples
commented
Apr 25, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
Apr 25, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@markplesmarkples
mentioned this pull request
Apr 25, 2023
 Merged


This was referenced Apr 25, 2023

Open


Closed


Closed

@markples
markples
commented
Apr 26, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
Apr 26, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@markples
markples
commented
Apr 26, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
Apr 26, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Apr 26, 2023

Closed


Closed


Closed

@markples
markples
commented
Apr 27, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
Apr 27, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@markples
markples
commented
May 2, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
May 2, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced May 2, 2023

Closed


Closed


Closed

@markples
markples
commented
May 2, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
May 2, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@markples
markples
commented
May 3, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
May 3, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@markples
markples
commented
May 5, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I'm going back to trying to get merging to work better (e.g., #85040). This has been painful and isn't there yet. There are a few fundamental points:
  • A test needs to change between OutputType Exe vs Library for a merged test vs one with RequireProcessIsolation (or in BuildAsStandalone mode). While theoretically this shouldn't be different between RPI and BAS, I've hit a lot of issues messing around with it. This is how we've ended up in a situation where RPI works (only) when marked on tests and BAS works (only) as a global setting. This is relevant to the idea below of trying to run a few merged groups in a BAS build.
  • We have some huge projects (such as JIT\HardwareIntrinsics\Arm\AdvSimd.Arm64\AdvSimd.Arm64_r.csproj). In merged test groups, the individual tests within this project can be striped to multiple helix jobs. In the old style, this test has a single entry point that runs everything, and it times out under gcstress.
I don't think investing in striping in BAS is the right direction as the main reason for BAS is to be simpler than merged groups, and I don't think investing in special cases in the msbuild BAS support is the right thing to do (or then maintain). Maybe after efforts fail again with merged groups I'll change my mind again.
@markplesmarkples
closed this
May 5, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Jun 5, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


No reviews


Assignees

@markplesmarkples

Labels

test-enhancementImprovements of test source code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@markples

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Set BuildAsStandalone for gcstress test builds by markples · Pull Request #85284 · dotnet/runtime · GitHub
Skip to content
Set BuildAsStandalone for gcstress test builds - #85284
Closed
markples wants to merge 10 commits into
dotnet:mainfrom 
markples:gcstress-standalone
Closed
Set BuildAsStandalone for gcstress test builds#85284
markples wants to merge 10 commits into
dotnet:mainfrom 
markples:gcstress-standalone
Conversation
@markples
@markplesmarkples
commented
Apr 25, 2023

Copy link


Copy Markdown

Contributor
 No description provided. 
@ghostghost
added
the 
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
label
Apr 25, 2023
@ghostghost
assigned markplesApr 25, 2023
@markplesmarkples
added

test-enhancement
Improvements of test source code
and removed

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
Apr 25, 2023
@markples

This comment was marked as duplicate.

Sign in to view
@azure-pipelines

This comment was marked as duplicate.

Sign in to view
@markples
markplesforce-pushed
the
gcstress-standalone
branch
from
f479401 to
7de7262CompareApril 25, 2023 00:14
@markples
markples
commented
Apr 25, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
Apr 25, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@markplesmarkples
mentioned this pull request
Apr 25, 2023
 Merged


This was referenced Apr 25, 2023

Open


Closed


Closed

@markples
markples
commented
Apr 26, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
Apr 26, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@markples
markples
commented
Apr 26, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
Apr 26, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Apr 26, 2023

Closed


Closed


Closed

@markples
markples
commented
Apr 27, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
Apr 27, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@markples
markples
commented
May 2, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
May 2, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced May 2, 2023

Closed


Closed


Closed

@markples
markples
commented
May 2, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
May 2, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@markples
markples
commented
May 3, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
May 3, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@markples
markples
commented
May 5, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I'm going back to trying to get merging to work better (e.g., #85040). This has been painful and isn't there yet. There are a few fundamental points:
  • A test needs to change between OutputType Exe vs Library for a merged test vs one with RequireProcessIsolation (or in BuildAsStandalone mode). While theoretically this shouldn't be different between RPI and BAS, I've hit a lot of issues messing around with it. This is how we've ended up in a situation where RPI works (only) when marked on tests and BAS works (only) as a global setting. This is relevant to the idea below of trying to run a few merged groups in a BAS build.
  • We have some huge projects (such as JIT\HardwareIntrinsics\Arm\AdvSimd.Arm64\AdvSimd.Arm64_r.csproj). In merged test groups, the individual tests within this project can be striped to multiple helix jobs. In the old style, this test has a single entry point that runs everything, and it times out under gcstress.
I don't think investing in striping in BAS is the right direction as the main reason for BAS is to be simpler than merged groups, and I don't think investing in special cases in the msbuild BAS support is the right thing to do (or then maintain). Maybe after efforts fail again with merged groups I'll change my mind again.
@markplesmarkples
closed this
May 5, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Jun 5, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


No reviews


Assignees

@markplesmarkples

Labels

test-enhancementImprovements of test source code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@markples

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Set BuildAsStandalone for gcstress test builds by markples · Pull Request #85284 · dotnet/runtime · GitHub
Skip to content
Set BuildAsStandalone for gcstress test builds - #85284
Closed
markples wants to merge 10 commits into
dotnet:mainfrom 
markples:gcstress-standalone
Closed
Set BuildAsStandalone for gcstress test builds#85284
markples wants to merge 10 commits into
dotnet:mainfrom 
markples:gcstress-standalone
Conversation
@markples
@markplesmarkples
commented
Apr 25, 2023

Copy link


Copy Markdown

Contributor
 No description provided. 
@ghostghost
added
the 
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
label
Apr 25, 2023
@ghostghost
assigned markplesApr 25, 2023
@markplesmarkples
added

test-enhancement
Improvements of test source code
and removed

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
Apr 25, 2023
@markples

This comment was marked as duplicate.

Sign in to view
@azure-pipelines

This comment was marked as duplicate.

Sign in to view
@markples
markplesforce-pushed
the
gcstress-standalone
branch
from
f479401 to
7de7262CompareApril 25, 2023 00:14
@markples
markples
commented
Apr 25, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
Apr 25, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@markplesmarkples
mentioned this pull request
Apr 25, 2023
 Merged


This was referenced Apr 25, 2023

Open


Closed


Closed

@markples
markples
commented
Apr 26, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
Apr 26, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@markples
markples
commented
Apr 26, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
Apr 26, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Apr 26, 2023

Closed


Closed


Closed

@markples
markples
commented
Apr 27, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
Apr 27, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@markples
markples
commented
May 2, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
May 2, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced May 2, 2023

Closed


Closed


Closed

@markples
markples
commented
May 2, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
May 2, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@markples
markples
commented
May 3, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr gcstress0x3-gcstress0xc
@azure-pipelines
azure-pipelinesBot
commented
May 3, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@markples
markples
commented
May 5, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I'm going back to trying to get merging to work better (e.g., #85040). This has been painful and isn't there yet. There are a few fundamental points:
  • A test needs to change between OutputType Exe vs Library for a merged test vs one with RequireProcessIsolation (or in BuildAsStandalone mode). While theoretically this shouldn't be different between RPI and BAS, I've hit a lot of issues messing around with it. This is how we've ended up in a situation where RPI works (only) when marked on tests and BAS works (only) as a global setting. This is relevant to the idea below of trying to run a few merged groups in a BAS build.
  • We have some huge projects (such as JIT\HardwareIntrinsics\Arm\AdvSimd.Arm64\AdvSimd.Arm64_r.csproj). In merged test groups, the individual tests within this project can be striped to multiple helix jobs. In the old style, this test has a single entry point that runs everything, and it times out under gcstress.
I don't think investing in striping in BAS is the right direction as the main reason for BAS is to be simpler than merged groups, and I don't think investing in special cases in the msbuild BAS support is the right thing to do (or then maintain). Maybe after efforts fail again with merged groups I'll change my mind again.
@markplesmarkples
closed this
May 5, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Jun 5, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


No reviews


Assignees

@markplesmarkples

Labels

test-enhancementImprovements of test source code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@markples