Skip to content

Fix physical promotion scenario name and a couple of bugs - #85343

Merged
jakobbotsch merged 3 commits into
dotnet:mainfrom
jakobbotsch:fix-physical-promotion-scenario
Apr 26, 2023
Merged

Fix physical promotion scenario name and a couple of bugs#85343
jakobbotsch merged 3 commits into
dotnet:mainfrom
jakobbotsch:fix-physical-promotion-scenario

Conversation

@jakobbotsch

@jakobbotschjakobbotsch commented Apr 25, 2023•
edited
Loading

Copy link
Copy Markdown
Member

This was renamed but I forgot to update these occurrences. The result is that runtime-jit-experimental is not actually running with physical promotion enabled (but the stress jobs do).

cc @dotnet/jit-contrib PTAL @AndyAyersMS

Fix#85403

@jakobbotsch
Fix generalized promotion scenario name
d7b4ca7
This was renamed but I forgot to update these occurrences. The result is
that runtime-jit-experimental is not actually running with physical
promotion enabled.
@ghostghost added the area-Infrastructure-coreclr Only use for closed issues label Apr 25, 2023
@ghost

ghost commented Apr 25, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

This was renamed but I forgot to update these occurrences. The result is that runtime-jit-experimental is not actually running with physical promotion enabled (but the stress jobs do).

cc @dotnet/jit-contrib PTAL @AndyAyersMS

Author:jakobbotsch
Assignees:jakobbotsch
Labels:

area-Infrastructure-coreclr

Milestone:-

BruceForstall
BruceForstall approved these changes Apr 25, 2023
View reviewed changes

@BruceForstallBruceForstall left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like testenvironment.proj should loudly fail if the scenario name isn't found

@jkoritzinsky

jkoritzinsky commented Apr 25, 2023

Copy link
Copy Markdown
Member

Seems like testenvironment.proj should loudly fail if the scenario name isn't found

One possible solution for this would be to change testenvironment.proj to use pre-written .env files instead of generating environment scripts on the fly. That way we'd be able to be able to easily tell when a scenario isn't known as there wouldn't be a file on disk for the scenario.

@jakobbotsch

jakobbotsch commented Apr 25, 2023

Copy link
Copy Markdown
MemberAuthor

Failures look known according to build analysis.

@jakobbotsch

jakobbotsch commented Apr 25, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-jit-experimental

@azure-pipelines

azure-pipelinesBot commented Apr 25, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Apr 25, 2023
Closed
Closed
Closed
Closed
@jakobbotschjakobbotsch changed the title Fix physical promotion scenario nameFix physical promotion scenario name and a couple of bugsApr 26, 2023
@jakobbotsch

jakobbotsch commented Apr 26, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-jit-experimental, runtime-coreclr jitstress, runtime-coreclr libraries-jitstress

@azure-pipelines

azure-pipelinesBot commented Apr 26, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@jakobbotsch

jakobbotsch commented Apr 26, 2023

Copy link
Copy Markdown
MemberAuthor

runtime-jit-experimental and recent jitstress runs seem to be hitting some problems I fixed in #85323, so I I ported a couple of fixes from there to this PR.

@jakobbotsch

jakobbotsch commented Apr 26, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-jit-experimental, runtime-coreclr jitstress, runtime-coreclr libraries-jitstress

@azure-pipelines

azure-pipelinesBot commented Apr 26, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@jakobbotschjakobbotsch mentioned this pull request Apr 26, 2023
Closed
@jakobbotsch

jakobbotsch commented Apr 26, 2023

Copy link
Copy Markdown
MemberAuthor

The remaining stress failures should have been fixed with #85396, but not sure what is going on with the OSX runs.

@MichalPetryka

MichalPetryka commented Apr 26, 2023

Copy link
Copy Markdown
Contributor

but not sure what is going on with the OSX runs.

OSX runner seems to be having issues right now, it timed out on my PR.

@MichalPetrykaMichalPetryka mentioned this pull request Apr 26, 2023
Merged
@jakobbotsch

jakobbotsch commented Apr 26, 2023

Copy link
Copy Markdown
MemberAuthor

It looks like there's still some libraries-jitstress failures; opened #85426 for it (doesn't look related to physical promotion).

@jakobbotsch
jakobbotsch merged commit 2430618 into dotnet:mainApr 26, 2023
@jakobbotsch
jakobbotsch deleted the fix-physical-promotion-scenario branch April 26, 2023 22:43
@build-analysisbuild-analysisBot mentioned this pull request Apr 26, 2023
Closed
This was referenced Apr 27, 2023
Closed
Closed
@ghostghost locked as resolved and limited conversation to collaborators May 27, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tannergoodingtannergoodingtannergooding approved these changes
@AndyAyersMSAndyAyersMSAwaiting requested review from AndyAyersMS
+1 more reviewer
@BruceForstallBruceForstallBruceForstall approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jakobbotschjakobbotsch

Labels

area-Infrastructure-coreclrOnly use for closed issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[jitstress] Assertion failed 'replacements[firstIndex].Overlaps(offs, size)' during 'Physical promotion'

5 participants

@jakobbotsch@jkoritzinsky@MichalPetryka@tannergooding@BruceForstall