Skip to content

Reduce calli address spilling - #85349

Merged
AndyAyersMS merged 1 commit into
dotnet:mainfrom
MichalPetryka:calli-spill
Apr 27, 2023
Merged

Reduce calli address spilling#85349
AndyAyersMS merged 1 commit into
dotnet:mainfrom
MichalPetryka:calli-spill

Conversation

@MichalPetryka

Copy link
Copy Markdown
Contributor

Avoid spilling FTN_ADDR params, removes spilling of address on 0 arg default cconv callis.

Split off from #85197.

@ghostghost added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member labels Apr 25, 2023
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Avoid spilling FTN_ADDR params, removes spilling of address on 0 arg default cconv callis.

Split off from #85197.

Author:MichalPetryka
Assignees:-
Labels:

area-CodeGen-coreclr

Milestone:-

@jakobbotsch

Copy link
Copy Markdown
Member

/azp run jit-cfg

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@MichalPetryka

Copy link
Copy Markdown
ContributorAuthor

This seems to trigger huge diffs due to delegate constructors taking less of the inliner budget.

@AndyAyersMS

Copy link
Copy Markdown
Member

Seems like the huge diffs are mostly in what are likely unrealistic test cases.

I'd like to see the ASP.NET diffs but unfortunately I can't recollect this right now as the machine I use is offline. So let's hold onto this change until I can get that collection going again.

@jakobbotsch

Copy link
Copy Markdown
Member

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@AndyAyersMS

AndyAyersMS commented Apr 26, 2023

Copy link
Copy Markdown
Member

I have a new ASP.NET SPMI collection so am going to rerun that part of normal CI.

@jakobbotsch do you know if the stress failures here were mostly from promotion?

@AndyAyersMS

Copy link
Copy Markdown
Member

Seems like since SPMI passed the first time the only rerun option is to bounce the PR.

@MichalPetryka why don't we merge this up to main and trigger a new round of CI that way? Would prefer you to do this but I can do it if you like.

@MichalPetryka

MichalPetryka commented Apr 26, 2023

Copy link
Copy Markdown
ContributorAuthor

do you know if the stress failures here were mostly from promotion?

I'd like to rerun stress after @jakobbotsch fixes the promotion issues with #85343.

@jakobbotsch

Copy link
Copy Markdown
Member

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@AndyAyersMS

Copy link
Copy Markdown
Member

FYI you can generally just merge and not rebase -- that makes it a bit easier for us to track what is going on.

@jakobbotsch

Copy link
Copy Markdown
Member

@jakobbotsch do you know if the stress failures here were mostly from promotion?

Looks like it, the remaining failures are #85449, #85426 and #48798 as far as I can tell.

@AndyAyersMS

Copy link
Copy Markdown
Member

Seems like the various failures are known, so let's merge.

@AndyAyersMS
AndyAyersMS merged commit 0f06ede into dotnet:mainApr 27, 2023
@AndyAyersMS

Copy link
Copy Markdown
Member

@MichalPetryka thanks!

@ghostghost locked as resolved and limited conversation to collaborators May 27, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@MichalPetryka@jakobbotsch@AndyAyersMS