Skip to content

[wasm] Unify boot config location - #85763

Merged
maraf merged 11 commits into
dotnet:mainfrom
maraf:WasmUnifyConfigLocatioon
May 12, 2023
Merged

[wasm] Unify boot config location#85763
maraf merged 11 commits into
dotnet:mainfrom
maraf:WasmUnifyConfigLocatioon

Conversation

@maraf

@marafmaraf commented May 4, 2023

Copy link
Copy Markdown
Member
  • We need both mono-config.json and blazor.boot.json schemas until we can use new SDK in tree
  • Rename mono-config to blazor.boot.json to unify location where to load config from
  • Drop the need for withStartupOptions to use Wasm SDK path in JS

@marafmaraf added arch-wasm WebAssembly architecture area-Build-mono labels May 4, 2023
@marafmaraf added this to the 8.0.0 milestone May 4, 2023
@marafmaraf self-assigned this May 4, 2023
@ghost

ghost commented May 4, 2023

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • We need both mono-config.json and blazor.boot.json schemas until we can use new SDK in tree
  • Rename mono-config to blazor.boot.json to unify location where to load config from
  • Drops the need for withStartupOptions to use Wasm SDK
Author:maraf
Assignees:maraf
Labels:

arch-wasm, area-Build-mono

Milestone:8.0.0

@pavelsavara

Copy link
Copy Markdown
Member

This would be ugly merge, other than that look like acceptable temporary solution.

#85730

@maraf

maraf commented May 4, 2023

Copy link
Copy Markdown
MemberAuthor

I can easily redo it after loader. Mostly text replaces

Comment threadsrc/mono/wasm/runtime/blazor/BootConfig.ts Outdated
Comment threadsrc/mono/wasm/runtime/blazor/_Integration.ts Outdated
Comment threadsrc/mono/wasm/runtime/loader/config.ts
Comment threadsrc/mono/wasm/runtime/loader/run.ts
@maraf
maraf merged commit a91d781 into dotnet:mainMay 12, 2023
@maraf
maraf deleted the WasmUnifyConfigLocatioon branch May 12, 2023 17:52
@ghostghost locked as resolved and limited conversation to collaborators Jun 11, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@maraf@pavelsavara