Uh oh!
There was an error while loading. Please reload this page.
[browser] loader ES6 module - #85730
Conversation
ghost
commented
May 3, 2023
Tagging subscribers to 'arch-wasm': @lewing Issue Detailswip
|
…nd native js files, remove it from loader js
# Conflicts: # src/mono/wasm/runtime/jiterpreter-trace-generator.ts
pavelsavara
commented
May 9, 2023
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pavelsavara
commented
May 9, 2023
/azp run runtime-wasm |
WBT fails with All other CI failures are known. |
pavelsavara
commented
May 11, 2023
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| /** | ||
| * query string to be used for asset loading | ||
| */ | ||
| assetUniqueQuery?: string; |
There was a problem hiding this comment.
What is the benefit over WebAssemblyStartOptions.loadBootResource?
There was a problem hiding this comment.
We could unify those later. Right now, the loadBootResource is not there for non-blazor templates.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
pavelsavara
commented
May 11, 2023
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lewing
commented
May 12, 2023
This appears to have caused a massive regression in jsimport/export in browserbench? |
Split the
dotnet.jsinto 3 ES6 modules.dotnet.jssrc\mono\wasm\runtime\loader\foldermono-config.jsonorboot.config.jsondotnet.runtime.jsanddotnet.nativejsby looking at theconfig.assetsdotnet.runtime.jssrc\mono\wasm\runtime\folder except/loaderfolderdotnet.native.jsdotnet.native.wasm,dotnet.native.symbols.js,dotnet.native.worker.jsdotnet.nativeis the new prefix name.future benefits
dotnet.js. The loader would not change on re-link with workload.Other changes
assetUniqueQuerywhich is appended to asset names (so that we could have multiple instances of ES6 modules)loaderHelpersis similar toruntimeHelpersbut is populated by "loader". It passes methods and state between modules.find_corlib_classandfind_class_in_assemblywould not always throw when they don't find the class.js-module-runtime,js-module-dotnet,js-module-nativeModule.importsfunctionality, droppedDotnetModuleConfigImportsMONO.mono_wasm_load_configfrom legacy APIrequirepolyfill on NodeJSlocateFilepolyfillcreateEmscriptenis worth reviewSelfContaineddotnet.native.worker.jsnow loadsdotnet.jsloader first