') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [wasm] Wasm.Build.Tests - Override KnownWebAssemblySdkPack to 8.0.0-dev by maraf · Pull Request #85815 · dotnet/runtime · GitHub
Skip to content

[wasm] Wasm.Build.Tests - Override KnownWebAssemblySdkPack to 8.0.0-dev - #85815

Merged
maraf merged 4 commits into
dotnet:mainfrom
maraf:WasmSdkWbtOverridePackVersion
May 9, 2023
Merged

[wasm] Wasm.Build.Tests - Override KnownWebAssemblySdkPack to 8.0.0-dev#85815
maraf merged 4 commits into
dotnet:mainfrom
maraf:WasmSdkWbtOverridePackVersion

Conversation

@maraf

@marafmaraf commented May 5, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Override version of KnownWebAssemblySdkPack in Microsoft.NETCoreSdk.BundledVersions.props to point to local built package

@marafmaraf added arch-wasm WebAssembly architecture area-Build-mono labels May 5, 2023
@marafmaraf added this to the 8.0.0 milestone May 5, 2023
@marafmaraf self-assigned this May 5, 2023
@ghost

ghost commented May 5, 2023

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:maraf
Assignees:maraf
Labels:

arch-wasm, area-Build-mono

Milestone:8.0.0

@maraf

maraf commented May 5, 2023

Copy link
Copy Markdown
MemberAuthor

@radical It seems that it uses for some reason a global nuget cache. Am I doing something wrong?

image

@maraf
maraf marked this pull request as ready for review May 5, 2023 15:46
@maraf
maraf requested a review from radical as a code ownerMay 5, 2023 15:46
@maraf
maraf requested a review from lewingMay 5, 2023 15:46
@radical

radical commented May 5, 2023

Copy link
Copy Markdown
Member

@radical It seems that it uses for some reason a global nuget cache. Am I doing something wrong?

image

How did you get this? I tried it locally, and even if I have 8.0.0-dev in my global cache, the tests always correctly pick up from the test-local fresh cache.

@maraf

maraf commented May 6, 2023

Copy link
Copy Markdown
MemberAuthor

How did you get this?

I built the dotnet-latest using the target from WBT to build it and than
I'm using dotnet-latest/dotnet.exe to create project and etc. I'll try from scratch next week and dig in.

@radical

radical commented May 6, 2023

Copy link
Copy Markdown
Member

Using dotnet from there won't change where the nuget cache is used from. That special setup is for the tests. You can override it manually or use a custom nuget.config . You can find one with the built test projects.

@maraf

maraf commented May 9, 2023

Copy link
Copy Markdown
MemberAuthor

Ook, I knew about nuget feed configuration, but I was missing $env:NUGET_PACKAGES. Thanks!

@radical This is ready for review than.

pavelsavara
pavelsavara approved these changes May 9, 2023
View reviewed changes

@pavelsavarapavelsavara left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@radical feel free to further improve this in subsequent PRs
We need to unblock #85730

@maraf
maraf merged commit a442971 into dotnet:mainMay 9, 2023
@maraf
maraf deleted the WasmSdkWbtOverridePackVersion branch May 9, 2023 09:55
@ghostghost locked as resolved and limited conversation to collaborators Jun 8, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pavelsavarapavelsavarapavelsavara approved these changes
@radicalradicalAwaiting requested review from radical
@lewinglewingAwaiting requested review from lewing

Assignees

@marafmaraf

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@maraf@radical@pavelsavara