Skip to content

[mono][tests] Parallel AOT compilation of runtime tests on iOS platforms - #86089

Merged
kotlarmilos merged 90 commits into
dotnet:mainfrom
kotlarmilos:feature/parallel-aot-compilation
Jul 21, 2023
Merged

[mono][tests] Parallel AOT compilation of runtime tests on iOS platforms #86089
kotlarmilos merged 90 commits into
dotnet:mainfrom
kotlarmilos:feature/parallel-aot-compilation

Conversation

@kotlarmilos

@kotlarmiloskotlarmilos commented May 11, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Description

This PR aims to move the AOT compilation of runtime tests to the Helix and enable the following testing groups on apple mobile platforms: tracing_eventpipe, tracing_eventlistener, reflection_regression, reflection_StaticInterfaceMembers, reflection_GenericAttribute, reflection_DefaultInterfaceMethods, baseservices_mono, baseservices_exceptions, baseservices_compilerservices, baseservices_TieredCompilation, Regressions_coreclr, Loader_classloader, Loader_StartupHooks, JIT_RyuJIT, JIT_PGO, JIT_Math, JIT_Intrinsics, Interop_DllImportSearchPaths, JIT_Intrinsics, GC_Scenarios, GC_Regressions, GC_LargeMemor, GC_Features, GC_Coverage, GC_API, Exceptions_UnwindFpBleedTest, CoreMangLib_system.

The Helix payload is generated using the runtime pipeline. Then, the libraries pipeline is utilized to AOT compile and execute the tests on Helix. The build-runtime-tests-and-send-to-helix.yml is updated with the compileOnHelix parameter, which if set, uses the libraries/helix.yml template instead of the runtime send-to-helix-step.yml template. The runtime and libraries pipelines are updated to support AOT compilation of runtime tests on Helix.

Important notes:

@kotlarmiloskotlarmilos added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it area-Infrastructure-mono os-ios Apple iOS labels May 11, 2023
@kotlarmiloskotlarmilos added this to the 8.0.0 milestone May 11, 2023
@kotlarmiloskotlarmilos self-assigned this May 11, 2023
@ghost

ghost commented May 11, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR aims to move AOT compilation of the runtime tests to Helix.

Author:kotlarmilos
Assignees:kotlarmilos
Labels:

NO-MERGE, NO-REVIEW, area-Infrastructure-mono, os-ios

Milestone:8.0.0

@kotlarmiloskotlarmilos mentioned this pull request May 30, 2023
Merged
@build-analysisbuild-analysisBot mentioned this pull request May 30, 2023
Open
@kotlarmilos

kotlarmilos commented Jul 19, 2023

Copy link
Copy Markdown
MemberAuthor

@steveisok@akoeplinger@ivanpovazan@mdh1418 This pull request is ready for review. I am triaging failing tests by fixing or disabling them, but it should not affect the functionality.

List of follow-up tasks is in #84254.

@SamMonoRT Currently, there are 28 test suites (apps) that can be run on iOS, out of which 7 are failing. I will try to fix or disable the failing tests and run the remaining ones. Afterward, I suggest we review other disabled test suites for AOT compilation and prioritize those with higher impact.

@build-analysisbuild-analysisBot mentioned this pull request Jul 19, 2023
Closed
@kotlarmilos

kotlarmilos commented Jul 19, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-ioslike,runtime-ioslikesimulator

@azure-pipelines

azure-pipelinesBot commented Jul 19, 2023

Copy link
Copy Markdown

No commit pushedDate could be found for PR 86089 in repo dotnet/runtime

@kotlarmilos

kotlarmilos commented Jul 19, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-ioslike,runtime-ioslikesimulator

@azure-pipelines

azure-pipelinesBot commented Jul 19, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@build-analysisbuild-analysisBot mentioned this pull request Jul 19, 2023
Closed
@kotlarmilos

kotlarmilos commented Jul 20, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-ioslikesimulator

@azure-pipelines

This comment was marked as outdated.

Sign in to view
@azure-pipelines

azure-pipelinesBot commented Jul 20, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos

kotlarmilos commented Jul 20, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-ioslikesimulator

@azure-pipelines

azure-pipelinesBot commented Jul 20, 2023

Copy link
Copy Markdown

No commit pushedDate could be found for PR 86089 in repo dotnet/runtime

@kotlarmilos

kotlarmilos commented Jul 20, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-ioslikesimulator

@azure-pipelines

azure-pipelinesBot commented Jul 20, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jul 20, 2023
Closed
Closed
@kotlarmilos

kotlarmilos commented Jul 21, 2023

Copy link
Copy Markdown
MemberAuthor

ping here :)

@steveisok@akoeplinger@ivanpovazan@mdh1418

ivanpovazan
ivanpovazan approved these changes Jul 21, 2023
View reviewed changes

@ivanpovazanivanpovazan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a few comments/questions looks good to me!

Comment threadeng/testing/tests.ioslike.targets
Comment on lines +65 to +73
<!--
Checks if the directory name "AppleAssembliesToBundle" is equal to the "AssemblyName",
if they match, consider it as the root directory and copy the files there,
otherwise, copy the files to a subdirectory.
-->
<BundleFiles Condition="'%(AppleAssembliesToBundle._IsNative)' != 'true' and ($([System.IO.Path]::GetFileName($([System.IO.Path]::GetDirectoryName('%(AppleAssembliesToBundle.Identity)')))) == '$(AssemblyName)' or '$(CustomMain)' != 'true')"
Include="@(AppleAssembliesToBundle)" TargetDir="publish" />
<BundleFiles Condition="'%(AppleAssembliesToBundle._IsNative)' != 'true' and $([System.IO.Path]::GetFileName($([System.IO.Path]::GetDirectoryName('%(AppleAssembliesToBundle.Identity)')))) != '$(AssemblyName)' and '$(CustomMain)' == 'true'"
Include="@(AppleAssembliesToBundle)" TargetDir="publish\$([System.IO.Path]::GetFileName($([System.IO.Path]::GetDirectoryName('%(AppleAssembliesToBundle.Identity)'))))" />

@ivanpovazanivanpovazanJul 21, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question: Why does it matter if $(CustomMain) is specified or not here?

@kotlarmiloskotlarmilosJul 21, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same target is used for the library and runtime tests and the condition checks if the directory is equals to the assemblyName. In case of runtime tests that is true, but for library tests that creates recursive dirs.

Probably better to use more descriptive variable.

Comment threadsrc/mono/msbuild/apple/build/AppleBuild.props
Comment threadsrc/tests/build.proj
Comment threadsrc/tests/build.proj Outdated
<Copy SourceFiles="@(RecursiveCopyHack)" DestinationFolder="$(FinalPath)/%(RecursiveDir)" />
<RemoveDir Directories="$(AppBundlePath)" />
<Message Importance="High" Text="App: $(FinalPath)" />
<CustomTask EntryPoints="@(EntryPoints)" RunScriptCommand="$(RunScriptCommand)" AppName="$(Category)" Condition="'$(BuildTestsOnHelix)' == 'true'">

@ivanpovazanivanpovazanJul 21, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I don't have a good suggestion, but I think the task should have a more meaningful name.
Maybe something like UpdateRunScriptToHandleMultipleEntryPoints

@kotlarmiloskotlarmilosJul 21, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, I missed that.

@kotlarmilos

kotlarmilos commented Jul 21, 2023

Copy link
Copy Markdown
MemberAuthor

Merging this PR to enhance the apple mobile tests coverage. If additional feedback is provided, it will be addressed in a follow-up.

@kotlarmilos
kotlarmilos merged commit 7531c50 into dotnet:mainJul 21, 2023
@steveisok

steveisok commented Jul 21, 2023

Copy link
Copy Markdown
Member

LGTM! Awesome work!

@ghostghost locked as resolved and limited conversation to collaborators Aug 20, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ivanpovazanivanpovazanivanpovazan approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplinger
@mdh1418mdh1418Awaiting requested review from mdh1418
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@marek-safarmarek-safarAwaiting requested review from marek-safar
@steveisoksteveisokAwaiting requested review from steveisoksteveisok is a code owner

Assignees

@kotlarmiloskotlarmilos

Labels

area-Infrastructure-monoos-iosApple iOS

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@kotlarmilos@steveisok@ivanpovazan
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[mono][tests] Parallel AOT compilation of runtime tests on iOS platforms by kotlarmilos · Pull Request #86089 · dotnet/runtime · GitHub
Skip to content
[mono][tests] Parallel AOT compilation of runtime tests on iOS platforms  - #86089
Merged
kotlarmilos merged 90 commits into
dotnet:mainfrom 
kotlarmilos:feature/parallel-aot-compilation
Jul 21, 2023
Merged
[mono][tests] Parallel AOT compilation of runtime tests on iOS platforms #86089
kotlarmilos merged 90 commits into
dotnet:mainfrom 
kotlarmilos:feature/parallel-aot-compilation
Conversation
@kotlarmilos
@kotlarmiloskotlarmilos
commented
May 11, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Description
This PR aims to move the AOT compilation of runtime tests to the Helix and enable the following testing groups on apple mobile platforms: tracing_eventpipe, tracing_eventlistener, reflection_regression, reflection_StaticInterfaceMembers, reflection_GenericAttribute, reflection_DefaultInterfaceMethods, baseservices_mono, baseservices_exceptions, baseservices_compilerservices, baseservices_TieredCompilation, Regressions_coreclr, Loader_classloader, Loader_StartupHooks, JIT_RyuJIT, JIT_PGO, JIT_Math, JIT_Intrinsics, Interop_DllImportSearchPaths, JIT_Intrinsics, GC_Scenarios, GC_Regressions, GC_LargeMemor, GC_Features, GC_Coverage, GC_API, Exceptions_UnwindFpBleedTest, CoreMangLib_system.
The Helix payload is generated using the runtime pipeline. Then, the libraries pipeline is utilized to AOT compile and execute the tests on Helix. The build-runtime-tests-and-send-to-helix.yml is updated with the compileOnHelix parameter, which if set, uses the libraries/helix.yml template instead of the runtime send-to-helix-step.yml template. The runtime and libraries pipelines are updated to support AOT compilation of runtime tests on Helix.
Important notes:
@kotlarmiloskotlarmilos
added

NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
NO-REVIEW
Experimental/testing PR, do NOT review it
area-Infrastructure-mono

os-ios
Apple iOS
labels
May 11, 2023
@kotlarmiloskotlarmilos
added this to the 8.0.0 milestone
May 11, 2023
@kotlarmiloskotlarmilos
self-assigned this
May 11, 2023
@ghost
ghost
commented
May 11, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @directhex

See info in area-owners.md if you want to be subscribed.
Issue Details
This PR aims to move AOT compilation of the runtime tests to Helix.
Author:kotlarmilos
Assignees:kotlarmilos
Labels:
NO-MERGE, NO-REVIEW, area-Infrastructure-mono, os-ios
Milestone:8.0.0
@kotlarmiloskotlarmilos
mentioned this pull request
May 30, 2023
 Merged

@build-analysisbuild-analysisBot
mentioned this pull request
May 30, 2023

Open

@kotlarmilos
kotlarmilos
commented
Jul 19, 2023

Copy link


Copy Markdown

MemberAuthor
@steveisok@akoeplinger@ivanpovazan@mdh1418 This pull request is ready for review. I am triaging failing tests by fixing or disabling them, but it should not affect the functionality.
List of follow-up tasks is in #84254.
@SamMonoRT Currently, there are 28 test suites (apps) that can be run on iOS, out of which 7 are failing. I will try to fix or disable the failing tests and run the remaining ones. Afterward, I suggest we review other disabled test suites for AOT compilation and prioritize those with higher impact.
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 19, 2023

Closed

@kotlarmilos
kotlarmilos
commented
Jul 19, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-ioslike,runtime-ioslikesimulator
@azure-pipelines
azure-pipelinesBot
commented
Jul 19, 2023

Copy link


Copy Markdown

No commit pushedDate could be found for PR 86089 in repo dotnet/runtime
@kotlarmilos
kotlarmilos
commented
Jul 19, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-ioslike,runtime-ioslikesimulator
@azure-pipelines
azure-pipelinesBot
commented
Jul 19, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 19, 2023

Closed

@kotlarmilos
kotlarmilos
commented
Jul 20, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-ioslikesimulator
@azure-pipelines

This comment was marked as outdated.

Sign in to view
@azure-pipelines
azure-pipelinesBot
commented
Jul 20, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@kotlarmilos
kotlarmilos
commented
Jul 20, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-ioslikesimulator
@azure-pipelines
azure-pipelinesBot
commented
Jul 20, 2023

Copy link


Copy Markdown

No commit pushedDate could be found for PR 86089 in repo dotnet/runtime
@kotlarmilos
kotlarmilos
commented
Jul 20, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-ioslikesimulator
@azure-pipelines
azure-pipelinesBot
commented
Jul 20, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jul 20, 2023

Closed


Closed

@kotlarmilos
kotlarmilos
commented
Jul 21, 2023

Copy link


Copy Markdown

MemberAuthor
ping here :)
@steveisok@akoeplinger@ivanpovazan@mdh1418
ivanpovazan
ivanpovazan
approved these changes
Jul 21, 2023
View reviewed changes
@ivanpovazanivanpovazan
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a few comments/questions looks good to me!
Comment threadeng/testing/tests.ioslike.targets

Comment on lines

+65
 to 
+73

 <!-- 
 Checks if the directory name "AppleAssembliesToBundle" is equal to the "AssemblyName",
 if they match, consider it as the root directory and copy the files there,
 otherwise, copy the files to a subdirectory.
 -->
 <BundleFiles Condition="'%(AppleAssembliesToBundle._IsNative)' != 'true' and ($([System.IO.Path]::GetFileName($([System.IO.Path]::GetDirectoryName('%(AppleAssembliesToBundle.Identity)')))) == '$(AssemblyName)' or '$(CustomMain)' != 'true')"
 Include="@(AppleAssembliesToBundle)" TargetDir="publish" />
 <BundleFiles Condition="'%(AppleAssembliesToBundle._IsNative)' != 'true' and $([System.IO.Path]::GetFileName($([System.IO.Path]::GetDirectoryName('%(AppleAssembliesToBundle.Identity)')))) != '$(AssemblyName)' and '$(CustomMain)' == 'true'"
 Include="@(AppleAssembliesToBundle)" TargetDir="publish\$([System.IO.Path]::GetFileName($([System.IO.Path]::GetDirectoryName('%(AppleAssembliesToBundle.Identity)'))))" />
@ivanpovazanivanpovazanJul 21, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question: Why does it matter if $(CustomMain) is specified or not here?
@kotlarmiloskotlarmilosJul 21, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same target is used for the library and runtime tests and the condition checks if the directory is equals to the assemblyName. In case of runtime tests that is true, but for library tests that creates recursive dirs.
Probably better to use more descriptive variable.
Comment threadsrc/mono/msbuild/apple/build/AppleBuild.props
Comment threadsrc/tests/build.proj
Comment threadsrc/tests/build.proj
Outdated

 <Copy SourceFiles="@(RecursiveCopyHack)" DestinationFolder="$(FinalPath)/%(RecursiveDir)" />
 <RemoveDir Directories="$(AppBundlePath)" />
 <Message Importance="High" Text="App: $(FinalPath)" />
 <CustomTask EntryPoints="@(EntryPoints)" RunScriptCommand="$(RunScriptCommand)" AppName="$(Category)" Condition="'$(BuildTestsOnHelix)' == 'true'">
@ivanpovazanivanpovazanJul 21, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I don't have a good suggestion, but I think the task should have a more meaningful name.

Maybe something like UpdateRunScriptToHandleMultipleEntryPoints
@kotlarmiloskotlarmilosJul 21, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, I missed that.
@kotlarmilos
kotlarmilos
commented
Jul 21, 2023

Copy link


Copy Markdown

MemberAuthor
Merging this PR to enhance the apple mobile tests coverage. If additional feedback is provided, it will be addressed in a follow-up.
@kotlarmilos
kotlarmilos
merged commit 7531c50
into
dotnet:mainJul 21, 2023
@steveisok
steveisok
commented
Jul 21, 2023

Copy link


Copy Markdown

Member
LGTM! Awesome work!
@ghostghost
locked as resolved and limited conversation to collaborators
Aug 20, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ivanpovazanivanpovazanivanpovazan approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplinger
@mdh1418mdh1418Awaiting requested review from mdh1418
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@marek-safarmarek-safarAwaiting requested review from marek-safar
@steveisoksteveisokAwaiting requested review from steveisoksteveisok is a code owner

Assignees

@kotlarmiloskotlarmilos

Labels

area-Infrastructure-monoos-iosApple iOS

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@kotlarmilos@steveisok@ivanpovazan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[mono][tests] Parallel AOT compilation of runtime tests on iOS platforms by kotlarmilos · Pull Request #86089 · dotnet/runtime · GitHub
Skip to content
[mono][tests] Parallel AOT compilation of runtime tests on iOS platforms  - #86089
Merged
kotlarmilos merged 90 commits into
dotnet:mainfrom 
kotlarmilos:feature/parallel-aot-compilation
Jul 21, 2023
Merged
[mono][tests] Parallel AOT compilation of runtime tests on iOS platforms #86089
kotlarmilos merged 90 commits into
dotnet:mainfrom 
kotlarmilos:feature/parallel-aot-compilation
Conversation
@kotlarmilos
@kotlarmiloskotlarmilos
commented
May 11, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Description
This PR aims to move the AOT compilation of runtime tests to the Helix and enable the following testing groups on apple mobile platforms: tracing_eventpipe, tracing_eventlistener, reflection_regression, reflection_StaticInterfaceMembers, reflection_GenericAttribute, reflection_DefaultInterfaceMethods, baseservices_mono, baseservices_exceptions, baseservices_compilerservices, baseservices_TieredCompilation, Regressions_coreclr, Loader_classloader, Loader_StartupHooks, JIT_RyuJIT, JIT_PGO, JIT_Math, JIT_Intrinsics, Interop_DllImportSearchPaths, JIT_Intrinsics, GC_Scenarios, GC_Regressions, GC_LargeMemor, GC_Features, GC_Coverage, GC_API, Exceptions_UnwindFpBleedTest, CoreMangLib_system.
The Helix payload is generated using the runtime pipeline. Then, the libraries pipeline is utilized to AOT compile and execute the tests on Helix. The build-runtime-tests-and-send-to-helix.yml is updated with the compileOnHelix parameter, which if set, uses the libraries/helix.yml template instead of the runtime send-to-helix-step.yml template. The runtime and libraries pipelines are updated to support AOT compilation of runtime tests on Helix.
Important notes:
@kotlarmiloskotlarmilos
added

NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
NO-REVIEW
Experimental/testing PR, do NOT review it
area-Infrastructure-mono

os-ios
Apple iOS
labels
May 11, 2023
@kotlarmiloskotlarmilos
added this to the 8.0.0 milestone
May 11, 2023
@kotlarmiloskotlarmilos
self-assigned this
May 11, 2023
@ghost
ghost
commented
May 11, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @directhex

See info in area-owners.md if you want to be subscribed.
Issue Details
This PR aims to move AOT compilation of the runtime tests to Helix.
Author:kotlarmilos
Assignees:kotlarmilos
Labels:
NO-MERGE, NO-REVIEW, area-Infrastructure-mono, os-ios
Milestone:8.0.0
@kotlarmiloskotlarmilos
mentioned this pull request
May 30, 2023
 Merged

@build-analysisbuild-analysisBot
mentioned this pull request
May 30, 2023

Open

@kotlarmilos
kotlarmilos
commented
Jul 19, 2023

Copy link


Copy Markdown

MemberAuthor
@steveisok@akoeplinger@ivanpovazan@mdh1418 This pull request is ready for review. I am triaging failing tests by fixing or disabling them, but it should not affect the functionality.
List of follow-up tasks is in #84254.
@SamMonoRT Currently, there are 28 test suites (apps) that can be run on iOS, out of which 7 are failing. I will try to fix or disable the failing tests and run the remaining ones. Afterward, I suggest we review other disabled test suites for AOT compilation and prioritize those with higher impact.
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 19, 2023

Closed

@kotlarmilos
kotlarmilos
commented
Jul 19, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-ioslike,runtime-ioslikesimulator
@azure-pipelines
azure-pipelinesBot
commented
Jul 19, 2023

Copy link


Copy Markdown

No commit pushedDate could be found for PR 86089 in repo dotnet/runtime
@kotlarmilos
kotlarmilos
commented
Jul 19, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-ioslike,runtime-ioslikesimulator
@azure-pipelines
azure-pipelinesBot
commented
Jul 19, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 19, 2023

Closed

@kotlarmilos
kotlarmilos
commented
Jul 20, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-ioslikesimulator
@azure-pipelines

This comment was marked as outdated.

Sign in to view
@azure-pipelines
azure-pipelinesBot
commented
Jul 20, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@kotlarmilos
kotlarmilos
commented
Jul 20, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-ioslikesimulator
@azure-pipelines
azure-pipelinesBot
commented
Jul 20, 2023

Copy link


Copy Markdown

No commit pushedDate could be found for PR 86089 in repo dotnet/runtime
@kotlarmilos
kotlarmilos
commented
Jul 20, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-ioslikesimulator
@azure-pipelines
azure-pipelinesBot
commented
Jul 20, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jul 20, 2023

Closed


Closed

@kotlarmilos
kotlarmilos
commented
Jul 21, 2023

Copy link


Copy Markdown

MemberAuthor
ping here :)
@steveisok@akoeplinger@ivanpovazan@mdh1418
ivanpovazan
ivanpovazan
approved these changes
Jul 21, 2023
View reviewed changes
@ivanpovazanivanpovazan
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a few comments/questions looks good to me!
Comment threadeng/testing/tests.ioslike.targets

Comment on lines

+65
 to 
+73

 <!-- 
 Checks if the directory name "AppleAssembliesToBundle" is equal to the "AssemblyName",
 if they match, consider it as the root directory and copy the files there,
 otherwise, copy the files to a subdirectory.
 -->
 <BundleFiles Condition="'%(AppleAssembliesToBundle._IsNative)' != 'true' and ($([System.IO.Path]::GetFileName($([System.IO.Path]::GetDirectoryName('%(AppleAssembliesToBundle.Identity)')))) == '$(AssemblyName)' or '$(CustomMain)' != 'true')"
 Include="@(AppleAssembliesToBundle)" TargetDir="publish" />
 <BundleFiles Condition="'%(AppleAssembliesToBundle._IsNative)' != 'true' and $([System.IO.Path]::GetFileName($([System.IO.Path]::GetDirectoryName('%(AppleAssembliesToBundle.Identity)')))) != '$(AssemblyName)' and '$(CustomMain)' == 'true'"
 Include="@(AppleAssembliesToBundle)" TargetDir="publish\$([System.IO.Path]::GetFileName($([System.IO.Path]::GetDirectoryName('%(AppleAssembliesToBundle.Identity)'))))" />
@ivanpovazanivanpovazanJul 21, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question: Why does it matter if $(CustomMain) is specified or not here?
@kotlarmiloskotlarmilosJul 21, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same target is used for the library and runtime tests and the condition checks if the directory is equals to the assemblyName. In case of runtime tests that is true, but for library tests that creates recursive dirs.
Probably better to use more descriptive variable.
Comment threadsrc/mono/msbuild/apple/build/AppleBuild.props
Comment threadsrc/tests/build.proj
Comment threadsrc/tests/build.proj
Outdated

 <Copy SourceFiles="@(RecursiveCopyHack)" DestinationFolder="$(FinalPath)/%(RecursiveDir)" />
 <RemoveDir Directories="$(AppBundlePath)" />
 <Message Importance="High" Text="App: $(FinalPath)" />
 <CustomTask EntryPoints="@(EntryPoints)" RunScriptCommand="$(RunScriptCommand)" AppName="$(Category)" Condition="'$(BuildTestsOnHelix)' == 'true'">
@ivanpovazanivanpovazanJul 21, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I don't have a good suggestion, but I think the task should have a more meaningful name.

Maybe something like UpdateRunScriptToHandleMultipleEntryPoints
@kotlarmiloskotlarmilosJul 21, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, I missed that.
@kotlarmilos
kotlarmilos
commented
Jul 21, 2023

Copy link


Copy Markdown

MemberAuthor
Merging this PR to enhance the apple mobile tests coverage. If additional feedback is provided, it will be addressed in a follow-up.
@kotlarmilos
kotlarmilos
merged commit 7531c50
into
dotnet:mainJul 21, 2023
@steveisok
steveisok
commented
Jul 21, 2023

Copy link


Copy Markdown

Member
LGTM! Awesome work!
@ghostghost
locked as resolved and limited conversation to collaborators
Aug 20, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ivanpovazanivanpovazanivanpovazan approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplinger
@mdh1418mdh1418Awaiting requested review from mdh1418
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@marek-safarmarek-safarAwaiting requested review from marek-safar
@steveisoksteveisokAwaiting requested review from steveisoksteveisok is a code owner

Assignees

@kotlarmiloskotlarmilos

Labels

area-Infrastructure-monoos-iosApple iOS

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@kotlarmilos@steveisok@ivanpovazan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[mono][tests] Parallel AOT compilation of runtime tests on iOS platforms by kotlarmilos · Pull Request #86089 · dotnet/runtime · GitHub
Skip to content
[mono][tests] Parallel AOT compilation of runtime tests on iOS platforms  - #86089
Merged
kotlarmilos merged 90 commits into
dotnet:mainfrom 
kotlarmilos:feature/parallel-aot-compilation
Jul 21, 2023
Merged
[mono][tests] Parallel AOT compilation of runtime tests on iOS platforms #86089
kotlarmilos merged 90 commits into
dotnet:mainfrom 
kotlarmilos:feature/parallel-aot-compilation
Conversation
@kotlarmilos
@kotlarmiloskotlarmilos
commented
May 11, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Description
This PR aims to move the AOT compilation of runtime tests to the Helix and enable the following testing groups on apple mobile platforms: tracing_eventpipe, tracing_eventlistener, reflection_regression, reflection_StaticInterfaceMembers, reflection_GenericAttribute, reflection_DefaultInterfaceMethods, baseservices_mono, baseservices_exceptions, baseservices_compilerservices, baseservices_TieredCompilation, Regressions_coreclr, Loader_classloader, Loader_StartupHooks, JIT_RyuJIT, JIT_PGO, JIT_Math, JIT_Intrinsics, Interop_DllImportSearchPaths, JIT_Intrinsics, GC_Scenarios, GC_Regressions, GC_LargeMemor, GC_Features, GC_Coverage, GC_API, Exceptions_UnwindFpBleedTest, CoreMangLib_system.
The Helix payload is generated using the runtime pipeline. Then, the libraries pipeline is utilized to AOT compile and execute the tests on Helix. The build-runtime-tests-and-send-to-helix.yml is updated with the compileOnHelix parameter, which if set, uses the libraries/helix.yml template instead of the runtime send-to-helix-step.yml template. The runtime and libraries pipelines are updated to support AOT compilation of runtime tests on Helix.
Important notes:
@kotlarmiloskotlarmilos
added

NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
NO-REVIEW
Experimental/testing PR, do NOT review it
area-Infrastructure-mono

os-ios
Apple iOS
labels
May 11, 2023
@kotlarmiloskotlarmilos
added this to the 8.0.0 milestone
May 11, 2023
@kotlarmiloskotlarmilos
self-assigned this
May 11, 2023
@ghost
ghost
commented
May 11, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @directhex

See info in area-owners.md if you want to be subscribed.
Issue Details
This PR aims to move AOT compilation of the runtime tests to Helix.
Author:kotlarmilos
Assignees:kotlarmilos
Labels:
NO-MERGE, NO-REVIEW, area-Infrastructure-mono, os-ios
Milestone:8.0.0
@kotlarmiloskotlarmilos
mentioned this pull request
May 30, 2023
 Merged

@build-analysisbuild-analysisBot
mentioned this pull request
May 30, 2023

Open

@kotlarmilos
kotlarmilos
commented
Jul 19, 2023

Copy link


Copy Markdown

MemberAuthor
@steveisok@akoeplinger@ivanpovazan@mdh1418 This pull request is ready for review. I am triaging failing tests by fixing or disabling them, but it should not affect the functionality.
List of follow-up tasks is in #84254.
@SamMonoRT Currently, there are 28 test suites (apps) that can be run on iOS, out of which 7 are failing. I will try to fix or disable the failing tests and run the remaining ones. Afterward, I suggest we review other disabled test suites for AOT compilation and prioritize those with higher impact.
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 19, 2023

Closed

@kotlarmilos
kotlarmilos
commented
Jul 19, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-ioslike,runtime-ioslikesimulator
@azure-pipelines
azure-pipelinesBot
commented
Jul 19, 2023

Copy link


Copy Markdown

No commit pushedDate could be found for PR 86089 in repo dotnet/runtime
@kotlarmilos
kotlarmilos
commented
Jul 19, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-ioslike,runtime-ioslikesimulator
@azure-pipelines
azure-pipelinesBot
commented
Jul 19, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 19, 2023

Closed

@kotlarmilos
kotlarmilos
commented
Jul 20, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-ioslikesimulator
@azure-pipelines

This comment was marked as outdated.

Sign in to view
@azure-pipelines
azure-pipelinesBot
commented
Jul 20, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@kotlarmilos
kotlarmilos
commented
Jul 20, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-ioslikesimulator
@azure-pipelines
azure-pipelinesBot
commented
Jul 20, 2023

Copy link


Copy Markdown

No commit pushedDate could be found for PR 86089 in repo dotnet/runtime
@kotlarmilos
kotlarmilos
commented
Jul 20, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-ioslikesimulator
@azure-pipelines
azure-pipelinesBot
commented
Jul 20, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jul 20, 2023

Closed


Closed

@kotlarmilos
kotlarmilos
commented
Jul 21, 2023

Copy link


Copy Markdown

MemberAuthor
ping here :)
@steveisok@akoeplinger@ivanpovazan@mdh1418
ivanpovazan
ivanpovazan
approved these changes
Jul 21, 2023
View reviewed changes
@ivanpovazanivanpovazan
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a few comments/questions looks good to me!
Comment threadeng/testing/tests.ioslike.targets

Comment on lines

+65
 to 
+73

 <!-- 
 Checks if the directory name "AppleAssembliesToBundle" is equal to the "AssemblyName",
 if they match, consider it as the root directory and copy the files there,
 otherwise, copy the files to a subdirectory.
 -->
 <BundleFiles Condition="'%(AppleAssembliesToBundle._IsNative)' != 'true' and ($([System.IO.Path]::GetFileName($([System.IO.Path]::GetDirectoryName('%(AppleAssembliesToBundle.Identity)')))) == '$(AssemblyName)' or '$(CustomMain)' != 'true')"
 Include="@(AppleAssembliesToBundle)" TargetDir="publish" />
 <BundleFiles Condition="'%(AppleAssembliesToBundle._IsNative)' != 'true' and $([System.IO.Path]::GetFileName($([System.IO.Path]::GetDirectoryName('%(AppleAssembliesToBundle.Identity)')))) != '$(AssemblyName)' and '$(CustomMain)' == 'true'"
 Include="@(AppleAssembliesToBundle)" TargetDir="publish\$([System.IO.Path]::GetFileName($([System.IO.Path]::GetDirectoryName('%(AppleAssembliesToBundle.Identity)'))))" />
@ivanpovazanivanpovazanJul 21, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question: Why does it matter if $(CustomMain) is specified or not here?
@kotlarmiloskotlarmilosJul 21, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same target is used for the library and runtime tests and the condition checks if the directory is equals to the assemblyName. In case of runtime tests that is true, but for library tests that creates recursive dirs.
Probably better to use more descriptive variable.
Comment threadsrc/mono/msbuild/apple/build/AppleBuild.props
Comment threadsrc/tests/build.proj
Comment threadsrc/tests/build.proj
Outdated

 <Copy SourceFiles="@(RecursiveCopyHack)" DestinationFolder="$(FinalPath)/%(RecursiveDir)" />
 <RemoveDir Directories="$(AppBundlePath)" />
 <Message Importance="High" Text="App: $(FinalPath)" />
 <CustomTask EntryPoints="@(EntryPoints)" RunScriptCommand="$(RunScriptCommand)" AppName="$(Category)" Condition="'$(BuildTestsOnHelix)' == 'true'">
@ivanpovazanivanpovazanJul 21, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I don't have a good suggestion, but I think the task should have a more meaningful name.

Maybe something like UpdateRunScriptToHandleMultipleEntryPoints
@kotlarmiloskotlarmilosJul 21, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, I missed that.
@kotlarmilos
kotlarmilos
commented
Jul 21, 2023

Copy link


Copy Markdown

MemberAuthor
Merging this PR to enhance the apple mobile tests coverage. If additional feedback is provided, it will be addressed in a follow-up.
@kotlarmilos
kotlarmilos
merged commit 7531c50
into
dotnet:mainJul 21, 2023
@steveisok
steveisok
commented
Jul 21, 2023

Copy link


Copy Markdown

Member
LGTM! Awesome work!
@ghostghost
locked as resolved and limited conversation to collaborators
Aug 20, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ivanpovazanivanpovazanivanpovazan approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplinger
@mdh1418mdh1418Awaiting requested review from mdh1418
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@marek-safarmarek-safarAwaiting requested review from marek-safar
@steveisoksteveisokAwaiting requested review from steveisoksteveisok is a code owner

Assignees

@kotlarmiloskotlarmilos

Labels

area-Infrastructure-monoos-iosApple iOS

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@kotlarmilos@steveisok@ivanpovazan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[mono][tests] Parallel AOT compilation of runtime tests on iOS platforms by kotlarmilos · Pull Request #86089 · dotnet/runtime · GitHub
Skip to content
[mono][tests] Parallel AOT compilation of runtime tests on iOS platforms  - #86089
Merged
kotlarmilos merged 90 commits into
dotnet:mainfrom 
kotlarmilos:feature/parallel-aot-compilation
Jul 21, 2023
Merged
[mono][tests] Parallel AOT compilation of runtime tests on iOS platforms #86089
kotlarmilos merged 90 commits into
dotnet:mainfrom 
kotlarmilos:feature/parallel-aot-compilation
Conversation
@kotlarmilos
@kotlarmiloskotlarmilos
commented
May 11, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Description
This PR aims to move the AOT compilation of runtime tests to the Helix and enable the following testing groups on apple mobile platforms: tracing_eventpipe, tracing_eventlistener, reflection_regression, reflection_StaticInterfaceMembers, reflection_GenericAttribute, reflection_DefaultInterfaceMethods, baseservices_mono, baseservices_exceptions, baseservices_compilerservices, baseservices_TieredCompilation, Regressions_coreclr, Loader_classloader, Loader_StartupHooks, JIT_RyuJIT, JIT_PGO, JIT_Math, JIT_Intrinsics, Interop_DllImportSearchPaths, JIT_Intrinsics, GC_Scenarios, GC_Regressions, GC_LargeMemor, GC_Features, GC_Coverage, GC_API, Exceptions_UnwindFpBleedTest, CoreMangLib_system.
The Helix payload is generated using the runtime pipeline. Then, the libraries pipeline is utilized to AOT compile and execute the tests on Helix. The build-runtime-tests-and-send-to-helix.yml is updated with the compileOnHelix parameter, which if set, uses the libraries/helix.yml template instead of the runtime send-to-helix-step.yml template. The runtime and libraries pipelines are updated to support AOT compilation of runtime tests on Helix.
Important notes:
@kotlarmiloskotlarmilos
added

NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
NO-REVIEW
Experimental/testing PR, do NOT review it
area-Infrastructure-mono

os-ios
Apple iOS
labels
May 11, 2023
@kotlarmiloskotlarmilos
added this to the 8.0.0 milestone
May 11, 2023
@kotlarmiloskotlarmilos
self-assigned this
May 11, 2023
@ghost
ghost
commented
May 11, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @directhex

See info in area-owners.md if you want to be subscribed.
Issue Details
This PR aims to move AOT compilation of the runtime tests to Helix.
Author:kotlarmilos
Assignees:kotlarmilos
Labels:
NO-MERGE, NO-REVIEW, area-Infrastructure-mono, os-ios
Milestone:8.0.0
@kotlarmiloskotlarmilos
mentioned this pull request
May 30, 2023
 Merged

@build-analysisbuild-analysisBot
mentioned this pull request
May 30, 2023

Open

@kotlarmilos
kotlarmilos
commented
Jul 19, 2023

Copy link


Copy Markdown

MemberAuthor
@steveisok@akoeplinger@ivanpovazan@mdh1418 This pull request is ready for review. I am triaging failing tests by fixing or disabling them, but it should not affect the functionality.
List of follow-up tasks is in #84254.
@SamMonoRT Currently, there are 28 test suites (apps) that can be run on iOS, out of which 7 are failing. I will try to fix or disable the failing tests and run the remaining ones. Afterward, I suggest we review other disabled test suites for AOT compilation and prioritize those with higher impact.
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 19, 2023

Closed

@kotlarmilos
kotlarmilos
commented
Jul 19, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-ioslike,runtime-ioslikesimulator
@azure-pipelines
azure-pipelinesBot
commented
Jul 19, 2023

Copy link


Copy Markdown

No commit pushedDate could be found for PR 86089 in repo dotnet/runtime
@kotlarmilos
kotlarmilos
commented
Jul 19, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-ioslike,runtime-ioslikesimulator
@azure-pipelines
azure-pipelinesBot
commented
Jul 19, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 19, 2023

Closed

@kotlarmilos
kotlarmilos
commented
Jul 20, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-ioslikesimulator
@azure-pipelines

This comment was marked as outdated.

Sign in to view
@azure-pipelines
azure-pipelinesBot
commented
Jul 20, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@kotlarmilos
kotlarmilos
commented
Jul 20, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-ioslikesimulator
@azure-pipelines
azure-pipelinesBot
commented
Jul 20, 2023

Copy link


Copy Markdown

No commit pushedDate could be found for PR 86089 in repo dotnet/runtime
@kotlarmilos
kotlarmilos
commented
Jul 20, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-ioslikesimulator
@azure-pipelines
azure-pipelinesBot
commented
Jul 20, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jul 20, 2023

Closed


Closed

@kotlarmilos
kotlarmilos
commented
Jul 21, 2023

Copy link


Copy Markdown

MemberAuthor
ping here :)
@steveisok@akoeplinger@ivanpovazan@mdh1418
ivanpovazan
ivanpovazan
approved these changes
Jul 21, 2023
View reviewed changes
@ivanpovazanivanpovazan
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a few comments/questions looks good to me!
Comment threadeng/testing/tests.ioslike.targets

Comment on lines

+65
 to 
+73

 <!-- 
 Checks if the directory name "AppleAssembliesToBundle" is equal to the "AssemblyName",
 if they match, consider it as the root directory and copy the files there,
 otherwise, copy the files to a subdirectory.
 -->
 <BundleFiles Condition="'%(AppleAssembliesToBundle._IsNative)' != 'true' and ($([System.IO.Path]::GetFileName($([System.IO.Path]::GetDirectoryName('%(AppleAssembliesToBundle.Identity)')))) == '$(AssemblyName)' or '$(CustomMain)' != 'true')"
 Include="@(AppleAssembliesToBundle)" TargetDir="publish" />
 <BundleFiles Condition="'%(AppleAssembliesToBundle._IsNative)' != 'true' and $([System.IO.Path]::GetFileName($([System.IO.Path]::GetDirectoryName('%(AppleAssembliesToBundle.Identity)')))) != '$(AssemblyName)' and '$(CustomMain)' == 'true'"
 Include="@(AppleAssembliesToBundle)" TargetDir="publish\$([System.IO.Path]::GetFileName($([System.IO.Path]::GetDirectoryName('%(AppleAssembliesToBundle.Identity)'))))" />
@ivanpovazanivanpovazanJul 21, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question: Why does it matter if $(CustomMain) is specified or not here?
@kotlarmiloskotlarmilosJul 21, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same target is used for the library and runtime tests and the condition checks if the directory is equals to the assemblyName. In case of runtime tests that is true, but for library tests that creates recursive dirs.
Probably better to use more descriptive variable.
Comment threadsrc/mono/msbuild/apple/build/AppleBuild.props
Comment threadsrc/tests/build.proj
Comment threadsrc/tests/build.proj
Outdated

 <Copy SourceFiles="@(RecursiveCopyHack)" DestinationFolder="$(FinalPath)/%(RecursiveDir)" />
 <RemoveDir Directories="$(AppBundlePath)" />
 <Message Importance="High" Text="App: $(FinalPath)" />
 <CustomTask EntryPoints="@(EntryPoints)" RunScriptCommand="$(RunScriptCommand)" AppName="$(Category)" Condition="'$(BuildTestsOnHelix)' == 'true'">
@ivanpovazanivanpovazanJul 21, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I don't have a good suggestion, but I think the task should have a more meaningful name.

Maybe something like UpdateRunScriptToHandleMultipleEntryPoints
@kotlarmiloskotlarmilosJul 21, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, I missed that.
@kotlarmilos
kotlarmilos
commented
Jul 21, 2023

Copy link


Copy Markdown

MemberAuthor
Merging this PR to enhance the apple mobile tests coverage. If additional feedback is provided, it will be addressed in a follow-up.
@kotlarmilos
kotlarmilos
merged commit 7531c50
into
dotnet:mainJul 21, 2023
@steveisok
steveisok
commented
Jul 21, 2023

Copy link


Copy Markdown

Member
LGTM! Awesome work!
@ghostghost
locked as resolved and limited conversation to collaborators
Aug 20, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ivanpovazanivanpovazanivanpovazan approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplinger
@mdh1418mdh1418Awaiting requested review from mdh1418
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@marek-safarmarek-safarAwaiting requested review from marek-safar
@steveisoksteveisokAwaiting requested review from steveisoksteveisok is a code owner

Assignees

@kotlarmiloskotlarmilos

Labels

area-Infrastructure-monoos-iosApple iOS

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@kotlarmilos@steveisok@ivanpovazan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[mono][tests] Parallel AOT compilation of runtime tests on iOS platforms by kotlarmilos · Pull Request #86089 · dotnet/runtime · GitHub
Skip to content
[mono][tests] Parallel AOT compilation of runtime tests on iOS platforms  - #86089
Merged
kotlarmilos merged 90 commits into
dotnet:mainfrom 
kotlarmilos:feature/parallel-aot-compilation
Jul 21, 2023
Merged
[mono][tests] Parallel AOT compilation of runtime tests on iOS platforms #86089
kotlarmilos merged 90 commits into
dotnet:mainfrom 
kotlarmilos:feature/parallel-aot-compilation
Conversation
@kotlarmilos
@kotlarmiloskotlarmilos
commented
May 11, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Description
This PR aims to move the AOT compilation of runtime tests to the Helix and enable the following testing groups on apple mobile platforms: tracing_eventpipe, tracing_eventlistener, reflection_regression, reflection_StaticInterfaceMembers, reflection_GenericAttribute, reflection_DefaultInterfaceMethods, baseservices_mono, baseservices_exceptions, baseservices_compilerservices, baseservices_TieredCompilation, Regressions_coreclr, Loader_classloader, Loader_StartupHooks, JIT_RyuJIT, JIT_PGO, JIT_Math, JIT_Intrinsics, Interop_DllImportSearchPaths, JIT_Intrinsics, GC_Scenarios, GC_Regressions, GC_LargeMemor, GC_Features, GC_Coverage, GC_API, Exceptions_UnwindFpBleedTest, CoreMangLib_system.
The Helix payload is generated using the runtime pipeline. Then, the libraries pipeline is utilized to AOT compile and execute the tests on Helix. The build-runtime-tests-and-send-to-helix.yml is updated with the compileOnHelix parameter, which if set, uses the libraries/helix.yml template instead of the runtime send-to-helix-step.yml template. The runtime and libraries pipelines are updated to support AOT compilation of runtime tests on Helix.
Important notes:
@kotlarmiloskotlarmilos
added

NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
NO-REVIEW
Experimental/testing PR, do NOT review it
area-Infrastructure-mono

os-ios
Apple iOS
labels
May 11, 2023
@kotlarmiloskotlarmilos
added this to the 8.0.0 milestone
May 11, 2023
@kotlarmiloskotlarmilos
self-assigned this
May 11, 2023
@ghost
ghost
commented
May 11, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @directhex

See info in area-owners.md if you want to be subscribed.
Issue Details
This PR aims to move AOT compilation of the runtime tests to Helix.
Author:kotlarmilos
Assignees:kotlarmilos
Labels:
NO-MERGE, NO-REVIEW, area-Infrastructure-mono, os-ios
Milestone:8.0.0
@kotlarmiloskotlarmilos
mentioned this pull request
May 30, 2023
 Merged

@build-analysisbuild-analysisBot
mentioned this pull request
May 30, 2023

Open

@kotlarmilos
kotlarmilos
commented
Jul 19, 2023

Copy link


Copy Markdown

MemberAuthor
@steveisok@akoeplinger@ivanpovazan@mdh1418 This pull request is ready for review. I am triaging failing tests by fixing or disabling them, but it should not affect the functionality.
List of follow-up tasks is in #84254.
@SamMonoRT Currently, there are 28 test suites (apps) that can be run on iOS, out of which 7 are failing. I will try to fix or disable the failing tests and run the remaining ones. Afterward, I suggest we review other disabled test suites for AOT compilation and prioritize those with higher impact.
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 19, 2023

Closed

@kotlarmilos
kotlarmilos
commented
Jul 19, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-ioslike,runtime-ioslikesimulator
@azure-pipelines
azure-pipelinesBot
commented
Jul 19, 2023

Copy link


Copy Markdown

No commit pushedDate could be found for PR 86089 in repo dotnet/runtime
@kotlarmilos
kotlarmilos
commented
Jul 19, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-ioslike,runtime-ioslikesimulator
@azure-pipelines
azure-pipelinesBot
commented
Jul 19, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 19, 2023

Closed

@kotlarmilos
kotlarmilos
commented
Jul 20, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-ioslikesimulator
@azure-pipelines

This comment was marked as outdated.

Sign in to view
@azure-pipelines
azure-pipelinesBot
commented
Jul 20, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@kotlarmilos
kotlarmilos
commented
Jul 20, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-ioslikesimulator
@azure-pipelines
azure-pipelinesBot
commented
Jul 20, 2023

Copy link


Copy Markdown

No commit pushedDate could be found for PR 86089 in repo dotnet/runtime
@kotlarmilos
kotlarmilos
commented
Jul 20, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-ioslikesimulator
@azure-pipelines
azure-pipelinesBot
commented
Jul 20, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jul 20, 2023

Closed


Closed

@kotlarmilos
kotlarmilos
commented
Jul 21, 2023

Copy link


Copy Markdown

MemberAuthor
ping here :)
@steveisok@akoeplinger@ivanpovazan@mdh1418
ivanpovazan
ivanpovazan
approved these changes
Jul 21, 2023
View reviewed changes
@ivanpovazanivanpovazan
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a few comments/questions looks good to me!
Comment threadeng/testing/tests.ioslike.targets

Comment on lines

+65
 to 
+73

 <!-- 
 Checks if the directory name "AppleAssembliesToBundle" is equal to the "AssemblyName",
 if they match, consider it as the root directory and copy the files there,
 otherwise, copy the files to a subdirectory.
 -->
 <BundleFiles Condition="'%(AppleAssembliesToBundle._IsNative)' != 'true' and ($([System.IO.Path]::GetFileName($([System.IO.Path]::GetDirectoryName('%(AppleAssembliesToBundle.Identity)')))) == '$(AssemblyName)' or '$(CustomMain)' != 'true')"
 Include="@(AppleAssembliesToBundle)" TargetDir="publish" />
 <BundleFiles Condition="'%(AppleAssembliesToBundle._IsNative)' != 'true' and $([System.IO.Path]::GetFileName($([System.IO.Path]::GetDirectoryName('%(AppleAssembliesToBundle.Identity)')))) != '$(AssemblyName)' and '$(CustomMain)' == 'true'"
 Include="@(AppleAssembliesToBundle)" TargetDir="publish\$([System.IO.Path]::GetFileName($([System.IO.Path]::GetDirectoryName('%(AppleAssembliesToBundle.Identity)'))))" />
@ivanpovazanivanpovazanJul 21, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question: Why does it matter if $(CustomMain) is specified or not here?
@kotlarmiloskotlarmilosJul 21, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same target is used for the library and runtime tests and the condition checks if the directory is equals to the assemblyName. In case of runtime tests that is true, but for library tests that creates recursive dirs.
Probably better to use more descriptive variable.
Comment threadsrc/mono/msbuild/apple/build/AppleBuild.props
Comment threadsrc/tests/build.proj
Comment threadsrc/tests/build.proj
Outdated

 <Copy SourceFiles="@(RecursiveCopyHack)" DestinationFolder="$(FinalPath)/%(RecursiveDir)" />
 <RemoveDir Directories="$(AppBundlePath)" />
 <Message Importance="High" Text="App: $(FinalPath)" />
 <CustomTask EntryPoints="@(EntryPoints)" RunScriptCommand="$(RunScriptCommand)" AppName="$(Category)" Condition="'$(BuildTestsOnHelix)' == 'true'">
@ivanpovazanivanpovazanJul 21, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I don't have a good suggestion, but I think the task should have a more meaningful name.

Maybe something like UpdateRunScriptToHandleMultipleEntryPoints
@kotlarmiloskotlarmilosJul 21, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, I missed that.
@kotlarmilos
kotlarmilos
commented
Jul 21, 2023

Copy link


Copy Markdown

MemberAuthor
Merging this PR to enhance the apple mobile tests coverage. If additional feedback is provided, it will be addressed in a follow-up.
@kotlarmilos
kotlarmilos
merged commit 7531c50
into
dotnet:mainJul 21, 2023
@steveisok
steveisok
commented
Jul 21, 2023

Copy link


Copy Markdown

Member
LGTM! Awesome work!
@ghostghost
locked as resolved and limited conversation to collaborators
Aug 20, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ivanpovazanivanpovazanivanpovazan approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplinger
@mdh1418mdh1418Awaiting requested review from mdh1418
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@marek-safarmarek-safarAwaiting requested review from marek-safar
@steveisoksteveisokAwaiting requested review from steveisoksteveisok is a code owner

Assignees

@kotlarmiloskotlarmilos

Labels

area-Infrastructure-monoos-iosApple iOS

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@kotlarmilos@steveisok@ivanpovazan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[mono][tests] Parallel AOT compilation of runtime tests on iOS platforms by kotlarmilos · Pull Request #86089 · dotnet/runtime · GitHub
Skip to content
[mono][tests] Parallel AOT compilation of runtime tests on iOS platforms  - #86089
Merged
kotlarmilos merged 90 commits into
dotnet:mainfrom 
kotlarmilos:feature/parallel-aot-compilation
Jul 21, 2023
Merged
[mono][tests] Parallel AOT compilation of runtime tests on iOS platforms #86089
kotlarmilos merged 90 commits into
dotnet:mainfrom 
kotlarmilos:feature/parallel-aot-compilation
Conversation
@kotlarmilos
@kotlarmiloskotlarmilos
commented
May 11, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Description
This PR aims to move the AOT compilation of runtime tests to the Helix and enable the following testing groups on apple mobile platforms: tracing_eventpipe, tracing_eventlistener, reflection_regression, reflection_StaticInterfaceMembers, reflection_GenericAttribute, reflection_DefaultInterfaceMethods, baseservices_mono, baseservices_exceptions, baseservices_compilerservices, baseservices_TieredCompilation, Regressions_coreclr, Loader_classloader, Loader_StartupHooks, JIT_RyuJIT, JIT_PGO, JIT_Math, JIT_Intrinsics, Interop_DllImportSearchPaths, JIT_Intrinsics, GC_Scenarios, GC_Regressions, GC_LargeMemor, GC_Features, GC_Coverage, GC_API, Exceptions_UnwindFpBleedTest, CoreMangLib_system.
The Helix payload is generated using the runtime pipeline. Then, the libraries pipeline is utilized to AOT compile and execute the tests on Helix. The build-runtime-tests-and-send-to-helix.yml is updated with the compileOnHelix parameter, which if set, uses the libraries/helix.yml template instead of the runtime send-to-helix-step.yml template. The runtime and libraries pipelines are updated to support AOT compilation of runtime tests on Helix.
Important notes:
@kotlarmiloskotlarmilos
added

NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
NO-REVIEW
Experimental/testing PR, do NOT review it
area-Infrastructure-mono

os-ios
Apple iOS
labels
May 11, 2023
@kotlarmiloskotlarmilos
added this to the 8.0.0 milestone
May 11, 2023
@kotlarmiloskotlarmilos
self-assigned this
May 11, 2023
@ghost
ghost
commented
May 11, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @directhex

See info in area-owners.md if you want to be subscribed.
Issue Details
This PR aims to move AOT compilation of the runtime tests to Helix.
Author:kotlarmilos
Assignees:kotlarmilos
Labels:
NO-MERGE, NO-REVIEW, area-Infrastructure-mono, os-ios
Milestone:8.0.0
@kotlarmiloskotlarmilos
mentioned this pull request
May 30, 2023
 Merged

@build-analysisbuild-analysisBot
mentioned this pull request
May 30, 2023

Open

@kotlarmilos
kotlarmilos
commented
Jul 19, 2023

Copy link


Copy Markdown

MemberAuthor
@steveisok@akoeplinger@ivanpovazan@mdh1418 This pull request is ready for review. I am triaging failing tests by fixing or disabling them, but it should not affect the functionality.
List of follow-up tasks is in #84254.
@SamMonoRT Currently, there are 28 test suites (apps) that can be run on iOS, out of which 7 are failing. I will try to fix or disable the failing tests and run the remaining ones. Afterward, I suggest we review other disabled test suites for AOT compilation and prioritize those with higher impact.
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 19, 2023

Closed

@kotlarmilos
kotlarmilos
commented
Jul 19, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-ioslike,runtime-ioslikesimulator
@azure-pipelines
azure-pipelinesBot
commented
Jul 19, 2023

Copy link


Copy Markdown

No commit pushedDate could be found for PR 86089 in repo dotnet/runtime
@kotlarmilos
kotlarmilos
commented
Jul 19, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-ioslike,runtime-ioslikesimulator
@azure-pipelines
azure-pipelinesBot
commented
Jul 19, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 19, 2023

Closed

@kotlarmilos
kotlarmilos
commented
Jul 20, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-ioslikesimulator
@azure-pipelines

This comment was marked as outdated.

Sign in to view
@azure-pipelines
azure-pipelinesBot
commented
Jul 20, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@kotlarmilos
kotlarmilos
commented
Jul 20, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-ioslikesimulator
@azure-pipelines
azure-pipelinesBot
commented
Jul 20, 2023

Copy link


Copy Markdown

No commit pushedDate could be found for PR 86089 in repo dotnet/runtime
@kotlarmilos
kotlarmilos
commented
Jul 20, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-ioslikesimulator
@azure-pipelines
azure-pipelinesBot
commented
Jul 20, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jul 20, 2023

Closed


Closed

@kotlarmilos
kotlarmilos
commented
Jul 21, 2023

Copy link


Copy Markdown

MemberAuthor
ping here :)
@steveisok@akoeplinger@ivanpovazan@mdh1418
ivanpovazan
ivanpovazan
approved these changes
Jul 21, 2023
View reviewed changes
@ivanpovazanivanpovazan
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a few comments/questions looks good to me!
Comment threadeng/testing/tests.ioslike.targets

Comment on lines

+65
 to 
+73

 <!-- 
 Checks if the directory name "AppleAssembliesToBundle" is equal to the "AssemblyName",
 if they match, consider it as the root directory and copy the files there,
 otherwise, copy the files to a subdirectory.
 -->
 <BundleFiles Condition="'%(AppleAssembliesToBundle._IsNative)' != 'true' and ($([System.IO.Path]::GetFileName($([System.IO.Path]::GetDirectoryName('%(AppleAssembliesToBundle.Identity)')))) == '$(AssemblyName)' or '$(CustomMain)' != 'true')"
 Include="@(AppleAssembliesToBundle)" TargetDir="publish" />
 <BundleFiles Condition="'%(AppleAssembliesToBundle._IsNative)' != 'true' and $([System.IO.Path]::GetFileName($([System.IO.Path]::GetDirectoryName('%(AppleAssembliesToBundle.Identity)')))) != '$(AssemblyName)' and '$(CustomMain)' == 'true'"
 Include="@(AppleAssembliesToBundle)" TargetDir="publish\$([System.IO.Path]::GetFileName($([System.IO.Path]::GetDirectoryName('%(AppleAssembliesToBundle.Identity)'))))" />
@ivanpovazanivanpovazanJul 21, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question: Why does it matter if $(CustomMain) is specified or not here?
@kotlarmiloskotlarmilosJul 21, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same target is used for the library and runtime tests and the condition checks if the directory is equals to the assemblyName. In case of runtime tests that is true, but for library tests that creates recursive dirs.
Probably better to use more descriptive variable.
Comment threadsrc/mono/msbuild/apple/build/AppleBuild.props
Comment threadsrc/tests/build.proj
Comment threadsrc/tests/build.proj
Outdated

 <Copy SourceFiles="@(RecursiveCopyHack)" DestinationFolder="$(FinalPath)/%(RecursiveDir)" />
 <RemoveDir Directories="$(AppBundlePath)" />
 <Message Importance="High" Text="App: $(FinalPath)" />
 <CustomTask EntryPoints="@(EntryPoints)" RunScriptCommand="$(RunScriptCommand)" AppName="$(Category)" Condition="'$(BuildTestsOnHelix)' == 'true'">
@ivanpovazanivanpovazanJul 21, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I don't have a good suggestion, but I think the task should have a more meaningful name.

Maybe something like UpdateRunScriptToHandleMultipleEntryPoints
@kotlarmiloskotlarmilosJul 21, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, I missed that.
@kotlarmilos
kotlarmilos
commented
Jul 21, 2023

Copy link


Copy Markdown

MemberAuthor
Merging this PR to enhance the apple mobile tests coverage. If additional feedback is provided, it will be addressed in a follow-up.
@kotlarmilos
kotlarmilos
merged commit 7531c50
into
dotnet:mainJul 21, 2023
@steveisok
steveisok
commented
Jul 21, 2023

Copy link


Copy Markdown

Member
LGTM! Awesome work!
@ghostghost
locked as resolved and limited conversation to collaborators
Aug 20, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ivanpovazanivanpovazanivanpovazan approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplinger
@mdh1418mdh1418Awaiting requested review from mdh1418
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@marek-safarmarek-safarAwaiting requested review from marek-safar
@steveisoksteveisokAwaiting requested review from steveisoksteveisok is a code owner

Assignees

@kotlarmiloskotlarmilos

Labels

area-Infrastructure-monoos-iosApple iOS

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@kotlarmilos@steveisok@ivanpovazan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
[mono][tests] Parallel AOT compilation of runtime tests on iOS platforms by kotlarmilos · Pull Request #86089 · dotnet/runtime · GitHub
Skip to content
[mono][tests] Parallel AOT compilation of runtime tests on iOS platforms  - #86089
Merged
kotlarmilos merged 90 commits into
dotnet:mainfrom 
kotlarmilos:feature/parallel-aot-compilation
Jul 21, 2023
Merged
[mono][tests] Parallel AOT compilation of runtime tests on iOS platforms #86089
kotlarmilos merged 90 commits into
dotnet:mainfrom 
kotlarmilos:feature/parallel-aot-compilation
Conversation
@kotlarmilos
@kotlarmiloskotlarmilos
commented
May 11, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Description
This PR aims to move the AOT compilation of runtime tests to the Helix and enable the following testing groups on apple mobile platforms: tracing_eventpipe, tracing_eventlistener, reflection_regression, reflection_StaticInterfaceMembers, reflection_GenericAttribute, reflection_DefaultInterfaceMethods, baseservices_mono, baseservices_exceptions, baseservices_compilerservices, baseservices_TieredCompilation, Regressions_coreclr, Loader_classloader, Loader_StartupHooks, JIT_RyuJIT, JIT_PGO, JIT_Math, JIT_Intrinsics, Interop_DllImportSearchPaths, JIT_Intrinsics, GC_Scenarios, GC_Regressions, GC_LargeMemor, GC_Features, GC_Coverage, GC_API, Exceptions_UnwindFpBleedTest, CoreMangLib_system.
The Helix payload is generated using the runtime pipeline. Then, the libraries pipeline is utilized to AOT compile and execute the tests on Helix. The build-runtime-tests-and-send-to-helix.yml is updated with the compileOnHelix parameter, which if set, uses the libraries/helix.yml template instead of the runtime send-to-helix-step.yml template. The runtime and libraries pipelines are updated to support AOT compilation of runtime tests on Helix.
Important notes:
@kotlarmiloskotlarmilos
added

NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
NO-REVIEW
Experimental/testing PR, do NOT review it
area-Infrastructure-mono

os-ios
Apple iOS
labels
May 11, 2023
@kotlarmiloskotlarmilos
added this to the 8.0.0 milestone
May 11, 2023
@kotlarmiloskotlarmilos
self-assigned this
May 11, 2023
@ghost
ghost
commented
May 11, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @directhex

See info in area-owners.md if you want to be subscribed.
Issue Details
This PR aims to move AOT compilation of the runtime tests to Helix.
Author:kotlarmilos
Assignees:kotlarmilos
Labels:
NO-MERGE, NO-REVIEW, area-Infrastructure-mono, os-ios
Milestone:8.0.0
@kotlarmiloskotlarmilos
mentioned this pull request
May 30, 2023
 Merged

@build-analysisbuild-analysisBot
mentioned this pull request
May 30, 2023

Open

@kotlarmilos
kotlarmilos
commented
Jul 19, 2023

Copy link


Copy Markdown

MemberAuthor
@steveisok@akoeplinger@ivanpovazan@mdh1418 This pull request is ready for review. I am triaging failing tests by fixing or disabling them, but it should not affect the functionality.
List of follow-up tasks is in #84254.
@SamMonoRT Currently, there are 28 test suites (apps) that can be run on iOS, out of which 7 are failing. I will try to fix or disable the failing tests and run the remaining ones. Afterward, I suggest we review other disabled test suites for AOT compilation and prioritize those with higher impact.
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 19, 2023

Closed

@kotlarmilos
kotlarmilos
commented
Jul 19, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-ioslike,runtime-ioslikesimulator
@azure-pipelines
azure-pipelinesBot
commented
Jul 19, 2023

Copy link


Copy Markdown

No commit pushedDate could be found for PR 86089 in repo dotnet/runtime
@kotlarmilos
kotlarmilos
commented
Jul 19, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-ioslike,runtime-ioslikesimulator
@azure-pipelines
azure-pipelinesBot
commented
Jul 19, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 19, 2023

Closed

@kotlarmilos
kotlarmilos
commented
Jul 20, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-ioslikesimulator
@azure-pipelines

This comment was marked as outdated.

Sign in to view
@azure-pipelines
azure-pipelinesBot
commented
Jul 20, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@kotlarmilos
kotlarmilos
commented
Jul 20, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-ioslikesimulator
@azure-pipelines
azure-pipelinesBot
commented
Jul 20, 2023

Copy link


Copy Markdown

No commit pushedDate could be found for PR 86089 in repo dotnet/runtime
@kotlarmilos
kotlarmilos
commented
Jul 20, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-ioslikesimulator
@azure-pipelines
azure-pipelinesBot
commented
Jul 20, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jul 20, 2023

Closed


Closed

@kotlarmilos
kotlarmilos
commented
Jul 21, 2023

Copy link


Copy Markdown

MemberAuthor
ping here :)
@steveisok@akoeplinger@ivanpovazan@mdh1418
ivanpovazan
ivanpovazan
approved these changes
Jul 21, 2023
View reviewed changes
@ivanpovazanivanpovazan
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a few comments/questions looks good to me!
Comment threadeng/testing/tests.ioslike.targets

Comment on lines

+65
 to 
+73

 <!-- 
 Checks if the directory name "AppleAssembliesToBundle" is equal to the "AssemblyName",
 if they match, consider it as the root directory and copy the files there,
 otherwise, copy the files to a subdirectory.
 -->
 <BundleFiles Condition="'%(AppleAssembliesToBundle._IsNative)' != 'true' and ($([System.IO.Path]::GetFileName($([System.IO.Path]::GetDirectoryName('%(AppleAssembliesToBundle.Identity)')))) == '$(AssemblyName)' or '$(CustomMain)' != 'true')"
 Include="@(AppleAssembliesToBundle)" TargetDir="publish" />
 <BundleFiles Condition="'%(AppleAssembliesToBundle._IsNative)' != 'true' and $([System.IO.Path]::GetFileName($([System.IO.Path]::GetDirectoryName('%(AppleAssembliesToBundle.Identity)')))) != '$(AssemblyName)' and '$(CustomMain)' == 'true'"
 Include="@(AppleAssembliesToBundle)" TargetDir="publish\$([System.IO.Path]::GetFileName($([System.IO.Path]::GetDirectoryName('%(AppleAssembliesToBundle.Identity)'))))" />
@ivanpovazanivanpovazanJul 21, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question: Why does it matter if $(CustomMain) is specified or not here?
@kotlarmiloskotlarmilosJul 21, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same target is used for the library and runtime tests and the condition checks if the directory is equals to the assemblyName. In case of runtime tests that is true, but for library tests that creates recursive dirs.
Probably better to use more descriptive variable.
Comment threadsrc/mono/msbuild/apple/build/AppleBuild.props
Comment threadsrc/tests/build.proj
Comment threadsrc/tests/build.proj
Outdated

 <Copy SourceFiles="@(RecursiveCopyHack)" DestinationFolder="$(FinalPath)/%(RecursiveDir)" />
 <RemoveDir Directories="$(AppBundlePath)" />
 <Message Importance="High" Text="App: $(FinalPath)" />
 <CustomTask EntryPoints="@(EntryPoints)" RunScriptCommand="$(RunScriptCommand)" AppName="$(Category)" Condition="'$(BuildTestsOnHelix)' == 'true'">
@ivanpovazanivanpovazanJul 21, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I don't have a good suggestion, but I think the task should have a more meaningful name.

Maybe something like UpdateRunScriptToHandleMultipleEntryPoints
@kotlarmiloskotlarmilosJul 21, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, I missed that.
@kotlarmilos
kotlarmilos
commented
Jul 21, 2023

Copy link


Copy Markdown

MemberAuthor
Merging this PR to enhance the apple mobile tests coverage. If additional feedback is provided, it will be addressed in a follow-up.
@kotlarmilos
kotlarmilos
merged commit 7531c50
into
dotnet:mainJul 21, 2023
@steveisok
steveisok
commented
Jul 21, 2023

Copy link


Copy Markdown

Member
LGTM! Awesome work!
@ghostghost
locked as resolved and limited conversation to collaborators
Aug 20, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ivanpovazanivanpovazanivanpovazan approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplinger
@mdh1418mdh1418Awaiting requested review from mdh1418
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@marek-safarmarek-safarAwaiting requested review from marek-safar
@steveisoksteveisokAwaiting requested review from steveisoksteveisok is a code owner

Assignees

@kotlarmiloskotlarmilos

Labels

area-Infrastructure-monoos-iosApple iOS

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@kotlarmilos@steveisok@ivanpovazan